[Bug middle-end/116208] New: "inlined from" diagnostic note has whitespace after function name

[Bug middle-end/116208] New: "inlined from" diagnostic note has whitespace after function name

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

            Bug ID: 116208
           Summary: "inlined from" diagnostic note has whitespace after
                    function name
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

The 'inlined from' name has whitespace at the end of it.

```
In member function ‘set’,
    inlined from ‘__ct_base ’ at
/var/tmp/portage/sys-devel/gcc-15.0.9999/work/gcc-15.0.9999/gcc/range-op.cc:111:7:
/var/tmp/portage/sys-devel/gcc-15.0.9999/work/gcc-15.0.9999/gcc/range-op.h:404:7:
warning: ‘*this_2(D).m_range_tree[92]’ may be used uninitialized
[-Wmaybe-uninitialized]
  404 |       gcc_checking_assert (m_range_tree[code] == NULL);
      |       ^
```

[Bug middle-end/116208] "inlined from" diagnostic note has whitespace after function name

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Oh!

$ rg __ct_base
gcc/cp/decl.cc:4782:    {"__ct_base ", &base_ctor_identifier, cik_ctor},

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |c++

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
`__ct_base ` most like should be `range_op_table::range_op_table(..)` .

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the fix for the warning should be:
  range_operator *m_range_tree[RANGE_OP_TABLE_SIZE]{}; in range-op.h.

That is value initialize m_range_tree which was not done before hand.

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Does this show up only with LTO?

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
Pretty sure yes.

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note without LTO we get the correct function name.

[Bug c++/116208] "inlined from" diagnostic note has whitespace after function name

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note I have a fix for the ranger code; this is not a fix for the diagnostic
issue mentioned here.

[Bug c++/116208] `__ct_base ` is used instead of the ctor name in warning's `inlined from` when using LTO

[simartin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116208

Simon Martin <simartin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simartin at gcc dot gnu.org

--- Comment #8 from Simon Martin <simartin at gcc dot gnu.org> ---
Thanks sjames@ for tagging me in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105483.

My hunch is that we end up printing the internal name because of the
   if (!DECL_LANG_SPECIFIC (t))
in error.cc's dump_function_name (in which case I think the bug can't really be
fixed...), but I don't know how to be sure.

How do you reproduce this? Are you configuring with
--with-build-config=bootstrap-lto?