[Bug tree-optimization/116348] New: [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[Bug tree-optimization/116348] New: [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

            Bug ID: 116348
           Summary: [15 regression] ICE when building gavl-1.4.0 with -O3
                    -march=znver4
           Product: gcc
           Version: 15.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 58913
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58913&action=edit
scale_generic_c.i

The original reporter, tdr, hit this with '-O3 -march=sapphirerapids
-mprefer-vector-width=512', but it shows up nicely with just '-O3
-march=znver4'.

```
$ gcc x.i -O3 -march=znver4
during GIMPLE pass: vect
In file included from
/var/tmp/portage/media-libs/gavl-1.4.0-r3/work/gavl-1.4.0/gavl/c/scale_generic_c.c:571:
/var/tmp/portage/media-libs/gavl-1.4.0-r3/work/gavl-1.4.0/gavl/c/scale_generic_y.h:
In function ‘scale_uint16_x_4_y_generic_c’:
/var/tmp/portage/media-libs/gavl-1.4.0-r3/work/gavl-1.4.0/gavl/c/scale_generic_y.h:21:14:
internal compiler error: in vect_transform_stmt, at tree-vect-stmts.cc:13396
0x55eb07f84101 internal_error(char const*, ...)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/diagnostic-global-context.cc:491
0x55eb07f8429c fancy_abort(char const*, int, char const*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/diagnostic.cc:1772
0x55eb0702d74a vect_transform_stmt(vec_info*, _stmt_vec_info*,
gimple_stmt_iterator*, _slp_tree*, _slp_instance*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-stmts.cc:13396
0x55eb08a66b4f vect_schedule_slp_node
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-slp.cc:9970
0x55eb08a66b4f vect_schedule_slp_node
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-slp.cc:9749
0x55eb08a65e2f vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-slp.cc:10208
0x55eb08a65d7b vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-slp.cc:10189
0x55eb0872a10b vect_schedule_slp(vec_info*, vec<_slp_instance*, va_heap,
vl_ptr> const&)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-slp.cc:10353
0x55eb0888986c vect_transform_loop(_loop_vec_info*, gimple*)
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vect-loop.cc:12404
0x55eb08b21ffd vect_transform_loops
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vectorizer.cc:1007
0x55eb08a8c26a try_vectorize_loop_1
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vectorizer.cc:1153
0x55eb08a8c26a try_vectorize_loop
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vectorizer.cc:1183
0x55eb087b7625 execute
       
/usr/src/debug/sys-devel/gcc-15.0.9999/gcc-15.0.9999/gcc/tree-vectorizer.cc:1299
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/15/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-15.0.9999/work/gcc-15.0.9999/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/15
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/15/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/15/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/15/python
--enable-objc-gc --enable-languages=c,c++,d,go,objc,obj-c++,fortran,ada,rust
--enable-obsolete --enable-secureplt --disable-werror --with-system-zlib
--enable-nls --without-included-gettext --disable-libunwind-exceptions
--enable-checking=yes,extra,rtl --with-bugurl=https://bugs.gentoo.org/
--with-pkgversion='Gentoo Hardened 15.0.9999 p, commit
743578d0de067c87f590c9886f14961bb429c1f4' --with-gcc-major-version-only
--enable-libstdcxx-time --enable-lto --disable-libstdcxx-pch --enable-shared
--enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu
--enable-multilib --with-multilib-list=m32,m64 --disable-fixed-point
--enable-targets=all --enable-libgomp --disable-libssp --enable-libada
--disable-cet --disable-systemtap --enable-valgrind-annotations
--disable-vtable-verify --disable-libvtv --with-zstd --with-isl
--disable-isl-version-check --enable-default-pie --enable-host-pie
--enable-host-bind-now --enable-default-ssp --disable-fixincludes
--with-build-config='bootstrap-O3 bootstrap-lto'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 15.0.0 20240812 (experimental)
7bf4cd48d4494ba65680578e9c7ae9a1b809aeaf (Gentoo Hardened 15.0.9999 p, commit
743578d0de067c87f590c9886f14961bb429c1f4)
```

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.0
           Keywords|                            |ice-on-valid-code

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Reduced:
```
int *a;
int b;
long c, d;
void(e)(int f) {
  for (; f; f++) {
    d += (long)a[f] * b;
    c += (long)a[f] * 3;
  }
}
```

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=116142

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #1)
> Reduced:
> ```
> int *a;
> int b;
> long c, d;
> void(e)(int f) {
>   for (; f; f++) {
>     d += (long)a[f] * b;
>     c += (long)a[f] * 3;
>   }
> }
> ```

This makes it more likely it is the same as PR 116314 even. This is a widending
dot product summation going on.

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xry111 at gcc dot gnu.org

--- Comment #3 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
*** Bug 116314 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-08-13
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #4 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
Confirmed.  Reverting r15-2791 fixes the ICE (the test case is compiled but
then suffers the missed optimization PR116142).

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
supportable_widening_operation fails at transform time - that's likely because
vectorizable_reduction "puns" defs to internal_def so the check should
probably instead look like

diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 3b22f4e4a73..485463b5f14 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -14195,8 +14195,7 @@ supportable_widening_operation (vec_info *vinfo,
              by STMT is only directly used in the reduction statement.  */
          tree lhs = gimple_assign_lhs (vect_orig_stmt (stmt_info)->stmt);
          stmt_vec_info use_stmt_info = loop_info->lookup_single_use (lhs);
-         if (use_stmt_info
-             && STMT_VINFO_DEF_TYPE (use_stmt_info) == vect_reduction_def)
+         if (use_stmt_info && STMT_VINFO_REDUC_DEF (use_stmt_info))
            return true;
         }
       c1 = VEC_WIDEN_MULT_LO_EXPR;

that fixes the reduced testcase on x86_64, using widen_{odd,even} mults.

Xi Ruoyao - can you pick up from here?

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #6 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
The proposed change triggers a test suite regression on x86_64:

WARNING: gfortran.dg/sizeof_6.f90   -O1  execution test program timed out.
FAIL: gfortran.dg/sizeof_6.f90   -O1  execution test

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #7 from Sam James <sjames at gcc dot gnu.org> ---
That test has been ping-ponging for me for a while. I suspect it's not related.

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #8 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to Sam James from comment #7)
> That test has been ping-ponging for me for a while. I suspect it's not
> related.

Indeed, this test seems flaky.  I ran the test manually several times and
sometimes it looped infinitely, but sometimes not.

Is there an existing PR for it?

I'll test the change with my LoongArch change too but it'll take some time.

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #9 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to Xi Ruoyao from comment #8)
> (In reply to Sam James from comment #7)
> > That test has been ping-ponging for me for a while. I suspect it's not
> > related.
> 
> Indeed, this test seems flaky.  I ran the test manually several times and
> sometimes it looped infinitely, but sometimes not.
> 
> Is there an existing PR for it?

Found it: PR116261.

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #10 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
I've tested the change and it fixes PR116314 case as well.

Richard: do you want me to send your change as a patch like before (the
PR116142 fix)?

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #11 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 22 Aug 2024, xry111 at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348
> 
> --- Comment #10 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
> I've tested the change and it fixes PR116314 case as well.
> 
> Richard: do you want me to send your change as a patch like before (the
> PR116142 fix)?

Yes pleae.

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:d3e71b99194bff878d3bf3b35f9528a350d10df9

commit r15-3189-gd3e71b99194bff878d3bf3b35f9528a350d10df9
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Thu Aug 22 21:18:29 2024 +0800

    vect: Fix STMT_VINFO_DEF_TYPE check for odd/even widen mult [PR116348]

    After fixing PR116142 some code started to trigger an ICE with -O3
    -march=znver4.  Per Richard Biener who actually made this fix:

    "supportable_widening_operation fails at transform time - that's likely
    because vectorizable_reduction "puns" defs to internal_def"

    so the check should use STMT_VINFO_REDUC_DEF instead of checking if
    STMT_VINFO_DEF_TYPE is vect_reduction_def.

    gcc/ChangeLog:

            PR tree-optimization/116348
            * tree-vect-stmts.cc (supportable_widening_operation): Use
            STMT_VINFO_REDUC_DEF (x) instead of
            STMT_VINFO_DEF_TYPE (x) == vect_reduction_def.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/116348
            * gcc.c-torture/compile/pr116438.c: New test.

    Co-authored-by: Richard Biener <rguenther@suse.de>

[Bug tree-optimization/116348] [15 regression] ICE when building gavl-1.4.0 with -O3 -march=znver4 since r15-2791-g2083389a18d366

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116348

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
Fixed.