* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
@ 2024-09-06 7:29 ` ktkachov at gcc dot gnu.org
2024-09-06 7:41 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2024-09-06 7:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
ktkachov at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |14.2.0
Known to fail| |15.0
Target Milestone|--- |15.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
2024-09-06 7:29 ` [Bug tree-optimization/116628] " ktkachov at gcc dot gnu.org
@ 2024-09-06 7:41 ` pinskia at gcc dot gnu.org
2024-09-06 7:42 ` ktkachov at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-09-06 7:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
What revision/commit id are you using? Is it before or after r15-3411 ?
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
2024-09-06 7:29 ` [Bug tree-optimization/116628] " ktkachov at gcc dot gnu.org
2024-09-06 7:41 ` pinskia at gcc dot gnu.org
@ 2024-09-06 7:42 ` ktkachov at gcc dot gnu.org
2024-09-06 7:44 ` tnfchris at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2024-09-06 7:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #2 from ktkachov at gcc dot gnu.org ---
(In reply to Andrew Pinski from comment #1)
> What revision/commit id are you using? Is it before or after r15-3411 ?
It's a fairly fresh g:6a1a856ba78589f7f5285b00ecd40ba2bbeef8b0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (2 preceding siblings ...)
2024-09-06 7:42 ` ktkachov at gcc dot gnu.org
@ 2024-09-06 7:44 ` tnfchris at gcc dot gnu.org
2024-09-06 9:04 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-09-06 7:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Still seems to ICE after that commit on last night's trunk
https://godbolt.org/z/GnYT7Kx46
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (3 preceding siblings ...)
2024-09-06 7:44 ` tnfchris at gcc dot gnu.org
@ 2024-09-06 9:04 ` rguenth at gcc dot gnu.org
2024-09-06 9:07 ` tnfchris at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-09-06 9:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-09-06
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed. The ICE means we've "fatally" failed to analyze an epilogue which
we do not expect.
t.c:4:21: note: worklist: examine stmt: .MASK_STORE (&a[e_10], 8B, _9 != 0,
_1);
t.c:4:21: note: vect_is_simple_use: operand _9 != 0, type of def: unknown
t.c:4:21: missed: Unsupported pattern.
possibly the embedded _9 != 0 is the problem?
t.c:4:21: note: vect_recog_bool_pattern: detected: _ifc__24 = _9 ? _1 :
_ifc__22;
t.c:4:21: note: bool pattern recognized: patt_8 = _9 != 0 ? _1 : _ifc__22;
t.c:4:21: note: vect_recog_cond_store_pattern: detected: a[e_10] = _ifc__24;
t.c:4:21: note: cond_store pattern recognized: .MASK_STORE (&a[e_10], 8B, _9
!= 0, _1);
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (4 preceding siblings ...)
2024-09-06 9:04 ` rguenth at gcc dot gnu.org
@ 2024-09-06 9:07 ` tnfchris at gcc dot gnu.org
2024-09-06 9:33 ` tnfchris at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-09-06 9:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #5 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #4)
> Confirmed. The ICE means we've "fatally" failed to analyze an epilogue
> which we do not expect.
>
> t.c:4:21: note: worklist: examine stmt: .MASK_STORE (&a[e_10], 8B, _9 !=
> 0, _1);
> t.c:4:21: note: vect_is_simple_use: operand _9 != 0, type of def: unknown
> t.c:4:21: missed: Unsupported pattern.
>
> possibly the embedded _9 != 0 is the problem?
>
> t.c:4:21: note: vect_recog_bool_pattern: detected: _ifc__24 = _9 ? _1 :
> _ifc__22;
> t.c:4:21: note: bool pattern recognized: patt_8 = _9 != 0 ? _1 : _ifc__22;
> t.c:4:21: note: vect_recog_cond_store_pattern: detected: a[e_10] =
> _ifc__24;
> t.c:4:21: note: cond_store pattern recognized: .MASK_STORE (&a[e_10], 8B,
> _9 != 0, _1);
Hmmm if so https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662146.html
should fix it?
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (5 preceding siblings ...)
2024-09-06 9:07 ` tnfchris at gcc dot gnu.org
@ 2024-09-06 9:33 ` tnfchris at gcc dot gnu.org
2024-09-06 13:06 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-09-06 9:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |tnfchris at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #6 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
I'll take this one then.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (6 preceding siblings ...)
2024-09-06 9:33 ` tnfchris at gcc dot gnu.org
@ 2024-09-06 13:06 ` cvs-commit at gcc dot gnu.org
2024-09-06 13:09 ` tnfchris at gcc dot gnu.org
2024-09-20 16:02 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-09-06 13:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:2c4438d39156493b5b382eb48b1f884ca5ab7ed4
commit r15-3518-g2c4438d39156493b5b382eb48b1f884ca5ab7ed4
Author: Tamar Christina <tamar.christina@arm.com>
Date: Fri Sep 6 14:05:43 2024 +0100
middle-end: check that the lhs of a COND_EXPR is an SSA_NAME in cond_store
recognition [PR116628]
Because the vect_recog_bool_pattern can at the moment still transition
out of GIMPLE and back into GENERIC the vect_recog_cond_store_pattern can
end up using an expression as a mask rather than an SSA_NAME.
This adds an explicit check that we have a mask and not an expression.
gcc/ChangeLog:
PR tree-optimization/116628
* tree-vect-patterns.cc (vect_recog_cond_store_pattern): Add
SSA_NAME
check on expression.
gcc/testsuite/ChangeLog:
PR tree-optimization/116628
* gcc.dg/vect/pr116628.c: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (7 preceding siblings ...)
2024-09-06 13:06 ` cvs-commit at gcc dot gnu.org
@ 2024-09-06 13:09 ` tnfchris at gcc dot gnu.org
2024-09-20 16:02 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-09-06 13:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed, thanks for the report!
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/116628] [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC
2024-09-06 7:27 [Bug tree-optimization/116628] New: [15 Regression] ICE in vect_analyze_loop_1 on aarch64 with -Ofast in TSVC ktkachov at gcc dot gnu.org
` (8 preceding siblings ...)
2024-09-06 13:09 ` tnfchris at gcc dot gnu.org
@ 2024-09-20 16:02 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-09-20 16:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116628
--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:0189ab205aa86b8e67ae982294f0fe58aa9c4774
commit r15-3738-g0189ab205aa86b8e67ae982294f0fe58aa9c4774
Author: Tamar Christina <tamar.christina@arm.com>
Date: Fri Sep 20 17:01:39 2024 +0100
testsuite: Update commandline for PR116628.c to use neoverse-v2 [PR116628]
The testcase for this tests needs Neoverse V2 to be used
since due to costing the other cost models don't pick this
particular SVE mode.
committed as obvious.
Thanks,
Tamar
gcc/testsuite/ChangeLog:
PR tree-optimization/116628
* gcc.dg/vect/pr116628.c: Update cmdline.
^ permalink raw reply [flat|nested] 11+ messages in thread