public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/13421] IA32 bigmem pointer subtraction and –ftrapv option causes unjustified program abort Date: Tue, 30 Apr 2024 11:05:18 +0000 [thread overview] Message-ID: <bug-13421-4-gh8KONwzcv@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-13421-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=13421 --- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:667c19de86b33648f5f4599f589a5e02adbb35cb commit r15-67-g667c19de86b33648f5f4599f589a5e02adbb35cb Author: Richard Biener <rguenther@suse.de> Date: Tue Apr 16 14:05:35 2024 +0200 middle-end/13421 - -ftrapv vs. POINTER_DIFF_EXPR Currently we expand POINTER_DIFF_EXPR using subv_optab when -ftrapv (but -fsanitize=undefined does nothing). That's not consistent with the behavior of POINTER_PLUS_EXPR which never uses addv_optab with -ftrapv. Both are because of the way we select whether to use the trapping or the non-trapping optab - we look at the result type of the expression and check trapv = INTEGRAL_TYPE_P (type) && TYPE_OVERFLOW_TRAPS (type); the bugreport correctly complains that -ftrapv affects pointer subtraction (there's no -ftrapv-pointer). Now that we have POINTER_DIFF_EXPR we can honor that appropriately. The patch moves both POINTER_DIFF_EXPR and POINTER_PLUS_EXPR handling so they will never consider trapping (or saturating) optabs. PR middle-end/13421 * optabs-tree.cc (optab_for_tree_code): Do not consider {add,sub}v or {us,ss}{add,sub} optabs for POINTER_DIFF_EXPR or POINTER_PLUS_EXPR.
next prev parent reply other threads:[~2024-04-30 11:05 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-13421-4@http.gcc.gnu.org/bugzilla/> 2021-12-29 6:12 ` pinskia at gcc dot gnu.org 2023-06-25 2:01 ` pinskia at gcc dot gnu.org 2024-04-30 11:05 ` cvs-commit at gcc dot gnu.org [this message] 2024-05-02 6:33 ` rguenth at gcc dot gnu.org 2003-12-17 16:33 [Bug c/13421] New: IA32 bigmem pointer subtraction and ftrapv " vik dot heyndrickx at pandora dot be 2004-04-06 5:13 ` [Bug middle-end/13421] " eggert at twinsun dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-13421-4-gh8KONwzcv@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).