[Bug libstdc++/13631] Problems in messages

["fdumont at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4918 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=13631

--- Comment #33 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Wed Dec  3 19:47:00 2014
New Revision: 218329

URL: https://gcc.gnu.org/viewcvs?rev=218329&root=gcc&view=rev
Log:
2014-12-03  François Dumont  <fdumont@gcc.gnu.org>

    PR libstdc++/13631
    * include/bits/codecvt.h (codecvt<char, char, mbstate_t>): friend class
    std::messages<char>.
    (codecvt<wchar_t, char, mbstate_t>): friend class
    std::messages<wchar_t>.
    * config/locale/gnu/messages_member.h
    (messages<char>::do_open): Specialized.
    (messages<char>::do_close): Likewise.
    (messages<wchar_t>::do_open): Likewise.
    (messages<wchar_t>::do_close): Likewise.
    * config/locale/gnu/messages_member.cc:
    (messages<char>::do_open): Implement. Use bind_textdomain_codeset based
    on codecvt<char, char, mbstate_t>._M_c_locale_codecvt code set. Use
    internal cache to keep opened domain name with locale information.
    (messages<wchar_t>::do_open): Likewise with
    codecvt<wchar_t, char, mbstate_t>.
    (messages<char>::do_close): Implement. Clean cache information.
    (messages<wchar_t>::do_close): Likewise.
    (get_glibc_msg): New. Use dgettext rather than gettext using cached
    domain name associated to catalog id.
    (messages<char>::do_get): Use latter.
    (messages<wchar_t>::do_get): Likewise and use also cached locale
    codecvt<wchar_t, char, mbstate_t> facet to convert wchar_t default
    value to char and the result back to wchar_t.
    * testsuite/22_locale/messages/13631.cc: New.
    * testsuite/22_locale/messages/members/char/2.cc: Use also fr_FR locale
    for charset conversion to get the expected accented character.

Added:
    trunk/libstdc++-v3/testsuite/22_locale/messages/13631.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/config/locale/gnu/messages_members.cc
    trunk/libstdc++-v3/config/locale/gnu/messages_members.h
    trunk/libstdc++-v3/include/bits/codecvt.h
    trunk/libstdc++-v3/testsuite/22_locale/messages/members/char/2.cc
>From gcc-bugs-return-469402-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 03 19:53:29 2014
Return-Path: <gcc-bugs-return-469402-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12146 invoked by alias); 3 Dec 2014 19:53:29 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12078 invoked by uid 48); 3 Dec 2014 19:53:25 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/64170] [5 Regression] ICE compiling Linux Kernel drivers/media/rc/imon.c in imon_incoming_packet
Date: Wed, 03 Dec 2014 19:53:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status assigned_to attachments.created
Message-ID: <bug-64170-4-aJMcmelt2O@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64170-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64170-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg00409.txt.bz2
Content-length: 927

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd170

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 34182
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id4182&actioníit
gcc5-pr64170.patch

Untested fix.  The bug was that maybe_get_dominating_check wasn't called on
*base_checks if it returned non-NULL on *ptr_checks.  But that function has two
purposes, one is to clean up the vector, so that it doesn't contain any stale
stmts (and this is what can_remove_asan_check relies on), the other is to
return the last element in the vector if there are still any.