From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4ABFD3838030; Tue, 10 May 2022 05:15:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4ABFD3838030 From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug pch/14940] PCH largefile test fails on various platforms Date: Tue, 10 May 2022 05:15:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: pch X-Bugzilla-Version: 4.0.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 05:15:10 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D14940 --- Comment #56 from Andrew Pinski --- (In reply to LIU Hao from comment #55) > (In reply to Andrew Pinski from comment #54) > > (In reply to LIU Hao from comment #53) > > > The patch no longer applies to GCC 12. > >=20 > > Right because I think this issue has been fixed by r12-5855-g747380f47d= a0da . >=20 > No, at least not completely. In 'gcc/config/i386/host-mingw32.cc' there is > still the 128MiB hard limit: >=20 > ``` > /* FIXME: Is this big enough? */ > static const size_t pch_VA_max_size =3D 128 * 1024 * 1024; > ``` Right, some hosts need to be changed. Looks like only darwin and linux was fixed. See r12-5857-g0d5db1dd65b452 for the change done for darwin. Maybe a similar change is needed for Mingw.=