public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/16186] gcc should have an option to warn about enumerations with duplicate values
Date: Mon, 13 Mar 2023 13:44:53 +0000	[thread overview]
Message-ID: <bug-16186-4-fJq6In7SWg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-16186-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16186

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to trashyankes from comment #7)
> Should be way to disable/enable this warning per `enum`?
> Like:
> 
> ```
> enum [[gnu::enum_unique]] X
> {
>   I = 1,
>   J = 2,
> };
> 
> enum [[gnu::enum_not_unique]] Y
> {
>   K = 1,
>   L = 1,
> };
> 
> ```

No, it should warn solely if enumerator gets implicitly assigned value of some
other enumerator.  After all, the clang wording also mentions that:
element 'D' has been implicitly assigned 5 which another element has been
assigned [-Wduplicate-enum]
If there is = value for it, we should never warn, that is most likely
completely intentional.
Of course, we should use better wording, because we should talk about
enumerators, not elements...

  parent reply	other threads:[~2023-03-13 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-16186-4@http.gcc.gnu.org/bugzilla/>
2022-10-24 15:25 ` pinskia at gcc dot gnu.org
2022-10-24 18:37 ` mpolacek at gcc dot gnu.org
2022-10-24 18:43 ` marxin at gcc dot gnu.org
2022-10-24 18:48 ` mpolacek at gcc dot gnu.org
2022-10-24 19:18 ` marxin at gcc dot gnu.org
2023-03-10 20:12 ` trashyankes at wp dot pl
2023-03-13 13:44 ` jakub at gcc dot gnu.org [this message]
2004-06-24 23:09 [Bug c/16186] New: " austern at apple dot com
2004-06-29  2:56 ` [Bug c/16186] " pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16186-4-fJq6In7SWg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).