public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/17234] if-conversion problem
       [not found] <bug-17234-4@http.gcc.gnu.org/bugzilla/>
@ 2021-06-08  9:04 ` pinskia at gcc dot gnu.org
  0 siblings, 0 replies; 2+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-06-08  9:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17234

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I can no longer reproduce this issue with a more recent compiler.  Also The
order of the basic block changed.
So we have now:
entry
je L3
calls
L3:
ret

Most likely due to the heurstics changes.
Anyways I force the other order using __builtin_expect and I get:
bar:
        pushl   %esi
        xorl    %eax, %eax
        pushl   %ebx
        subl    $20, %esp
        movl    32(%esp), %esi
        movl    4(%esi), %ebx
        testl   %ebx, %ebx
        jne     .L8
        addl    $20, %esp
        popl    %ebx
        popl    %esi
        ret
        .p2align 4,,10
        .p2align 3
.L8:
        subl    $12, %esp
        sall    $2, %ebx
        pushl   $132
        call    baz
        addl    $12, %esp
        pushl   %ebx
        pushl   (%esi)
        pushl   %eax
        movl    %eax, 28(%esp)
        call    foo
        addl    $16, %esp
        movl    12(%esp), %eax
        addl    $20, %esp
        popl    %ebx
        popl    %esi
        ret

---- CUT ---
We duplicate the ret here even.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug rtl-optimization/17234] if-conversion problem
       [not found] <bug-17234-1008@http.gcc.gnu.org/bugzilla/>
@ 2007-07-25 19:43 ` steven at gcc dot gnu dot org
  0 siblings, 0 replies; 2+ messages in thread
From: steven at gcc dot gnu dot org @ 2007-07-25 19:43 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from steven at gcc dot gnu dot org  2007-07-25 19:43 -------
This may actually have been fixed by my cfglayout work.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17234


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-08  9:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-17234-4@http.gcc.gnu.org/bugzilla/>
2021-06-08  9:04 ` [Bug rtl-optimization/17234] if-conversion problem pinskia at gcc dot gnu.org
     [not found] <bug-17234-1008@http.gcc.gnu.org/bugzilla/>
2007-07-25 19:43 ` steven at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).