[Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
       [not found] <bug-17632-4@http.gcc.gnu.org/bugzilla/>
@ 2022-05-12 18:28 ` cvs-commit at gcc dot gnu.org
  0 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-12 18:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:a0080f0285dfa9b7f0b7a6c5ec79e28eb662b953

commit r13-375-ga0080f0285dfa9b7f0b7a6c5ec79e28eb662b953
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 12 17:37:33 2022 +0100

    libstdc++: Remove whitespace before preprocessor directives

    These are harmless, but also unnecessary and inconsistent (and their
    removal was requested by PR libstdc++/17632).

    libstdc++-v3/ChangeLog:

            * config/locale/dragonfly/numeric_members.cc: Remove whitespace.
            * config/locale/gnu/numeric_members.cc: Likewise.
            * include/bits/locale_facets_nonio.h: Likewise.
            * libsupc++/typeinfo: Likewise.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] New: Non-portable whitespace in libstdc++ headers
@ 2004-09-23 12:00 gcc-bugzilla at gcc dot gnu dot org
  2004-09-23 12:07 ` [Bug libstdc++/17632] " pcarlini at suse dot de
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: gcc-bugzilla at gcc dot gnu dot org @ 2004-09-23 12:00 UTC (permalink / raw)
  To: gcc-bugs


 	non-portable whitespace (lines starting with "  #" instead of "#  ").
 	Of course this is accepted by the gcc preprocessor (as a GNU extension),
 	but other programs (e.g. X11's mkdepend) complain and thus produce
 	unnecessary noise.

 	Since it is really easy to repair that, please do so.

Environment:
System: Linux pcl321 2.4.25 #2 SMP Thu Apr 1 13:55:52 CEST 2004 i686 unknown unknown GNU/Linux
Architecture: i686


host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc-3.4.2/configure --host=ix86-linux-gnulibc2 --prefix=/usr --disable-nls --enable-shared --enable-languages=c++,f77,objc --enable-version-specific-runtime-libs --with-gxx-include-dir=/include/c++/3.4.2 --bindir=/ix86-linux-gnulibc2/bin

How-To-Repeat:
 	E.g. run mkdepend with one of the headers included.
------- Additional Comments From peb at mppmu dot mpg dot de  2004-09-23 12:00 -------
Fix:
 	Apply the attached patch.


regards
Peter Breitenlohner <peb@mppmu.mpg.de>

-- 
           Summary: Non-portable whitespace in libstdc++ headers
           Product: gcc
           Version: 3.4.2
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: peb at mppmu dot mpg dot de
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
@ 2004-09-23 12:07 ` pcarlini at suse dot de
  2004-09-23 12:34 ` pinskia at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pcarlini at suse dot de @ 2004-09-23 12:07 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pcarlini at suse dot de  2004-09-23 12:07 -------
Can you actually provide the patch? Anyway, I see something only in
config/io/basic_file_stdio.cc. Thanks.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
  2004-09-23 12:07 ` [Bug libstdc++/17632] " pcarlini at suse dot de
@ 2004-09-23 12:34 ` pinskia at gcc dot gnu dot org
  2004-09-23 13:45 ` bangerth at dealii dot org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-23 12:34 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-23 12:34 -------
Actually it is not a GCC extension, it is allowed by the ISO/ANSI C/C++ standard, it is only pre standard 
that it was not allowed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
  2004-09-23 12:07 ` [Bug libstdc++/17632] " pcarlini at suse dot de
  2004-09-23 12:34 ` pinskia at gcc dot gnu dot org
@ 2004-09-23 13:45 ` bangerth at dealii dot org
  2004-09-23 14:20 ` reichelt at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: bangerth at dealii dot org @ 2004-09-23 13:45 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From bangerth at dealii dot org  2004-09-23 13:45 -------
The fact that the standard may even allow it doesn't mean we shouldn't 
fix unnecessary problems to tools that don't expect it. So I reopen this 
PR. 
 
W. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-09-23 13:45 ` bangerth at dealii dot org
@ 2004-09-23 14:20 ` reichelt at gcc dot gnu dot org
  2004-09-23 14:29 ` steven at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-09-23 14:20 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-09-23 14:20 ` reichelt at gcc dot gnu dot org
@ 2004-09-23 14:29 ` steven at gcc dot gnu dot org
  2004-09-23 15:00 ` reichelt at gcc dot gnu dot org
  2004-09-23 16:36 ` pcarlini at suse dot de
  6 siblings, 0 replies; 8+ messages in thread
From: steven at gcc dot gnu dot org @ 2004-09-23 14:29 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From steven at gcc dot gnu dot org  2004-09-23 14:29 -------
Should we not instead ask people to fix their tools to be standard
compliant, and close this bug as INVALID?  I would consider this a
bug in whatever tool crashes on this, not one in libstdc++.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2004-09-23 14:29 ` steven at gcc dot gnu dot org
@ 2004-09-23 15:00 ` reichelt at gcc dot gnu dot org
  2004-09-23 16:36 ` pcarlini at suse dot de
  6 siblings, 0 replies; 8+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-09-23 15:00 UTC (permalink / raw)
  To: gcc-bugs

------- Additional Comments From reichelt at gcc dot gnu dot org  2004-09-23 15:00 -------
> Should we not instead ask people to fix their tools to be standard
> compliant, and close this bug as INVALID?  I would consider this a
> bug in whatever tool crashes on this, not one in libstdc++.

Nitpick: It wasn't submitted as a bug, but as an enhancement request.

Even it's a bug in other tools, it would not be a big problem on GCC's
side to make it work. (We are just talking about some whitespace here).
That does not keep us from asking people to fix their tools.

In addition, applying the patch would unify our coding style since we
already have the form "#  include" in our libstdc++ sources.

Therefore, I'd be in favor for applying the patch.

-- 

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers
  2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2004-09-23 15:00 ` reichelt at gcc dot gnu dot org
@ 2004-09-23 16:36 ` pcarlini at suse dot de
  6 siblings, 0 replies; 8+ messages in thread
From: pcarlini at suse dot de @ 2004-09-23 16:36 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pcarlini at suse dot de  2004-09-23 16:36 -------
Frankly, everything considered, I agree with Steven and Andrew.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17632


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-05-12 18:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-17632-4@http.gcc.gnu.org/bugzilla/>
2022-05-12 18:28 ` [Bug libstdc++/17632] Non-portable whitespace in libstdc++ headers cvs-commit at gcc dot gnu.org
2004-09-23 12:00 [Bug libstdc++/17632] New: " gcc-bugzilla at gcc dot gnu dot org
2004-09-23 12:07 ` [Bug libstdc++/17632] " pcarlini at suse dot de
2004-09-23 12:34 ` pinskia at gcc dot gnu dot org
2004-09-23 13:45 ` bangerth at dealii dot org
2004-09-23 14:20 ` reichelt at gcc dot gnu dot org
2004-09-23 14:29 ` steven at gcc dot gnu dot org
2004-09-23 15:00 ` reichelt at gcc dot gnu dot org
2004-09-23 16:36 ` pcarlini at suse dot de

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).