public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) [not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/> @ 2014-03-20 8:24 ` mpolacek at gcc dot gnu.org 2014-03-20 9:06 ` jakub at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: mpolacek at gcc dot gnu.org @ 2014-03-20 8:24 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mpolacek at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org --- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> --- I have patch, but I used a warning, not an error. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) [not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/> 2014-03-20 8:24 ` [Bug c/18079] Contradicting function attributes (always_inline vs noinline) mpolacek at gcc dot gnu.org @ 2014-03-20 9:06 ` jakub at gcc dot gnu.org 2014-03-20 15:51 ` mpolacek at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2014-03-20 9:06 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- I agree we should warn, not error out. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) [not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/> 2014-03-20 8:24 ` [Bug c/18079] Contradicting function attributes (always_inline vs noinline) mpolacek at gcc dot gnu.org 2014-03-20 9:06 ` jakub at gcc dot gnu.org @ 2014-03-20 15:51 ` mpolacek at gcc dot gnu.org 2014-04-25 11:05 ` mpolacek at gcc dot gnu.org 2014-04-25 11:06 ` mpolacek at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: mpolacek at gcc dot gnu.org @ 2014-03-20 15:51 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 --- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Patch queued for 5.0. http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01068.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) [not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/> ` (2 preceding siblings ...) 2014-03-20 15:51 ` mpolacek at gcc dot gnu.org @ 2014-04-25 11:05 ` mpolacek at gcc dot gnu.org 2014-04-25 11:06 ` mpolacek at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: mpolacek at gcc dot gnu.org @ 2014-04-25 11:05 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 --- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Author: mpolacek Date: Fri Apr 25 11:04:40 2014 New Revision: 209796 URL: http://gcc.gnu.org/viewcvs?rev=209796&root=gcc&view=rev Log: PR c/18079 c/ * c-decl.c (diagnose_mismatched_decls): Warn for mismatched always_inline/noinline and hot/cold attributes. c-family/ * c-common.c (handle_noinline_attribute): Warn if the attribute conflicts with always_inline attribute. (handle_always_inline_attribute): Warn if the attribute conflicts with noinline attribute. testsuite/ * gcc.dg/pr18079.c: New test. * gcc.dg/pr18079-2.c: New test. Added: trunk/gcc/testsuite/gcc.dg/pr18079-2.c trunk/gcc/testsuite/gcc.dg/pr18079.c Modified: trunk/gcc/c-family/ChangeLog trunk/gcc/c-family/c-common.c trunk/gcc/c/ChangeLog trunk/gcc/c/c-decl.c trunk/gcc/testsuite/ChangeLog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) [not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/> ` (3 preceding siblings ...) 2014-04-25 11:05 ` mpolacek at gcc dot gnu.org @ 2014-04-25 11:06 ` mpolacek at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: mpolacek at gcc dot gnu.org @ 2014-04-25 11:06 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|accepts-invalid |diagnostic Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Target Milestone|--- |4.10.0 --- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/18079] New: Contradicting function attributes (always_inline vs noinline)
@ 2004-10-20 13:55 pinskia at gcc dot gnu dot org
2004-10-20 14:12 ` [Bug c/18079] " pinskia at gcc dot gnu dot org
0 siblings, 1 reply; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-20 13:55 UTC (permalink / raw)
To: gcc-bugs
/* contradicting - should be an error */
static
__attribute__((noinline))
__attribute__((always_inline))
int test_inline_03(int r) { return r & 4; }
/* contradicting - should be an error */
static
__attribute__((always_inline))
__attribute__((noinline))
int test_inline_04(int r) { return r & 8; }
--
Summary: Contradicting function attributes (always_inline vs
noinline)
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Keywords: accepts-invalid
Severity: normal
Priority: P2
Component: c
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: pinskia at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug c/18079] Contradicting function attributes (always_inline vs noinline) 2004-10-20 13:55 [Bug c/18079] New: " pinskia at gcc dot gnu dot org @ 2004-10-20 14:12 ` pinskia at gcc dot gnu dot org 0 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu dot org @ 2004-10-20 14:12 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-20 14:12 ------- Confirmed, this was break up of bug 18070. -- What |Removed |Added ---------------------------------------------------------------------------- CC| |markus at oberhumer dot com Status|UNCONFIRMED |NEW Ever Confirmed| |1 Last reconfirmed|0000-00-00 00:00:00 |2004-10-20 14:12:50 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18079 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-25 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-18079-4@http.gcc.gnu.org/bugzilla/>
2014-03-20 8:24 ` [Bug c/18079] Contradicting function attributes (always_inline vs noinline) mpolacek at gcc dot gnu.org
2014-03-20 9:06 ` jakub at gcc dot gnu.org
2014-03-20 15:51 ` mpolacek at gcc dot gnu.org
2014-04-25 11:05 ` mpolacek at gcc dot gnu.org
2014-04-25 11:06 ` mpolacek at gcc dot gnu.org
2004-10-20 13:55 [Bug c/18079] New: " pinskia at gcc dot gnu dot org
2004-10-20 14:12 ` [Bug c/18079] " pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).