From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-437933-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 26296 invoked by alias); 17 Dec 2013 23:26:41 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 26244 invoked by uid 55); 17 Dec 2013 23:26:37 -0000
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/18469] configure incorrectly defines gid_t
Date: Tue, 17 Dec 2013 23:26:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.0.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: joseph at codesourcery dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-18469-4-1uZxIH4JXK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-18469-4@http.gcc.gnu.org/bugzilla/>
References: <bug-18469-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01588.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18469

--- Comment #4 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Mon, 16 Dec 2013, ktietz at gcc dot gnu.org wrote:

> The macros required in crtstuff.c are:
> - HAVE_GAS_HIDDEN
> - HAVE_LD_EH_FRAME_HDR

Various target macros used in target code as well as host code should, I 
suggest at <http://gcc.gnu.org/wiki/Top-Level_Libgcc_Migration>, be 
handled via the compiler predefining macros if -fbuilding-libgcc, with 
those predefines being used in target code instead of the macros from host 
tm.h.  (The exact list of host-side tm.h macros used in target code there 
may be out of date, but I expect it's still pretty close to what needs 
fixing to stop target code needing that host-side header.)

I suggest the same solution for configure-determined macros used by target 
code: predefine something if -fbuilding-libgcc, and use that predefine in 
target code.  That avoids duplicating the configure detection.

I definitely encourage cleaning things up in this area to improve the 
host/target separation in the build system.  I don't think any of the 
cases of target (or configure) macros used in target code are hard to fix; 
it just requires careful work on working out the right conversion for each 
of the many macros affected, making sure in every case that no files 
needing updating are missed out.