* [Bug c++/19351] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
@ 2011-01-22 21:27 ` fw at gcc dot gnu.org
2011-05-24 13:00 ` redi at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: fw at gcc dot gnu.org @ 2011-01-22 21:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Florian Weimer <fw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fw at gcc dot gnu.org
--- Comment #22 from Florian Weimer <fw at gcc dot gnu.org> 2011-01-22 20:15:08 UTC ---
New patch posted: http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01593.html
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
2011-01-22 21:27 ` [Bug c++/19351] operator new[] can return heap blocks which are too small fw at gcc dot gnu.org
@ 2011-05-24 13:00 ` redi at gcc dot gnu.org
2011-05-24 20:12 ` fw at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2011-05-24 13:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |redi at gcc dot gnu.org
--- Comment #23 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-05-24 12:31:34 UTC ---
Florian, your patch seems to have gone unreviewed, could you ping it?
GCC is getting (fairly) criticised on the LLVM blog about this ;)
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
2011-01-22 21:27 ` [Bug c++/19351] operator new[] can return heap blocks which are too small fw at gcc dot gnu.org
2011-05-24 13:00 ` redi at gcc dot gnu.org
@ 2011-05-24 20:12 ` fw at gcc dot gnu.org
2012-02-07 21:34 ` [Bug c++/19351] [DR 624] " redi at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: fw at gcc dot gnu.org @ 2011-05-24 20:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
--- Comment #24 from Florian Weimer <fw at gcc dot gnu.org> 2011-05-24 19:54:47 UTC ---
(In reply to comment #23)
> Florian, your patch seems to have gone unreviewed, could you ping it?
Jason reviewed it and Ian, too (off-list). I haven't yet gotten around to
incorporating their feedback. I'm also not sure if I'm qualified to tackle the
optimization requests.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2011-05-24 20:12 ` fw at gcc dot gnu.org
@ 2012-02-07 21:34 ` redi at gcc dot gnu.org
2012-07-17 9:08 ` fweimer at redhat dot com
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2012-02-07 21:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|operator new[] can return |[DR 624] operator new[] can
|heap blocks which are too |return heap blocks which
|small |are too small
Severity|enhancement |normal
--- Comment #25 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-07 21:33:00 UTC ---
since an exception is now required this is not an enhancement
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2012-02-07 21:34 ` [Bug c++/19351] [DR 624] " redi at gcc dot gnu.org
@ 2012-07-17 9:08 ` fweimer at redhat dot com
2012-08-20 21:16 ` fw at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: fweimer at redhat dot com @ 2012-07-17 9:08 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fweimer at redhat dot com
--- Comment #26 from Florian Weimer <fweimer at redhat dot com> 2012-07-17 09:05:22 UTC ---
Current proposed patch: http://gcc.gnu.org/ml/gcc-patches/2012-06/msg01689.html
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2012-07-17 9:08 ` fweimer at redhat dot com
@ 2012-08-20 21:16 ` fw at gcc dot gnu.org
2012-08-20 21:26 ` fw at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: fw at gcc dot gnu.org @ 2012-08-20 21:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
--- Comment #27 from Florian Weimer <fw at gcc dot gnu.org> 2012-08-20 21:13:29 UTC ---
Author: fw
Date: Mon Aug 20 21:13:23 2012
New Revision: 190546
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190546
Log:
Fix PR C++/19351: integer overflow in operator new[]
2012-08-20 Florian Weimer <fweimer@redhat.com>
PR c++/19351
* call.c (build_operator_new_call): Add size_check argument and
evaluate it.
* cp-tree.h (build_operator_new_call): Adjust declaration.
* init.c (build_new_1): Compute array size check and apply it.
2012-08-10 Florian Weimer <fweimer@redhat.com>
PR c++/19351
* g++.dg/init/new38.C: New test.
* g++.dg/init/new39.C: New test.
Added:
trunk/gcc/testsuite/g++.dg/init/new38.C
trunk/gcc/testsuite/g++.dg/init/new39.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cp/call.c
trunk/gcc/cp/cp-tree.h
trunk/gcc/cp/init.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2012-08-20 21:16 ` fw at gcc dot gnu.org
@ 2012-08-20 21:26 ` fw at gcc dot gnu.org
2012-10-01 8:12 ` jakub at gcc dot gnu.org
2014-02-16 10:01 ` jackie.rosen at hushmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: fw at gcc dot gnu.org @ 2012-08-20 21:26 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Florian Weimer <fw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
AssignedTo|unassigned at gcc dot |fweimer at redhat dot com
|gnu.org |
Target Milestone|--- |4.8.0
--- Comment #28 from Florian Weimer <fw at gcc dot gnu.org> 2012-08-20 21:23:09 UTC ---
This is the best we can do without an ABI change. (Expanding inline the code
to throw std::bad_array_new_length, as required by C++11, is a bit too messy.)
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2012-08-20 21:26 ` fw at gcc dot gnu.org
@ 2012-10-01 8:12 ` jakub at gcc dot gnu.org
2014-02-16 10:01 ` jackie.rosen at hushmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-10-01 8:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
--- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-01 08:12:07 UTC ---
Author: jakub
Date: Mon Oct 1 08:12:01 2012
New Revision: 191891
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191891
Log:
Move PR c++/19351 ChangeLog entry to correct ChangeLog.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cp/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small
[not found] <bug-19351-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2012-10-01 8:12 ` jakub at gcc dot gnu.org
@ 2014-02-16 10:01 ` jackie.rosen at hushmail dot com
8 siblings, 0 replies; 9+ messages in thread
From: jackie.rosen at hushmail dot com @ 2014-02-16 10:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351
Jackie Rosen <jackie.rosen at hushmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jackie.rosen at hushmail dot com
--- Comment #30 from Jackie Rosen <jackie.rosen at hushmail dot com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Marked for reference. Resolved as fixed @bugzilla.
^ permalink raw reply [flat|nested] 9+ messages in thread