public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/19832] don't remove an if when we know the value is the same as with the if (subtraction)
Date: Thu, 31 Aug 2023 01:03:16 +0000	[thread overview]
Message-ID: <bug-19832-4-wfj9jJPwrL@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-19832-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19832

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Xor should be handled too:
```
int f_xor(int i, int j)
{
  if (i!=j)
    return i ^ j;
  return 0;
}
``

ior and and should be handled
```
int f_or(int i, int j)
{
  if (i!=j)
    return i | j;
  return i; // could be j not just i
}

int f_and(int i, int j)
{
  if (i!=j)
    return i & j;
  return i; // could be j not just i
}
```

So can plus and multiply:
```
int f_add(int i, int j)
{
  if (i!=j)
    return i + j;
  return i+i;
}
int f_mult(int i, int j)
{
  if (i!=j)
    return i * j;
  return i*i;
}
```


Note clang handles all of these except for f_add. f_mult might be handled via
the pull `i*` out of the conditional and then you have `i!=j?j:i` which then
will be reduced to j (that is they don't pattern match f_mult). They don't have
pattern matching for f_add either and `i+i` will change to `i*2` and not pulled
out of the condition.

  parent reply	other threads:[~2023-08-31  1:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-19832-4@http.gcc.gnu.org/bugzilla/>
2011-08-13  1:39 ` jimis at gmx dot net
2011-08-13  2:21 ` jimis at gmx dot net
2012-08-06 11:41 ` rguenth at gcc dot gnu.org
2023-05-06 21:15 ` pinskia at gcc dot gnu.org
2023-05-06 23:12 ` pinskia at gcc dot gnu.org
2023-05-06 23:13 ` pinskia at gcc dot gnu.org
2023-08-31  1:03 ` pinskia at gcc dot gnu.org [this message]
2023-08-31  4:48 ` pinskia at gcc dot gnu.org
2023-08-31 18:03 ` pinskia at gcc dot gnu.org
2023-09-01  6:58 ` cvs-commit at gcc dot gnu.org
2023-09-01  6:58 ` pinskia at gcc dot gnu.org
2023-09-01 12:23 ` cvs-commit at gcc dot gnu.org
2023-12-25  4:02 ` cvs-commit at gcc dot gnu.org
2005-02-09  7:41 [Bug c/19832] New: Missed optimisation christophe dot jaillet at wanadoo dot fr
2005-02-09  7:46 ` [Bug tree-optimization/19832] don't remove an if when we know the value is the same as with the if (subtraction) pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-19832-4-wfj9jJPwrL@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).