[Bug c/21659] [4.3/4.4/4.5/4.6 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[Bug c/21659] [4.3/4.4/4.5/4.6 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21659

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |hubicka at gcc dot gnu.org
                   |gnu.org                     |
      Known to fail|                            |

--- Comment #10 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-22 16:04:49 UTC ---
I think with unit-at-a-time mode for all compilation settings, we should just
drop the restriction.  Will make patch.

[Bug c/21659] [4.3/4.4/4.5/4.6 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21659

--- Comment #11 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-24 23:07:29 UTC ---
Author: hubicka
Date: Mon Jan 24 23:07:25 2011
New Revision: 169184

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169184
Log:

    PR c/21659
    * doc/extend.texi (weak pragma): Drop claim that it must
    appear before definition.
    * varasm.c (merge_weak, declare_weak): Only sanity check
    that DECL is not output at a time it is declared weak.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/doc/extend.texi
    trunk/gcc/varasm.c

[Bug c/21659] [4.3/4.4/4.5 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21659

--- Comment #12 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-02-02 17:42:07 UTC ---
Author: dnovillo
Date: Wed Feb  2 17:42:05 2011
New Revision: 169542

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169542
Log:

    PR c/21659
    * doc/extend.texi (weak pragma): Drop claim that it must
    appear before definition.
    * varasm.c (merge_weak, declare_weak): Only sanity check
    that DECL is not output at a time it is declared weak.

Modified:
    branches/google/integration/gcc/ChangeLog
    branches/google/integration/gcc/doc/extend.texi
    branches/google/integration/gcc/varasm.c

[Bug c/21659] [4.3/4.4/4.5 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21659

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #13 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:12:34 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug c/21659] [4.4/4.5 Regression] [unit-at-a-time] "weak declaration must precede definition" error missing at >= O1

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21659

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-10-18 15:13:11 UTC ---
This restriction is long gone with unit-at-a-time changes.