public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/21769] per-file control over PCH inclusion
Date: Thu, 17 Aug 2023 07:45:06 +0000	[thread overview]
Message-ID: <bug-21769-4-QtJlTyWSO8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-21769-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21769

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:91315f23ba127ea4d1a584023bae34e143f6eb8c

commit r14-3276-g91315f23ba127ea4d1a584023bae34e143f6eb8c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Aug 16 21:46:05 2023 +0100

    libstdc++: Fix testsuite no_pch directive

    The { dg-add-options no_pch } directive is supposed to add a macro
    definition that invalidates the PCH file, and ensures that the #include
    directives in the test file are processed as written. But the proc that
    adds the options actually removes all existing options, cancelling out
    any previous dg-options directive.

    This means that using no_pch will cause FAILs in a file that relies on
    other options set by an earlier dg-options.

    The no_pch directive was added for PR libstdc++/21769 where Janis
    suggested adding it as return "$flags -D__GLIBCXX__=99999999" but what
    was actually committed didn't include the $flags so replaced them.

    Additionally, using no_pch  only prevents the precompiled version of
    <bits/stdc++.h> from being included, it doesn't prevent the
    non-precompiled version being included by -include bits/stdc++.h in the
    test flags. Use regsub to filter that out of the options as well.

    libstdc++-v3/ChangeLog:

            * testsuite/lib/dg-options.exp (add_options_for_no_pch): Remove
            any "-include bits/stdc++.h" from options and add the macro to
            the existing options instead of replacing them.

       reply	other threads:[~2023-08-17  7:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-21769-4@http.gcc.gnu.org/bugzilla/>
2023-08-17  7:45 ` cvs-commit at gcc dot gnu.org [this message]
2023-11-09  8:10 ` cvs-commit at gcc dot gnu.org
     [not found] <bug-21769-365@http.gcc.gnu.org/bugzilla/>
2009-07-27 23:52 ` janis at gcc dot gnu dot org
2010-01-20  1:36 ` paolo dot carlini at oracle dot com
2010-01-20 11:58 ` paolo at gcc dot gnu dot org
2010-01-20 12:04 ` paolo dot carlini at oracle dot com
2010-02-23  8:13 ` ghazi at gcc dot gnu dot org
2010-02-23  9:42 ` ghazi at gcc dot gnu dot org
2010-02-23 22:40 ` ghazi at gcc dot gnu dot org
2005-05-26 16:05 [Bug libstdc++/21769] New: " bkoz at gcc dot gnu dot org
2005-05-26 20:12 ` [Bug libstdc++/21769] " pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-21769-4-QtJlTyWSO8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).