[Bug tree-optimization/23455] tree load PRE is not working for global variables

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

Sebastian Pop <spop at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steinmtz at us dot ibm.com

--- Comment #18 from Sebastian Pop <spop at gcc dot gnu.org> ---
*** Bug 16797 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2008-07-08 20:27 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[dberlin at gcc dot gnu dot org]

------- Comment #16 from dberlin at gcc dot gnu dot org  2008-07-08 16:11 -------
Subject: Bug 23455

Author: dberlin
Date: Tue Jul  8 16:11:06 2008
New Revision: 137631

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137631
Log:
2008-07-05  Daniel Berlin  <dberlin@dberlin.org>

        Fix PR tree-optimization/23455
        Fix PR tree-optimization/35286
        Fix PR tree-optimization/35287
        * Makefile.in (OBJS-common): Remove tree-vn.o.
        tree-vn.o: Remove.
        * dbgcnt.def: Add treepre_insert debug counter.
        * gcc/tree-flow.h (add_to_value): Updated for other changes.
        (debug_value_expressions): Ditto.
        (print_value_expressions): Ditto.
        * tree-pretty-print.c (dump_generic_node): Updated for
        VALUE_HANDLE removal.
        * tree-ssa-dom.c (record_equality): Ditto.
        (cprop_operand): Ditto.
        (lookup_avail_expr): Ditto.
        * tree-ssa-threadedge.c
        (record_temporary_equivalences_from_stmts_at_dest): Ditto.
        (simplify_control_stmt_condition): Ditto.
        * tree.c (tree_code_size): Ditto.
        (tree_node_structure): Ditto.
        (iterative_hash_expr): Ditto.
        * tree.def: Ditto.
        * tree.h (VALUE_HANDLE_ID): Ditto.
        (VALUE_HANDLE_EXPR_SET): Ditto.
        (struct tree_value_handle): Ditto.
        (union tree_node): Ditto.
        * treestruct.def: Ditto.
        * tree-vn.c: Removed.
        * tree-ssa-pre.c: Rewritten entirely.
        * tree-ssa-sccvn.c (constant_to_value_id): New hashtable.
        (constant_value_ids): Ditto.
        (vn_nary_op_t): Moved to header.
        (vn_phi_t): Ditto.
        (vn_reference_op_t): Ditto
        (vn_reference_t): Ditto.
        (next_value_id): New variable.
        (VN_INFO): Add an assert.
        (vn_constant_eq): New function.
        (vn_constant_hash): Ditto.
        (get_or_alloc_constant_value_id): Ditto.
        (value_id_constant_p): Ditto.
        (vn_reference_compute_hash): De-staticify.
        (copy_reference_ops_from_ref): Don't use get_callee_fndecl.
        Disable some code with a FIXME.
        Remove VALUE_HANDLE use.
        (valueize_refs): Update opcode if it changes from ssa name to
        constant.
        (vn_reference_lookup_1): Add new argument.
        (vn_reference_lookup):  Ditto.
        (vn_reference_lookup_pieces): New function.
        (vn_reference_insert): Add return type. Modify to deal with value
        ids.
        (vn_reference_insert_pieces):  New function.
        (vn_nary_op_compute_hash): De-staticify.
        (vn_nary_op_eq): Ditto.
        (vn_nary_op_lookup_pieces): New function.
        (vn_nary_op_lookup): Add new argument.  
        (vn_nary_op_insert_pieces): New function.
        (vn_nary_op_insert): Add return type. Modify to deal with value
        ids.
        (vn_phi_insert): Ditto.
        (visit_unary_op): Update for callee changes.
        (visit_binary_op): Ditto.
        (visit_reference_op_load): Ditto.
        (visit_reference_op_store): Ditto.
        (init_scc_vn): Init next_value_id, constant_to_value_id and
        constant_value_ids. 
        (free_scc_vn): Free them.
        (set_hashtable_value_ids): New function.
        (run_scc_vn): Use it.
        (get_max_value_id): New function.
        (get_next_value_id): Ditto.
        (expressions_equal_p): Moved from tree-vn.c
        (sort_vuses): Ditto.
        (sort_vuses_heap): Ditto.
        * tree-ssa-sccvn.h: Structures moved from tree-ssa-sccvn.c (noted
        above).
        * tree.c (iterative_hash_hashval_t): Made non-static
        * tree.h (iterative_hash_hashval_t): Declare it.


Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/20080704-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr23455.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr35286.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr35287.c
Removed:
    trunk/gcc/tree-vn.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/dbgcnt.def
    trunk/gcc/testsuite/gcc.dg/tree-ssa/loadpre24.c
    trunk/gcc/tree-flow.h
    trunk/gcc/tree-pretty-print.c
    trunk/gcc/tree-ssa-dom.c
    trunk/gcc/tree-ssa-pre.c
    trunk/gcc/tree-ssa-sccvn.c
    trunk/gcc/tree-ssa-sccvn.h
    trunk/gcc/tree-ssa-threadedge.c
    trunk/gcc/tree.c
    trunk/gcc/tree.def
    trunk/gcc/tree.h
    trunk/gcc/treestruct.def


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[steven at gcc dot gnu dot org]

------- Comment #15 from steven at gcc dot gnu dot org  2008-07-06 08:53 -------
Patch here:
http://gcc.gnu.org/ml/gcc-patches/2008-07/msg00430.html

We should re-evaluate the need for gcse.c load-PRE after Daniel's patch goes
in.  The last time I looked at what loads gcse.c load-PRE would move, it only
touched loads from globals, so it may be a redundant pass when tree-ssa-pre
moves them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[pinskia at gcc dot gnu dot org]

------- Comment #14 from pinskia at gcc dot gnu dot org  2008-04-07 01:46 -------
*** Bug 35287 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2008-04-07 01:44 -------
*** Bug 25553 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455

[Bug tree-optimization/23455] tree load PRE is not working for global variables

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2008-04-07 01:40 -------
*** Bug 35286 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xinliangli at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23455