public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/24021] VRP does not work with floating points
Date: Wed, 09 Feb 2022 18:30:32 +0000	[thread overview]
Message-ID: <bug-24021-4-mxYuviTW9x@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-24021-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24021

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Various match.pd patterns use predicates like:
(simplify
 (mult @0 real_zerop@1)
 (if (!tree_expr_maybe_nan_p (@0)
      && (!HONOR_NANS (type) || !tree_expr_maybe_infinite_p (@0))
      && (!HONOR_SIGNED_ZEROS (type) || tree_expr_nonnegative_p (@0)))
  @1))

/* In IEEE floating point, x*1 is not equivalent to x for snans.
   Likewise for complex arithmetic with signed zeros.  */
(simplify
 (mult @0 real_onep)
 (if (!tree_expr_maybe_signaling_nan_p (@0)
      && (!HONOR_SIGNED_ZEROS (type)
          || !COMPLEX_FLOAT_TYPE_P (type)))
  (non_lvalue @0)))

etc. which would be great if it could use frange.  Though, I think we also run
here into the problem that match.pd right now avoids the ranger because it
could reliably only allow walks from uses to SSA_NAME_DEF_STMTs and not the
other direction.
But of course those few simplifications are simple enough that they could be
also repeated somewhere in the e?vrp code.

One thing to consider is that at runtime, not all arithmetics might be as
precise as what mpfr does at compile time, so in some cases it should expect a
few ulps or maybe even more than that as possible errors (especially for
library functions).  And also take into account different rounding modes if
user wants that to be honored.

As for exceptions, I guess one thing is that ranger computes ranges and another
thing is that optimization based on that will sometimes need to punt if it
could optimize away visible side-effects the user cares about.

  parent reply	other threads:[~2022-02-09 18:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-24021-4@http.gcc.gnu.org/bugzilla/>
2021-08-25 20:29 ` amacleod at redhat dot com
2022-02-07 16:07 ` aldyh at gcc dot gnu.org
2022-02-09 16:35 ` aldyh at gcc dot gnu.org
2022-02-09 17:04 ` law at gcc dot gnu.org
2022-02-09 17:27 ` aldyh at gcc dot gnu.org
2022-02-09 17:29 ` vincent-gcc at vinc17 dot net
2022-02-09 17:31 ` vincent-gcc at vinc17 dot net
2022-02-09 18:30 ` jakub at gcc dot gnu.org [this message]
2022-02-09 18:31 ` amacleod at redhat dot com
2022-02-09 18:35 ` amacleod at redhat dot com
2022-02-09 19:05 ` vincent-gcc at vinc17 dot net
2022-02-10  9:33 ` rguenth at gcc dot gnu.org
2022-02-10 12:02 ` jakub at gcc dot gnu.org
2022-02-10 12:21 ` rguenther at suse dot de
2022-02-10 14:17 ` vincent-gcc at vinc17 dot net
2022-04-05 19:34 ` amacleod at redhat dot com
2022-04-06  9:34 ` aldyh at gcc dot gnu.org
2022-04-06  9:46 ` jakub at gcc dot gnu.org
2022-04-06  9:57 ` aldyh at gcc dot gnu.org
2022-04-06 10:30 ` aldyh at gcc dot gnu.org
2022-04-06 10:47 ` jakub at gcc dot gnu.org
2022-08-01 13:27 ` aldyh at gcc dot gnu.org
2022-08-01 14:30 ` aldyh at gcc dot gnu.org
2022-11-08 15:54 ` cvs-commit at gcc dot gnu.org
2022-11-08 15:57 ` aldyh at gcc dot gnu.org
2022-11-28 22:15 ` pinskia at gcc dot gnu.org
     [not found] <bug-24021-6528@http.gcc.gnu.org/bugzilla/>
2005-10-23 23:43 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24021-4-mxYuviTW9x@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).