public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "thebohemian at gmx dot net" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libgcj/24638] New: inconsistent use of Jv_FindClass causing too weak error condition Date: Wed, 02 Nov 2005 16:35:00 -0000 [thread overview] Message-ID: <bug-24638-10268@http.gcc.gnu.org/bugzilla/> (raw) Jv_FindClass throws a ClassNotFoundException in case the requested class cannot be resolved (regardless of whether the bytecode missing or a further dependency cannot be resolved). This causes problems because in case of serious bytecode errors (eg. the class of a field is missing) where a NoClassDefFoundError should reach the user code. I found code in several places in gcj where the caller of Jv_FindClass expected NULL to be returned. This affects Jv_FindClassFromSignature too because it depends on the former function. Obviously such code will not be executed (unless the Jv_FindClass takes a special codepath where it call Jv_FindClassInCache). - link.cc: around line 1000, look for: if (target_class == NULL) throw new java::lang::NoClassDefFoundError (_Jv_NewStringUTF (sym.class_name->chars())); - verify.cc: around 387, look for data.klass = _Jv_FindClassFromSignature (data.name->chars(), loader); if (data.klass == NULL) throw new java::lang::NoClassDefFoundError(data.name->toString()); I want to hear what the experts have to say about that. My suggestion would be to introduce a special variant of Jv_FindClass which does not throw a ClassNotFoundException (by swallowing it) and then carefully adjusting the code location where the old variant was used. -- Summary: inconsistent use of Jv_FindClass causing too weak error condition Product: gcc Version: 4.0.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libgcj AssignedTo: thebohemian at gmx dot net ReportedBy: thebohemian at gmx dot net http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24638
next reply other threads:[~2005-11-02 16:35 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-11-02 16:35 thebohemian at gmx dot net [this message] 2005-11-16 16:50 ` [Bug libgcj/24638] " thebohemian at gmx dot net 2006-02-01 13:49 ` thebohemian at gmx dot net
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-24638-10268@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).