From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7130 invoked by alias); 4 Apr 2012 15:28:11 -0000 Received: (qmail 7120 invoked by uid 22791); 4 Apr 2012 15:28:10 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Apr 2012 15:27:58 +0000 From: "manu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/24985] caret diagnostics Date: Wed, 04 Apr 2012 15:28:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: enhancement X-Bugzilla-Who: manu at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg00282.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D24985 Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jason at gcc dot gnu.org --- Comment #16 from Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez 2012-04-04 15:26:50 UTC --- @Jason, This is my current patch. It directly opens the file a looks for the line.= =20 I see several improvements that could be made, like handling very long line= s in a smarter way, a cache of already opened files, and moving all this code to libcpp (or even better to a separate liblinemap library). But there are improvements that could be done post-commit. This patch bootstraps for languages=3Dall,ada with both the default set to = off and on, and regression tested with the default set to off, because I couldn= 't find a good way to tell DejaGNU to always use -fno-diagnostics-show-caret. = Does anyone know the correct way to do this? This is the only missing piece. If it looks ok to you, I will write a changelog and submit it to gcc-patche= s.