public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/25045] New: better diagnostic needed
@ 2005-11-26 17:43 jv244 at cam dot ac dot uk
2005-11-26 18:51 ` [Bug fortran/25045] DIM argument of PRODUCT is not optional fxcoudert at gcc dot gnu dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: jv244 at cam dot ac dot uk @ 2005-11-26 17:43 UTC (permalink / raw)
To: gcc-bugs
using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease) with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:
END
SUBROUTINE S1(N)
INTEGER, OPTIONAL :: N
INTEGER :: A(3)
write(6,*) PRODUCT(A,N)
END SUBROUTINE
--
Summary: better diagnostic needed
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jv244 at cam dot ac dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
@ 2005-11-26 18:51 ` fxcoudert at gcc dot gnu dot org
2006-02-14 19:25 ` tkoenig at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-11-26 18:51 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from fxcoudert at gcc dot gnu dot org 2005-11-26 18:51 -------
gfortran does not give diagnostic on that one.
## g95 ##
In file foo.f90:5
write(6,*) PRODUCT(A,N)
1
Error: 'dim' argument of 'product' intrinsic at (1) must not be OPTIONAL
## Intel ##
fortcom: Error: foo.f90, line 5: Intrinsic DIM argument shall not be an
optional dummy argument. [N]
write(6,*) PRODUCT(A,N)
-----------------------^
compilation aborted for foo.f90 (code 1)
## Sun ##
write(6,*) PRODUCT(A,N)
^
"foo.f90", Line = 5, Column = 24: ERROR: This actual argument must not be an
optional dummy argument.
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Keywords| |accepts-invalid
Last reconfirmed|0000-00-00 00:00:00 |2005-11-26 18:51:52
date| |
Summary|better diagnostic needed |DIM argument of PRODUCT is
| |not optional
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-26 18:51 ` [Bug fortran/25045] DIM argument of PRODUCT is not optional fxcoudert at gcc dot gnu dot org
@ 2006-02-14 19:25 ` tkoenig at gcc dot gnu dot org
2006-02-15 7:09 ` grigory_zagorodnev at linux dot intel dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2006-02-14 19:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from tkoenig at gcc dot gnu dot org 2006-02-14 19:25 -------
Subject: Bug 25045
Author: tkoenig
Date: Tue Feb 14 19:25:36 2006
New Revision: 110994
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110994
Log:
2006-02-14 Thomas Koenig <Thomas.Koenig@online.de>
PR fortran/25045
* check.c (dim_check): Perform all checks if dim is optional.
(gfc_check_minloc_maxloc): Use dim_check and dim_rank_check
to check dim argument.
(check_reduction): Likewise.
2006-02-14 Thomas Koenig <Thomas.Koenig@online.de>
PR fortran/25045
* optional_dim.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/optional_dim.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/check.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-26 18:51 ` [Bug fortran/25045] DIM argument of PRODUCT is not optional fxcoudert at gcc dot gnu dot org
2006-02-14 19:25 ` tkoenig at gcc dot gnu dot org
@ 2006-02-15 7:09 ` grigory_zagorodnev at linux dot intel dot com
2006-02-26 19:29 ` [Bug fortran/25045] [4.1 only] " tkoenig at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: grigory_zagorodnev at linux dot intel dot com @ 2006-02-15 7:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from grigory_zagorodnev at linux dot intel dot com 2006-02-15 07:09 -------
It looks like the patch has affected stability of 178.galgel, 187.facerec and
189.lucas benchmarks of cpu2000 suite and other massive fails today:
http://gcc.gnu.org/ml/gcc/2006-02/msg00247.html
Reversed patch http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110994 fixes
the compiler.
Compiler message
----------------
internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
compiler exited with status 1
GDB says
--------
Program received signal SIGSEGV, Segmentation fault.
dim_rank_check (dim=0x0, array=0xd0bcb0, allow_assumed=0)
at /home/testbot/bootstrap/gcc-42/src/gcc/fortran/check.c:332
332 if (dim->expr_type != EXPR_CONSTANT || array->expr_type !=
EXPR_VARIABLE)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] [4.1 only] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
` (2 preceding siblings ...)
2006-02-15 7:09 ` grigory_zagorodnev at linux dot intel dot com
@ 2006-02-26 19:29 ` tkoenig at gcc dot gnu dot org
2006-03-04 22:22 ` tkoenig at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2006-02-26 19:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from tkoenig at gcc dot gnu dot org 2006-02-26 19:21 -------
After Tobi's fix for the regression the original patch introduced,
this now works on trunk.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|DIM argument of PRODUCT is |[4.1 only] DIM argument of
|not optional |PRODUCT is not optional
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] [4.1 only] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
` (3 preceding siblings ...)
2006-02-26 19:29 ` [Bug fortran/25045] [4.1 only] " tkoenig at gcc dot gnu dot org
@ 2006-03-04 22:22 ` tkoenig at gcc dot gnu dot org
2006-03-05 18:35 ` tkoenig at gcc dot gnu dot org
2006-03-14 1:23 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2006-03-04 22:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from tkoenig at gcc dot gnu dot org 2006-03-04 22:21 -------
Subject: Bug 25045
Author: tkoenig
Date: Sat Mar 4 22:21:52 2006
New Revision: 111718
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111718
Log:
2006-03-04 Thomas Koenig <Thomas.Koenig@online.de>
PR fortran/25045
PR fortran/25075
backport from mainline
* check.c (dim_check): Perform all checks if dim is optional.
(gfc_check_minloc_maxloc): Use dim_check and dim_rank_check
to check dim argument.
(check_reduction): Likewise.
check.c (identical_dimen_shape): New function.
(check_dot_product): Use identical_dimen_shape() to check sizes
for dot_product.
(gfc_check_matmul): Likewise.
(gfc_check_merge): Check conformance between tsource and fsource
and between tsource and mask.
(gfc_check_pack): Check conformance between array and mask.
2006-03-04 Thomas Koenig <Thomas.Koenig@online.de>
PR fortran/25045
PR fortran/25075
backport from mainline
* optional_dim.f90: New test.
* intrinsic_argument_conformance_1.f90: New test.
Added:
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/intrinsic_argument_conformance_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/optional_dim.f90
Modified:
branches/gcc-4_1-branch/gcc/fortran/ChangeLog
branches/gcc-4_1-branch/gcc/fortran/check.c
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] [4.1 only] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
` (4 preceding siblings ...)
2006-03-04 22:22 ` tkoenig at gcc dot gnu dot org
@ 2006-03-05 18:35 ` tkoenig at gcc dot gnu dot org
2006-03-14 1:23 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2006-03-05 18:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from tkoenig at gcc dot gnu dot org 2006-03-05 18:35 -------
Fixed on 4.1 as well.
Closing.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug fortran/25045] [4.1 only] DIM argument of PRODUCT is not optional
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
` (5 preceding siblings ...)
2006-03-05 18:35 ` tkoenig at gcc dot gnu dot org
@ 2006-03-14 1:23 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-14 1:23 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.1.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25045
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-03-14 1:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-26 17:43 [Bug fortran/25045] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-26 18:51 ` [Bug fortran/25045] DIM argument of PRODUCT is not optional fxcoudert at gcc dot gnu dot org
2006-02-14 19:25 ` tkoenig at gcc dot gnu dot org
2006-02-15 7:09 ` grigory_zagorodnev at linux dot intel dot com
2006-02-26 19:29 ` [Bug fortran/25045] [4.1 only] " tkoenig at gcc dot gnu dot org
2006-03-04 22:22 ` tkoenig at gcc dot gnu dot org
2006-03-05 18:35 ` tkoenig at gcc dot gnu dot org
2006-03-14 1:23 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).