[Bug fortran/25077] New: better diagnostic needed

[Bug fortran/25077] New: better diagnostic needed

[jv244 at cam dot ac dot uk]

using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease)  with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:

MODULE M1
 IMPLICIT NONE
 INTERFACE ASSIGNMENT(=)
  MODULE PROCEDURE T1
 END INTERFACE
CONTAINS
 SUBROUTINE T1(I,J)
   INTEGER, INTENT(OUT)  :: I
   INTEGER, INTENT(IN)  :: J
   I=-J
 END SUBROUTINE T1
END MODULE M1

USE M1
IMPLICIT NONE
INTEGER :: I,J
I=1
J=I
write(6,*) I,J
END


-- 
           Summary: better diagnostic needed
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[eedelman at gcc dot gnu dot org]

------- Comment #1 from eedelman at gcc dot gnu dot org  2005-11-28 21:57 -------
Confirmed.  (Relevant section of the F2003 draft standard: 12.3.2.1.2).


-- 

eedelman at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-28 21:57:52
               date|                            |
            Summary|better diagnostic needed    |No error on attempt to
                   |                            |redefine  intrinsic
                   |                            |assigments


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[pault at gcc dot gnu dot org]

------- Comment #2 from pault at gcc dot gnu dot org  2006-08-19 17:01 -------
Created an attachment (id=12099)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12099&action=view)
Fix for the problem

This patch generates an error if an interface assignement attempts to modify an
intrinsic type assignment.  If a warning is thought to be better, I could do
that.  Note that the condition is a copy of that in gfc_extend_assign, which
prevents a search for an interface for intrinsic type assignments.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[patchapp at dberlin dot org]

------- Comment #3 from patchapp at dberlin dot org  2006-08-20 06:05 -------
Subject: Bug number PR25077

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00712.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2006-08-20 07:32 -------
Subject: Bug number PR25077

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00716.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2006-08-30 05:19 -------
Subject: Bug 25077

Author: pault
Date: Wed Aug 30 05:19:34 2006
New Revision: 116579

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116579
Log:
2006-08-30  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/28885
        REGRESSION FIX
        * trans-expr.c (gfc_conv_aliased_arg): Ensure that the temp
        declaration is retained for INTENT(OUT) arguments.

        PR fortran/28873
        REGRESSION FIX
        PR fortran/20067
        * resolve.c (resolve_generic_f): Make error message more
        comprehensible.
        (resolve_generic_s): Restructure search for specific procedures
        to be similar to resolve_generic_f and change to similar error
        message.  Ensure that symbol reference is refreshed, in case
        the search produces a NULL.
        (resolve_specific_s): Restructure search, as above and as
        resolve_specific_f. Ensure that symbol reference is refreshed,
        in case the search produces a NULL.

        PR fortran/25077
        PR fortran/25102
        * interface.c (check_operator_interface): Throw error if the
        interface assignment tries to change intrinsic type assigments
        or has less than two arguments.  Also, it is an error if an
        interface operator contains an alternate return.

        PR fortran/24866
        * parse.c (gfc_fixup_sibling_symbols): Do not modify the symbol
        if it is a dummy in the contained namespace.


2006-08-30  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/28885
        * gfortran.dg/aliasing_dummy_2.f90: New test.

        PR fortran/20067
        * gfortran.dg/generic_5.f90: Change error message.

        PR fortran/28873
        * gfortran.dg/generic_6.f90: New test.

        PR fortran/25077
        * gfortran.dg/redefined_intrinsic_assignment.f90: New test.

        PR fortran/25102
        * gfortran.dg/invalid_interface_assignment.f90: New test.

        PR fortran/24866
        * gfortran.dg/module_proc_external_dummy.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/aliasing_dummy_2.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/generic_6.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/invalid_interface_assignment.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/module_proc_external_dummy.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/redefined_intrinsic_assignment.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/interface.c
    branches/gcc-4_1-branch/gcc/fortran/parse.c
    branches/gcc-4_1-branch/gcc/fortran/resolve.c
    branches/gcc-4_1-branch/gcc/fortran/trans-expr.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/generic_5.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2006-08-30 05:19 -------
Subject: Bug 25077

Author: pault
Date: Wed Aug 30 05:18:36 2006
New Revision: 116578

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116578
Log:
2006-08-30  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/28885
        REGRESSION FIX
        * trans-expr.c (gfc_conv_aliased_arg): Ensure that the temp
        declaration is retained for INTENT(OUT) arguments.

        PR fortran/28873
        REGRESSION FIX
        PR fortran/20067
        * resolve.c (resolve_generic_f): Make error message more
        comprehensible.
        (resolve_generic_s): Restructure search for specific procedures
        to be similar to resolve_generic_f and change to similar error
        message.  Ensure that symbol reference is refreshed, in case
        the search produces a NULL.
        (resolve_specific_s): Restructure search, as above and as
        resolve_specific_f. Ensure that symbol reference is refreshed,
        in case the search produces a NULL.

        PR fortran/25077
        PR fortran/25102
        * interface.c (check_operator_interface): Throw error if the
        interface assignment tries to change intrinsic type assigments
        or has less than two arguments.  Also, it is an error if an
        interface operator contains an alternate return.

        PR fortran/24866
        * parse.c (gfc_fixup_sibling_symbols): Do not modify the symbol
        if it is a dummy in the contained namespace.


2006-08-30  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/28885
        * gfortran.dg/aliasing_dummy_2.f90: New test.

        PR fortran/20067
        * gfortran.dg/generic_5.f90: Change error message.

        PR fortran/28873
        * gfortran.dg/generic_6.f90: New test.

        PR fortran/25077
        * gfortran.dg/redefined_intrinsic_assignment.f90: New test.

        PR fortran/25102
        * gfortran.dg/invalid_interface_assignment.f90: New test.

        PR fortran/24866
        * gfortran.dg/module_proc_external_dummy.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/aliasing_dummy_2.f90
    trunk/gcc/testsuite/gfortran.dg/generic_6.f90
    trunk/gcc/testsuite/gfortran.dg/invalid_interface_assignment.f90
    trunk/gcc/testsuite/gfortran.dg/module_proc_external_dummy.f90
    trunk/gcc/testsuite/gfortran.dg/redefined_intrinsic_assignment.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/generic_5.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077

[Bug fortran/25077] No error on attempt to redefine intrinsic assigments

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2006-08-30 05:32 -------
Fixed on trunk and 4.1

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25077