From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 69C533985440; Tue,  8 Jun 2021 22:13:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69C533985440
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/25290] PHI-OPT could be rewritten so that is
 uses match
Date: Tue, 08 Jun 2021 22:13:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.2.0
X-Bugzilla-Keywords: missed-optimization, patch
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-25290-4-blWND8Lxhh@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-25290-4@http.gcc.gnu.org/bugzilla/>
References: <bug-25290-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2021 22:13:23 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D25290

--- Comment #20 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:c4574d23cb07340918793a5a98ae7bb2988b3791

commit r12-1309-gc4574d23cb07340918793a5a98ae7bb2988b3791
Author: Andrew Pinski <apinski@marvell.com>
Date:   Tue Jun 1 06:48:05 2021 +0000

    Improve match_simplify_replacement in phi-opt

    This improves match_simplify_replace in phi-opt to handle the
    case where there is one cheap (non-call) preparation statement in the
    middle basic block similar to xor_replacement and others.
    This allows to remove xor_replacement which it does too.

    OK?  Bootstrapped and tested on x86_64-linux-gnu with no regressions.

    Thanks,
    Andrew Pinski

    Changes since v1:
    v3 - Just minor changes to using gimple_assign_lhs
    instead of gimple_lhs and fixing a comment.
    v2 - change the check on the preparation statement to
    allow only assignments and no calls and only assignments
    that feed into the phi.

    gcc/ChangeLog:

            PR tree-optimization/25290
            * tree-ssa-phiopt.c (xor_replacement): Delete.
            (tree_ssa_phiopt_worker): Delete use of xor_replacement.
            (match_simplify_replacement): Allow one cheap preparation
            statement that can be moved to before the if.

    gcc/testsuite/ChangeLog:

            * gcc.dg/tree-ssa/pr96928-1.c: Fix testcase for now that ~
            happens on the outside of the bit_xor.=