[Bug target/25376] section attribute doesn't work on darwin

[Bug target/25376] section attribute doesn't work on darwin

[jconner at apple dot com]

------- Comment #1 from jconner at apple dot com  2005-12-12 18:11 -------
I have a patch for this I'll submit to gcc-patches.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] New: section attribute doesn't work on darwin

[jconner at apple dot com]

Trying to assign a function to a user-named section fails on darwin in the 4.0,
4.1, and mainline.  For example, compiling this code:

  void specialfn (void) __attribute__((section ("__TEXT,__init")));
  void specialfn (void) {}

Places the function 'specialfn' into the default .text section instead of the
user-specified __init section.  From the assembly code:

          .text
          .align 2
          .globl _specialfn
  _specialfn:

Should be:

          .section __TEXT,__init
          .align 2
          .globl _specialfn
  _specialfn:


-- 
           Summary: section attribute doesn't work on darwin
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jconner at apple dot com
GCC target triplet: powerpc-apple-darwin8.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-12-12 18:20 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2005-12-12 18:20:34
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-02-03 20:21 -------
Updated patch posted:
http://gcc.gnu.org/ml/gcc-patches/2006-02/msg00226.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |02/msg00226.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[jconner at gcc dot gnu dot org]

------- Comment #4 from jconner at gcc dot gnu dot org  2006-02-13 18:12 -------
Subject: Bug 25376

Author: jconner
Date: Mon Feb 13 18:12:17 2006
New Revision: 110917

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110917
Log:
PR target/25376
* varasm.c (function_section): Check for section name before
calling select_section on targets that define
USE_SELECT_SECTION_FOR_FUNCTIONS.  On other targets, use
unlikely_text_section instead of hot_function_section if
first_function_block_is_cold.
* gcc.dg/pr25376.c: New test.

* gcc.c-torture/compile/pr23237.c: Only compile test -- don't
assemble.
* lib/target-supports.exp (check_named_sections_available):
Only compile named-sections test -- don't assemble.


Added:
    trunk/gcc/testsuite/gcc.dg/pr25376.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.c-torture/compile/pr23237.c
    trunk/gcc/testsuite/lib/target-supports.exp
    trunk/gcc/varasm.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[jconner at gcc dot gnu dot org]

------- Comment #5 from jconner at gcc dot gnu dot org  2006-02-14 17:23 -------
Subject: Bug 25376

Author: jconner
Date: Tue Feb 14 17:23:00 2006
New Revision: 110987

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110987
Log:
Radar 4373419
PR target/25376
* gcc/varasm.c (function_section): Don't call select_section if a
section name is present.
* testsuite/gcc.dg/pr25376: New test.
* testsuite/lib/target-supports.exp (check_named_sections_available):
Only compile named-sections test -- don't assemble.


Added:
    branches/apple-local-200502-branch/gcc/testsuite/gcc.dg/pr25376.c
Modified:
    branches/apple-local-200502-branch/gcc/ChangeLog.apple-ppc
    branches/apple-local-200502-branch/gcc/testsuite/ChangeLog.apple-ppc
    branches/apple-local-200502-branch/gcc/testsuite/lib/target-supports.exp
    branches/apple-local-200502-branch/gcc/varasm.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[howarth at nitro dot med dot uc dot edu]

------- Comment #6 from howarth at nitro dot med dot uc dot edu  2006-10-01 00:29 -------
Shouldn't this bug be marked as closed now?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[jconner at apple dot com]

------- Comment #7 from jconner at apple dot com  2006-10-02 16:44 -------
(In reply to comment #6)
> Shouldn't this bug be marked as closed now?

Perhaps - however, it's not been fixed on the 4.0 or 4.1 branches...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376

[Bug target/25376] section attribute doesn't work on darwin

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-10-02 16:51 -------
(In reply to comment #7)
> Perhaps - however, it's not been fixed on the 4.0 or 4.1 branches...
But this is not a regression so closing as fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25376