[Bug fortran/25395] New: equivalence to common block array broken

[Bug fortran/25395] New: equivalence to common block array broken

[harald dot vogt at desy dot de]

The following code shows the problem:
      program test

      common /abc/ mwkx(80)
      dimension    listpr(20),lisbit(10),lispat(8)

*     This is badly compiled
*     ======================
      equivalence (listpr(10),lisbit(1),mwkx(10))
     +,           (listpr(10),lispat(1))

      do i = 1,20
        listpr(i) = 0
      enddo
      do i = 1,10
        lisbit(i) = i
      enddo
      do j = 3,4
        lisbit(j) = 0
      enddo
      print *, '======================================================'
      print *, 'wrong result:'
      print '(20i4)', listpr
      call sub1
      call sub2
      stop
      end

      subroutine sub1

      common /abc/ mwkx(80)
      dimension    listpr(20),lisbit(10),lispat(8)

*     This is a workaround
*     ====================
      equivalence (listpr(10),lisbit(1)), (listpr(10),mwkx(10))
     +,           (listpr(10),lispat(1))

      do i = 1,20
        listpr(i) = 0
      enddo
      do i = 1,10
        lisbit(i) = i
      enddo
      do j = 3,4
        lisbit(j) = 0
      enddo
      print *, '======================================================'
      print *, 'correct result:'
      print '(20i4)', listpr
      end

      subroutine sub2

*     This gives correct results
*     ==========================
      dimension    mwkx(80)
      dimension    listpr(20),lisbit(10),lispat(8)
      equivalence (listpr(10),lisbit(1),mwkx(10))
     +,           (listpr(10),lispat(1))

      do i = 1,20
        listpr(i) = 0
      enddo
      do i = 1,10
        lisbit(i) = i
      enddo
      do j = 3,4
        lisbit(j) = 0
      enddo
      print *, '======================================================'
      print *, 'correct result (common replaced by dimension):'
      print '(20i4)', listpr
      end
This yields the following output:

 ======================================================
 wrong result:
   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0  
0
 ======================================================
 correct result:
   0   0   0   0   0   0   0   0   0   1   2   0   0   5   6   7   8   9  10  
0
 ======================================================
 correct result (common replaced by dimension):
   0   0   0   0   0   0   0   0   0   1   2   0   0   5   6   7   8   9  10  
0


-- 
           Summary: equivalence to common block array broken
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: harald dot vogt at desy dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[tobi at gcc dot gnu dot org]

------- Comment #1 from tobi at gcc dot gnu dot org  2006-02-19 20:15 -------
Confirmed, I think Paul Thomas is looking into this.


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-02-19 20:15:34
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[paul dot richard dot thomas at cea dot fr]

------- Comment #2 from paul dot richard dot thomas at cea dot fr  2006-02-20 15:25 -------
(In reply to comment #1)
> Confirmed, I think Paul Thomas is looking into this.

Yes, I got sidetracked into it!

Something is awry with the adding of variables to an equivalence segment in
anything other than order of increasing offset.  Knowing this, I found that
this is broken:

      dimension    mwkx(80)
      dimension    listpr(20),lisbit(10),lispat(8)
      equivalence (listpr(10),lispat(1))
     +,           (mwkx(10),listpr(10),lisbit(1))

I keep thinking that this is something obvious but it is proving to be elusive.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2006-02-24 10:51 -------
Subject: Bug 25395

Author: pault
Date: Fri Feb 24 10:51:42 2006
New Revision: 111416

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111416
Log:
2006-02-24  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24519
        * dependency.c (gfc_is_same_range): Correct typo.
        (gfc_check_section_vs_section): Call gfc_is_same_range.

        PR fortran/25395
        * trans-common.c (add_equivalences): Add a new flag that is set when
        an equivalence is seen that prevents more from being reset until the
        start of a new traversal of the list, thus ensuring completion of
        all the equivalences.

2006-02-24  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/24519
        * gfortran.dg/dependency_3.f90: New test.
        * gfortran.fortran-torture/execute/vect-3.f90: Remove two of the
        XFAILs.

        PR fortran/25395
        * gfortran.dg/equiv_6.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/dependency_3.f90
    trunk/gcc/testsuite/gfortran.dg/equiv_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/dependency.c
    trunk/gcc/fortran/trans-common.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/vect/vect-3.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2006-02-24 10:53 -------
Fixed on trunk.

As soon as 4.1 is reopened, it will be fixed there too.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2006-03-07 00:06 -------
Subject: Bug 25395

Author: pault
Date: Tue Mar  7 00:06:37 2006
New Revision: 111796

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111796
Log:
2006-03-07  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26107
        * resolve.c (resolve_function): Add name after test for pureness.

        * iresolve.c (gfc_resolve_dot_product):  Remove any difference in
        treatment of logical types.
        * trans-intrinsic.c (gfc_conv_intrinsic_dot_product):  New function. 

        PR fortran/26393
        * trans-decl.c (gfc_get_symbol_decl): Extend condition that symbols
        must be referenced to include unreferenced symbols in an interface
        body. 

        PR fortran/20938
        * trans-array.c (gfc_conv_resolve_dependencies): Add call to
        gfc_are_equivalenced_arrays.
        * symbol.c (gfc_free_equiv_infos, gfc_free_equiv_lists): New
        functions. (gfc_free_namespace): Call them.
        * trans-common.c (copy_equiv_list_to_ns): New function.
        (add_equivalences): Call it.
        * gfortran.h: Add equiv_lists to gfc_namespace and define
        gfc_equiv_list and gfc_equiv_info.
        * dependency.c (gfc_are_equivalenced_arrays): New function.
        (gfc_check_dependency): Call it.
        * dependency.h: Prototype for gfc_are_equivalenced_arrays.

        PR fortran/24519
        * dependency.c (gfc_is_same_range): Correct typo.
        (gfc_check_section_vs_section): Call gfc_is_same_range.

        PR fortran/25395
        * trans-common.c (add_equivalences): Add a new flag that is set when
        an equivalence is seen that prevents more from being reset until the
        start of a new traversal of the list, thus ensuring completion of
        all the equivalences.

        PR fortran/25054
        * resolve.c (is_non_constant_shape_array): New function.
        (resolve_fl_variable): Remove code for the new function and call it.
        (resolve_fl_namelist): New function.  Add test for namelist array
        with non-constant shape, using is_non_constant_shape_array.
        (resolve_symbol): Remove code for resolve_fl_namelist and call it.

        PR fortran/25089
        * match.c (match_namelist): Increment the refs field of an accepted
        namelist object symbol.
        * resolve.c (resolve_fl_namelist): Test namelist objects for a conflict
        with contained or module procedures.

        PR fortran/24557
        * trans-expr.c (gfc_add_interface_mapping): Use the actual argument
        for character(*) arrays, rather than casting to the type and kind
        parameters of the formal argument.

2006-03-07  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26107
        * resolve.c (resolve_function): Add name after test for pureness.

        * gfortran.dg/logical_dot_product.f90: New test. 

        PR fortran/26393
        * gfortran.dg/used_interface_ref.f90: New test.

        PR fortran/20938
        * gfortran.dg/dependency_2.f90: New test.
        * gfortran.fortran-torture/execute/where17.f90: New test.
        * gfortran.fortran-torture/execute/where18.f90: New test.
        * gfortran.fortran-torture/execute/where19.f90: New test.
        * gfortran.fortran-torture/execute/where20.f90: New test.

        PR fortran/24519
        * gfortran.dg/dependency_3.f90: New test.
        * gfortran.fortran-torture/execute/vect-3.f90: Remove two of the
        XFAILs.

        PR fortran/25395
        * gfortran.dg/equiv_6.f90: New test.

        PR fortran/25054
        * gfortran.dg/namelist_5.f90: New test.

        PR fortran/25089
        * gfortran.dg/namelist_4.f90: New test.

        PR fortran/24557
        * gfortran.dg/assumed_charlen_needed_1.f90: New test.

Added:
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/assumed_charlen_needed_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/dependency_2.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/dependency_3.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/equiv_6.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/logical_dot_product.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_4.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_5.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/pure_dummy_length_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/used_interface_ref.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.fortran-torture/execute/where17.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.fortran-torture/execute/where18.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.fortran-torture/execute/where19.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.fortran-torture/execute/where20.f90
Modified:
    branches/gcc-4_1-branch/MAINTAINERS
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/dependency.c
    branches/gcc-4_1-branch/gcc/fortran/dependency.h
    branches/gcc-4_1-branch/gcc/fortran/dump-parse-tree.c
    branches/gcc-4_1-branch/gcc/fortran/gfortran.h
    branches/gcc-4_1-branch/gcc/fortran/iresolve.c
    branches/gcc-4_1-branch/gcc/fortran/match.c
    branches/gcc-4_1-branch/gcc/fortran/resolve.c
    branches/gcc-4_1-branch/gcc/fortran/symbol.c
    branches/gcc-4_1-branch/gcc/fortran/trans-array.c
    branches/gcc-4_1-branch/gcc/fortran/trans-common.c
    branches/gcc-4_1-branch/gcc/fortran/trans-decl.c
    branches/gcc-4_1-branch/gcc/fortran/trans-expr.c
    branches/gcc-4_1-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/vect/vect-3.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395

[Bug fortran/25395] equivalence to common block array broken

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.0                       |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25395