[Bug bootstrap/25476] New: [4.2 Regression] Fixincludes is run three times

[Bug bootstrap/25476] New: [4.2 Regression] Fixincludes is run three times

[pinskia at gcc dot gnu dot org]

We now run/build fixincludes three when bootstrapping GCC.  We really only need
to build/run it once after stage1.

Right now we build and run it three times which seems like a waste of time.


-- 
           Summary: [4.2 Regression] Fixincludes is run three times
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bonzini at gnu dot org
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-12-18 04:51 -------
One more thing, if we let it run once, we would also fix the debuging info and
the "make install" problem with how we build GCC currently.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[bonzini at gnu dot org]

------- Comment #2 from bonzini at gnu dot org  2005-12-19 08:40 -------
I think this was some kind of merging hiccup because I found this in the
ChangeLog:

2004-08-30  Paolo Bonzini  <bonzini@gnu.org>

        * configure.ac: Do not run fixincludes after stage1 during
        toplevel bootstrap.
        * configure: Regenerate.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[bonzini at gnu dot org]

------- Comment #3 from bonzini at gnu dot org  2005-12-19 08:47 -------
Indeed, Geoff removed the snippet in revision 90117 probably because he did not
know what it was good for.  I will reapply the patch.


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bonzini at gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-12-19 08:47:57
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2005-12-19 08:54 -------
(In reply to comment #3)
> Indeed, Geoff removed the snippet in revision 90117 probably because he did not
> know what it was good for.  I will reapply the patch.

Well he moved it to the toplevel at the same time so it might cause something
weird when he was testing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[bonzini at gnu dot org]

------- Comment #5 from bonzini at gnu dot org  2006-01-04 16:38 -------
Patch posted.  Andrew suggested another approach, but it is more complex and
I'm not going to work on it until more important issues are sorted out.


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |01/msg00184.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[bonzini at gcc dot gnu dot org]

------- Comment #6 from bonzini at gnu dot org  2006-02-20 08:29 -------
Subject: Bug 25476

Author: bonzini
Date: Mon Feb 20 08:29:17 2006
New Revision: 111295

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111295
Log:
2006-02-20  Paolo Bonzini  <bonzini@gnu.org>

        PR bootstrap/25670

        * Makefile.tpl ([+compare-target+]): Print explanation messages.

        * Makefile.def (ADAFLAGS, BOOT_ADAFLAGS, LANGUAGES): New flags_to_pass.
        * Makefile.tpl (BASE_FLAGS_TO_PASS): Support optional flags_to_pass.
        (EXTRA_GCC_FLAGS): Remove ADAFLAGS, BOOT_ADAFLAGS, LANGUAGES,
        BUILD_PREFIX, BUILD_PREFIX_1.
        * configure.in: (BUILD_PREFIX, BUILD_PREFIX_1): Don't substitute.

        * Makefile.def (bootstrap stage 1): Pass LIBCFLAGS too.
        * Makefile.tpl (POSTSTAGE1_FLAGS_TO_PASS): Override LIBCFLAGS too.

        * Makefile.tpl (configure-stage[+id+]-[+prefix+][+module+],
        all-stage[+id+]-[+prefix+][+module+], : Use $(current_stage) instead
        of `cat stage_current`.  Always provide the `r' and `s' variables.
        (clean-stage[+id+]-[+prefix+][+module+]): Likewise, and make it into
        a single shell execution.
        (configure-[+prefix+][+module+], all-[+prefix+][+module+]): For
        bootstrapped modules, make the stage1 module if the build was not
        started yet, else build the current stage.
        (all-host, all-target): Omit bootstrapped modules (if bootstrapping).
        (all-build, all-host, all-target, [+make_target+]-host,
        [+make_target+]-target): Do not use \-continued lines.
        (target modules): Depend on stage_last, not all-gcc, if bootstrapping.
        (current_stage, restrap, stage_last): New.

        * Makefile.in: Regenerate.
        * configure: Regenerate.

gcc:
2006-02-20  Paolo Bonzini  <bonzini@gnu.org>

        PR bootstrap/25476

        * Makefile.in (LDFLAGS): Define from autoconf substitution.

        * Makefile.in (BOOTSTRAPPING): New.
        (quickstrap): New definition if BOOTSTRAPPING=yes.

        * Makefile.in (CONFIG_LANGUAGES): Substitute all_selected_languages.
        * configure.ac: Substitute all_selected_languages with the languages
        that were configured.  For all the other variables except
        lang_specs_files, include all the languages in the tree.
        * configure: Regenerate.

        * Makefile.in (stmp-fixinc): Copy includes from the prev-gcc directory,
        if there is one.  Run the commands to run fixincludes in the same
        subshell.

        * doc/makefile.texi: Document new makefile targets from toplevel
bootstrap.
        * doc/install.texi: Document exact conventions for searching target
tools.
        Document --with-build-time-tools.  Document toplevel bootstrap. 
Document
        something more about building an Ada cross-compiler.  Don't list GNU
Make
        requirements which affect all platforms.


Modified:
    trunk/ChangeLog
    trunk/Makefile.def
    trunk/Makefile.in
    trunk/Makefile.tpl
    trunk/configure
    trunk/configure.in
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/configure
    trunk/gcc/configure.ac
    trunk/gcc/doc/install.texi
    trunk/gcc/doc/makefile.texi


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476

[Bug bootstrap/25476] [4.2 Regression] Fixincludes is run three times

[bonzini at gnu dot org]

------- Comment #7 from bonzini at gnu dot org  2006-02-20 08:35 -------
patch committed


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25476