[Bug c++/25637] New: [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[Bug c++/25637] New: [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[reichelt at gcc dot gnu dot org]

The following two invalid code snippets are accepted by the C++ frontend
(the members of A cannot be defined in B):

===============================================
struct A { void foo(); };

struct B { friend void A::foo() {} };
===============================================

===============================================
struct A { A(); };

struct B { friend A::A() {} };
===============================================

Since the second code snippet was rejected in GCC 3.2.x and 3.3.x
(although with a bogus error message) this is regression.


-- 
           Summary: [3.4/4.0/4.1/4.2 regression] Member definition in wrong
                    scope accepted
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-01-02 16:52 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-02 16:52:30
               date|                            |
   Target Milestone|---                         |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mark at codesourcery dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[mmitchel at gcc dot gnu dot org]

------- Comment #2 from mmitchel at gcc dot gnu dot org  2006-01-03 08:38 -------
Subject: Bug 25637

Author: mmitchel
Date: Tue Jan  3 08:38:22 2006
New Revision: 109268

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109268
Log:
        PR c++/25635
        * class.c (add_method): Set TYPE_HAS_CONVERSION for classes with a
        conversion operator.
        * decl.c (grokdeclarator): Do not set TYPE_HAS_CONVERSION here.
        PR c++/25638
        * class.c (add_method): Never associate more than one destructor
        with a single class.
        PR c++/25637
        * decl.c (grokdeclarator): Refine check for invalid
        declarations/definitions of member functions outside of their own
        class.
        PR c++/25633
        * parser.c (cp_parser_mem_initializer_list): Check result of
        cp_parser_mem_initializer against error_mark_node, not NULL_TREE.
        (cp_parser_mem_initializer): Return error_mark_node for failure.
        PR c++/25634
        * parser.c (cp_parser_elaborated_type_specifier): Call
        cp_parser_check_template_parameters.
        PR c++/25635
        * g++.dg/parse/operator6.C: New test.
        PR c++/25637
        * g++.dg/parse/error29.C: New test.
        PR c++/25638
        * g++.dg/parse/dtor6.C: New test.
        PR c++/25633
        * g++.dg/parse/ctor3.C: New test.
        PR c++/25634
        * g++.dg/template/class3.C: New test.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/parse/ctor3.C
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/parse/dtor6.C
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/parse/error29.C
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/parse/operator6.C
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/template/class3.C
Modified:
    branches/gcc-4_0-branch/gcc/cp/ChangeLog
    branches/gcc-4_0-branch/gcc/cp/class.c
    branches/gcc-4_0-branch/gcc/cp/decl.c
    branches/gcc-4_0-branch/gcc/cp/parser.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[mmitchel at gcc dot gnu dot org]

------- Comment #3 from mmitchel at gcc dot gnu dot org  2006-01-03 08:40 -------
Subject: Bug 25637

Author: mmitchel
Date: Tue Jan  3 08:40:18 2006
New Revision: 109269

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109269
Log:
        PR c++/25635
        * class.c (add_method): Set TYPE_HAS_CONVERSION for classes with a
        conversion operator.
        * decl.c (grokdeclarator): Do not set TYPE_HAS_CONVERSION here.
        PR c++/25638
        * class.c (add_method): Never associate more than one destructor
        with a single class.
        PR c++/25637
        * decl.c (grokdeclarator): Refine check for invalid
        declarations/definitions of member functions outside of their own
        class.
        PR c++/25633
        * parser.c (cp_parser_mem_initializer_list): Check result of
        cp_parser_mem_initializer against error_mark_node, not NULL_TREE.
        (cp_parser_mem_initializer): Return error_mark_node for failure.
        PR c++/25634
        * parser.c (cp_parser_elaborated_type_specifier): Call
        cp_parser_check_template_parameters.
        PR c++/25635
        * g++.dg/parse/operator6.C: New test.
        PR c++/25637
        * g++.dg/parse/error29.C: New test.
        PR c++/25638
        * g++.dg/parse/dtor6.C: New test.
        PR c++/25633
        * g++.dg/parse/ctor3.C: New test.
        PR c++/25634
        * g++.dg/template/class3.C: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/parse/ctor3.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/parse/dtor6.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/parse/error29.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/parse/operator6.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/template/class3.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/class.c
    branches/gcc-4_1-branch/gcc/cp/decl.c
    branches/gcc-4_1-branch/gcc/cp/parser.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4/4.0/4.1/4.2 regression] Member definition in wrong scope accepted

[mmitchel at gcc dot gnu dot org]

------- Comment #4 from mmitchel at gcc dot gnu dot org  2006-01-03 08:41 -------
Subject: Bug 25637

Author: mmitchel
Date: Tue Jan  3 08:41:21 2006
New Revision: 109270

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109270
Log:
        PR c++/25635
        * class.c (add_method): Set TYPE_HAS_CONVERSION for classes with a
        conversion operator.
        * decl.c (grokdeclarator): Do not set TYPE_HAS_CONVERSION here.
        PR c++/25638
        * class.c (add_method): Never associate more than one destructor
        with a single class.
        PR c++/25637
        * cp-tree.h (do_friend): Adjust prototype.
        * decl.c (grokfndecl): Make funcdef_flag a bool, not an int.
        (grokdeclarator): Likewise.  Refine check for invalid
        declarations/definitions of member functions outside of their own
        class.
        * friend.c (do_friend): Make funcdef_flag a bool, not an int.
        PR c++/25633
        * parser.c (cp_parser_mem_initializer_list): Check result of
        cp_parser_mem_initializer against error_mark_node, not NULL_TREE.
        (cp_parser_mem_initializer): Return error_mark_node for failure.
        PR c++/25634
        * parser.c (cp_parser_template_parameter_list): Call
        begin_template_parm_list and end_template_parm_list here.
        (cp_parser_type_parameter): Not here.
        (cp_parser_template_declaration_after_export): Or here.
        (cp_parser_elaborated_type_specifier): Call
        cp_parser_check_template_parameters.
        * tree.c (build_target_expr_with_type): Use force_target_expr.
        PR c++/25635
        * g++.dg/parse/operator6.C: New test.
        PR c++/25637
        * g++.dg/parse/error29.C: New test.
        PR c++/25638
        * g++.dg/parse/dtor6.C: New test.
        PR c++/25633
        * g++.dg/parse/ctor3.C: New test.
        PR c++/25634
        * g++.dg/template/class3.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/parse/ctor3.C
    trunk/gcc/testsuite/g++.dg/parse/dtor6.C
    trunk/gcc/testsuite/g++.dg/parse/error29.C
    trunk/gcc/testsuite/g++.dg/parse/operator6.C
    trunk/gcc/testsuite/g++.dg/template/class3.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/friend.c
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/tree.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4 regression] Member definition in wrong scope accepted

[mmitchel at gcc dot gnu dot org]

------- Comment #5 from mmitchel at gcc dot gnu dot org  2006-01-03 08:47 -------
Fixed in 4.0.3.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mark at codesourcery dot com|unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW
            Summary|[3.4/4.0/4.1/4.2 regression]|[3.4 regression] Member
                   |Member definition in wrong  |definition in wrong scope
                   |scope accepted              |accepted


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4 regression] Member definition in wrong scope accepted

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.3                       |3.4.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637

[Bug c++/25637] [3.4 regression] Member definition in wrong scope accepted

[gdr at gcc dot gnu dot org]

------- Comment #6 from gdr at gcc dot gnu dot org  2006-03-01 05:09 -------
Fixed in 4.0.3 and up.


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.4.6                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25637