[Bug bootstrap/25672] [4.3/4.4?/4.5 regression] cross build's libgcc picks up CFLAGS

[Bug bootstrap/25672] [4.3/4.4?/4.5 regression] cross build's libgcc picks up CFLAGS

[pluto at agmk dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Pawel Sikora <pluto at agmk dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|ppc64-pld-linux             |x86_64-pc-mingw32
      Known to work|                            |
            Summary|[4.3 regression] cross      |[4.3/4.4?/4.5 regression]
                   |build's libgcc picks up     |cross build's libgcc picks
                   |CFLAGS                      |up CFLAGS
      Known to fail|                            |4.5.2

--- Comment #27 from Pawel Sikora <pluto at agmk dot net> 2010-09-26 17:21:01 UTC ---
this bug still exists on current 4.5 branch and probably on trunk.

e.g. for mingw64 cross compilation libgcc's configure fails with:
(...)
checking for suffix of object files... configure: error: in
`/home/users/pluto/rpm/BUILD/gcc-4.5.1/BUILDDIR/x86_64-pc-mingw32/libgcc':
configure: error: cannot compute suffix of object files: cannot compile

config.log contains:

(...)
configure:3020: /home/users/pluto/rpm/BUILD/gcc-4.5.1/BUILDDIR/./gcc/xgcc
-B/home/users/pluto/rpm/BUILD/gcc-4.5.1/BUILDDIR/./gcc/
-L/usr/x86_64-pc-mingw32/lib -L/usr/mingw/lib -isystem
/usr/x86_64-pc-mingw32/include -isystem /usr/mingw/include
-B/usr/x86_64-pc-mingw32/bin/ -B/usr/x86_64-pc-mingw32/lib/ -isystem
/usr/x86_64-pc-mingw32/include -isystem /usr/x86_64-pc-mingw32/sys-include   
-o conftest -g -O2 -fno-strict-aliasing -fwrapv -march=i686 -mtune=pentium4
-gdwarf-3 -g2    conftest.c  >&5
conftest.c:1:0: error: CPU you selected does not support x86-64 instruction set
conftest.c:1:0: error: CPU you selected does not support x86-64 instruction set
configure:3023: $? = 1

as you can see libgcc's configure uses CFLAGS (-O2 -fno-strict-aliasing -fwrapv
-march=i686 -mtune=pentium4 -gdwarf-3 -g2) passed to top-level configure script
:/

[Bug bootstrap/25672] [4.3/4.4?/4.5 regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #28 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:14:19 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug bootstrap/25672] [4.4?/4.5 regression] cross build's libgcc picks up CFLAGS

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.7                       |4.5.4

--- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 12:47:48 UTC ---
4.4 branch is being closed, moving to 4.5.4 target.

[Bug bootstrap/25672] [4.5 Regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
            Summary|[4.4?/4.5 regression] cross |[4.5 Regression] cross
                   |build's libgcc picks up     |build's libgcc picks up
                   |CFLAGS                      |CFLAGS

--- Comment #30 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-27 08:38:10 UTC ---
Does this bug prevail in GCC 4.6.x, 4.7.x and/or trunk?

[Bug bootstrap/25672] [4.5 Regression] cross build's libgcc picks up CFLAGS

[pluto at agmk dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #31 from Pawel Sikora <pluto at agmk dot net> 2012-03-27 18:39:37 UTC ---
(In reply to comment #30)
> Does this bug prevail in GCC 4.6.x, 4.7.x and/or trunk?

i've configured 4.7.0-RC2 for sparc64 target on x86_64 host with:

CFLAGS="-O1 -g0 -march=corei7-avx" ./configure....

and the build fails in libgcc as usual:

(...)
checking for sparc64-gnu-linux-gcc... 
/home/users/pluto/toolchain/trunk/sparc64-gnu-linux/gcc-4.7.0-RC-20120314/BUILDDIR/./gcc/xgcc
-B/home/users/pluto/toolchain/trunk/sparc64-gnu-linux/gcc-4.7.0-RC-20120314/BUILDDIR/./gcc/
-B/opt/gcc47-sparc64/sparc64-gnu-linux/bin/
-B/opt/gcc47-sparc64/sparc64-gnu-linux/lib/ -isystem
/opt/gcc47-sparc64/sparc64-gnu-linux/include -isystem
/opt/gcc47-sparc64/sparc64-gnu-linux/sys-include   
checking for suffix of object files... configure: error: in
`/home/users/pluto/toolchain/trunk/sparc64-gnu-linux/gcc-4.7.0-RC-20120314/BUILDDIR/sparc64-gnu-linux/libgcc':
configure: error: cannot compute suffix of object files: cannot compile
See `config.log' for more details.
make: *** [configure-target-libgcc] Error 1

config.log says:

xgcc: error: unrecognized command line option '-march=corei7-avx'

so, the toplevel CFLAGS are pulled into target cflags.

[Bug bootstrap/25672] [4.6/4.7/4.8 Regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Target Milestone|4.5.4                       |4.6.4
            Summary|[4.5 Regression] cross      |[4.6/4.7/4.8 Regression]
                   |build's libgcc picks up     |cross build's libgcc picks
                   |CFLAGS                      |up CFLAGS

--- Comment #32 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-02 09:25:39 UTC ---
The 4.5 branch is being closed.

[Bug bootstrap/25672] [4.6/4.7/4.8 Regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #33 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-15 15:02:54 UTC ---
Re-confirmed on the 4.7 branch.  configury now has

# During gcc bootstrap, if we use some random cc for stage1 then CFLAGS
# might be empty or "-g".  We don't require a C++ compiler, so CXXFLAGS
# might also be empty (or "-g", if a non-GCC C++ compiler is in the path).
# We want to ensure that TARGET libraries (which we know are built with
# gcc) are built with "-O2 -g", so include those options when setting
# CFLAGS_FOR_TARGET and CXXFLAGS_FOR_TARGET.
if test "x$CFLAGS_FOR_TARGET" = x; then
  CFLAGS_FOR_TARGET=$CFLAGS
  case " $CFLAGS " in
    *" -O2 "*) ;;
    *) CFLAGS_FOR_TARGET="-O2 $CFLAGS" ;;
  esac
  case " $CFLAGS " in
    *" -g "* | *" -g3 "*) ;;
    *) CFLAGS_FOR_TARGET="-g $CFLAGS" ;;
  esac
fi
AC_SUBST(CFLAGS_FOR_TARGET)
...
(likewise CXXFLAGS_FOR_TARGET)

but substituting CFLAGS here is certainly wrong.  The above seems to be
overeagerly trying to honor CFLAGS more broadly as a convenience.  But
doing so when build != target looks wrong.

As alternative it should be documented that CFLAGS also applies to
target libraries unless CFLAGS_FOR_TARGET is set.

[Bug bootstrap/25672] [4.7/4.8/4.9 Regression] cross build's libgcc picks up CFLAGS

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.4                       |4.7.4

--- Comment #34 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:16:54 UTC ---
GCC 4.6.4 has been released and the branch has been closed.

[Bug bootstrap/25672] [4.7/4.8/4.9/4.10 Regression] cross build's libgcc picks up CFLAGS

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #36 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Oleg Endo from comment #35)
> Just ran into the same issue with trunk r210305, while building a cross SH
> on OSX.  The newly merged wide-int code contains some things, which clang
> considers an error.  Setting
> export CFLAGS="-fheinous-gnu-extensions"
> export CXXFLAGS="-fheinous-gnu-extensions"
> 
> fixes that, but then one need also to set e.g.
> export CFLAGS_FOR_TARGET="-O2"
> export CXXFLAGS_FOR_TARGET="-O2"
> 
> or else -fheinous-gnu-extensions will be passed to the xgcc.
> This really should be documented somewhere...

Can you file a bug about these errors?  Are we sure it is a gnu extension issue
or just clang thinks it is a gnu extension.

[Bug bootstrap/25672] [4.7/4.8/4.9/4.10 Regression] cross build's libgcc picks up CFLAGS

[olegendo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #37 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #36)
> Can you file a bug about these errors?

PR 61146

> Are we sure it is a gnu extension
> issue or just clang thinks it is a gnu extension.

No idea, I haven't looked into the details.

[Bug bootstrap/25672] [4.7/4.8/4.9/4.10 Regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.4

--- Comment #38 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.

[Bug bootstrap/25672] [4.8/4.9/5 Regression] cross build's libgcc picks up CFLAGS

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #39 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug bootstrap/25672] [4.8/4.9/5 Regression] cross build's libgcc picks up CFLAGS

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |aldyh at gcc dot gnu.org

--- Comment #40 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
I'll take a look.

[Bug bootstrap/25672] [4.8/4.9/5 Regression] cross build's libgcc picks up CFLAGS

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #41 from Oleg Endo <olegendo at gcc dot gnu.org> ---
That's nice!  While you're at it, could you maybe also have a look at PR 53579?
 It sounds like a similar issue...

[Bug bootstrap/25672] [4.8/4.9/5 Regression] cross build's libgcc picks up CFLAGS

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #42 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Author: aldyh
Date: Tue Mar 10 16:37:53 2015
New Revision: 221326

URL: https://gcc.gnu.org/viewcvs?rev=221326&root=gcc&view=rev
Log:
    PR bootstrap/25672
    * configure.ac: Do not initialize CFLAGS_FOR_TARGET from CFLAGS if
    cross-compiling.  Similarly for CXX_FOR_TARGET.
    * configure: Regenerate.

Modified:
    trunk/ChangeLog
    trunk/configure
    trunk/configure.ac

[Bug bootstrap/25672] [4.8/4.9 Regression] cross build's libgcc picks up CFLAGS

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.8/4.9/5 Regression]      |[4.8/4.9 Regression] cross
                   |cross build's libgcc picks  |build's libgcc picks up
                   |up CFLAGS                   |CFLAGS

--- Comment #43 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Fixed in mainline.  Adjusting subject to indicate that this is no longer a GCC
5 regression.

[Bug bootstrap/25672] [4.8/4.9 Regression] cross build's libgcc picks up CFLAGS

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #44 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug bootstrap/25672] [4.9 Regression] cross build's libgcc picks up CFLAGS

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

--- Comment #45 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug bootstrap/25672] [4.9 Regression] cross build's libgcc picks up CFLAGS

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25672

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4