[Bug c/25802] New: VM types of external and internal linkage variables not diagnosed

[Bug c/25802] New: VM types of external and internal linkage variables not diagnosed

[jsm28 at gcc dot gnu dot org]

GCC doesn't diagnose function-scope VM declarations of variables with external
or internal linkage.  (VM declarations of function-local statics are OK.)  Four
tests (all should be rejected unconditionally, none are even with -std=c99
-pedantic-errors):

extern int (*a)[];
void f(int b) { extern int (*a)[b]; }

static int (*a)[];
void f(int b) { extern int (*a)[b]; }

extern int (*a)[];
void f(int b) { typedef int (*T)[b]; extern T a; }

static int (*a)[];
void f(int b) { typedef int (*T)[b]; extern T a; }


-- 
           Summary: VM types of external and internal linkage variables not
                    diagnosed
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
OtherBugsDependingO 16989
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-01-16 01:19 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-16 01:19:09
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[mrs at apple dot com]

------- Comment #2 from mrs at apple dot com  2006-05-06 21:24 -------
I have a fix for this, will post.


-- 

mrs at apple dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrs at apple dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[mrs at gcc dot gnu dot org]

------- Comment #3 from mrs at gcc dot gnu dot org  2006-05-18 18:22 -------
Subject: Bug 25802

Author: mrs
Date: Thu May 18 18:22:12 2006
New Revision: 113888

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113888
Log:
        Fix up vla, vm and [*] sematics.

        PR c/18740
        PR c/7948
        PR c/25802
        * c-tree.h (struct c_arg_info): Add had_vla_unspec.
        (c_vla_unspec_p): Add.
        (c_vla_type_p): Add.
        * c-decl.c (struct c_scope): Add had_vla_unspec.
        (build_array_declarator): Add support for [*].
        (grokdeclarator): Likewise.
        (grokparms): Likewise.
        (get_parm_info): Likewise.
        * c-objc-common.c (c_vla_unspec_p): Likewise.
        * c-objc-common.h (LANG_HOOKS_TREE_INLINING_VAR_MOD_TYPE_P): Likewise.
        * c-parser.c (c_parser_typeof_specifier): Evaluate arguments to
        typeof when argument is a variably modified type not inside sizeof or
alignof.
        (c_parser_direct_declarator_inner): Propagate errors.
        (c_parser_sizeof_expression): Add support for [*].
        * c-typeck.c (c_vla_type_p): Add.
        (composite_type): Add support for vla compositing.
        (comptypes_internal): Add support for vla compatibility.
        (c_expr_sizeof_expr): Evaluate vla arguments.
        * tree.c (variably_modified_type_p): Update comment for [*].

testsuite:
        * gcc.dg/c90-arraydecl-1.c: Update for vla, vm [*] fixups.
        * gcc.dg/vla-4.c: Add.
        * gcc.dg/vla-5.c: Add.
        * gcc.dg/vla-6.c: Add.

Added:
    trunk/gcc/testsuite/gcc.dg/vla-4.c
    trunk/gcc/testsuite/gcc.dg/vla-5.c
    trunk/gcc/testsuite/gcc.dg/vla-6.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-decl.c
    trunk/gcc/c-objc-common.c
    trunk/gcc/c-objc-common.h
    trunk/gcc/c-parser.c
    trunk/gcc/c-tree.h
    trunk/gcc/c-typeck.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/c90-arraydecl-1.c
    trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[mrs at apple dot com]

------- Comment #4 from mrs at apple dot com  2006-05-18 19:29 -------
aka radr://4336222


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[jsm28 at gcc dot gnu dot org]

------- Comment #5 from jsm28 at gcc dot gnu dot org  2006-06-04 17:03 -------
Fixed for 4.2.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802

[Bug c/25802] VM types of external and internal linkage variables not diagnosed

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-09-19 03:33 -------
*** Bug 29126 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |neil at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25802