[Bug tree-optimization/25918] New: gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[Bug tree-optimization/25918] New: gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[jsm28 at gcc dot gnu dot org]

The following appeared on mainline on ia64-hp-hpux11.23 (both -milp32 and
-mlp64) between 20060118 (revision 109876) and 20060121 (revision 110062),
probably when these tests were added.

FAIL: gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops
1
FAIL: gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2
loops 1


-- 
           Summary: gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times
                    vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-
                    2.c scan-tree-dump-times vectorized 2 loops 1 fail
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[dorit at il dot ibm dot com]

------- Comment #1 from dorit at il dot ibm dot com  2006-01-26 09:07 -------
Can you please send the dump files generated by -fdump-tree-vect-details?

reduc-dot-s16.c needs the sdot_prodv4hi pattern, which is implemented for ia64,
so I'd expect one loop to be vectorized. I wonder what's the problem there.

In vect-reduc-pattern-2.c - does the vectorizer report vectorizing one loop?
The one loop (that sums shorts into and int accumulator) needs the
widen_ssumv4hi3 pattern to be vectorized, which is implemented for ia64. Does
that loop get vectorized?
The second loop however (that sums chars into and int accumulator) cannot be
vectorized on ia64 because the mode of the result of the widen_ssumv8qi3
pattern as implemented on ia64 in short, not int. If this is indeed the reason
for the failure we'd probably want to introduce finer keywords to represent the
available widening support (in target-supports.exp we currently have just a
"vect_widen_sum" keyword, which does not distinguish between char-to-short
summation and char-to-int summation).


-- 

dorit at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dorit at il dot ibm dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[jsm28 at gcc dot gnu dot org]

------- Comment #2 from jsm28 at gcc dot gnu dot org  2006-01-28 17:04 -------
Created an attachment (id=10747)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10747&action=view)
Dump file for vect-reduc-dot-s16.c, -mlp64.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[jsm28 at gcc dot gnu dot org]

------- Comment #3 from jsm28 at gcc dot gnu dot org  2006-01-28 17:05 -------
Created an attachment (id=10748)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10748&action=view)
Dump file for vect-reduc-pattern-2.c, -mlp64.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[wilson at gcc dot gnu dot org]

------- Comment #4 from wilson at gcc dot gnu dot org  2006-02-08 02:07 -------
The vect-reduc-dot-s16.c testcase fails because two loops were vectorized, and
we only expected one to be vectorized.

The problem here is that the loop in foo1 is not supposed to be recognized and
vectorized as a dot-product loop.  And it isn't, as expected.  However, on
IA-64, it is recognized and vectorized as a widen-sum loop.  This happens
because the IA-64 port defines the widen_ssumv4hi3 pattern.  The IA-64 port is
the only one that defines this pattern, and hence is probably the only port
"broken" here.  All others will presumably fail to vectorize this loop.

So the IA-64 port emits to the -fdump-tree-vect-details file
tmp.c:23: note: pattern recognized: prod_14 w+ result_3
tmp.c:23: note: vectorized 1 loops in function.
tmp.c:38: note: pattern recognized:  DOT_PROD_EXPR < D.2127_14 , D.2125_10 ...
tmp.c:38: note: vectorized 1 loops in function.
and the testcase fails because we only expected 1 loop to be vectorized.

I think the only thing wrong here is that the dg-final tests in the testcase
are not precise enough to handle this case.


-- 

wilson at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-02-08 02:07:47
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[wilson at gcc dot gnu dot org]

------- Comment #5 from wilson at gcc dot gnu dot org  2006-02-08 02:19 -------
Dorit's analysis of vect-reduc-pattern-2.c in comment #1 is correct.  The loop
that sums char into int is not vectorized, because the widen_ssumv8qi3 pattern
has the wrong output mode (HI instead of SI).  Dorit's suggested solution looks
reasonable to me.


-- 

wilson at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wilson at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[dorit at il dot ibm dot com]

------- Comment #6 from dorit at il dot ibm dot com  2006-02-08 14:17 -------
(In reply to comment #4)
> ... This happens
> because the IA-64 port defines the widen_ssumv4hi3 pattern.  The IA-64 port is
> the only one that defines this pattern, and hence is probably the only port
> "broken" here.  All others will presumably fail to vectorize this loop.

that's correct. it's actually a combination of being able to support
widen_ssumv4hi3 and (non widening) multiplication of shorts. looks like we need
to split these loops into separate testcases, and for this particular loop
expect vectorization if vect_widen_sum and vect_short_mult (new keyword) are
supported. 

> and the testcase fails because we only expected 1 loop to be vectorized.
> I think the only thing wrong here is that the dg-final tests in the testcase
> are not precise enough to handle this case.

indeed. Will take care of that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[dorit at il dot ibm dot com]

------- Comment #7 from dorit at il dot ibm dot com  2006-02-08 14:19 -------
(In reply to comment #5)
Will take care of that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[victork at il dot ibm dot com]

------- Comment #8 from victork at il dot ibm dot com  2006-02-14 12:16 -------
Created an attachment (id=10847)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10847&action=view)
[patch] for PR 25918 (autovect)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[victork at il dot ibm dot com]

------- Comment #9 from victork at il dot ibm dot com  2006-02-14 12:20 -------
Hello,

I've prepared a patch to the testsuite to make dg-final checks
more precise. The patch was tested on ppc64-yellowdog-linux.

I have no access to IA64 box. Could someone check this patch on ia64?
The patch can be found in "mainline.PR25918-2.patch.txt" attachment.

Thanks,
-- victor


2006-02-12  Victor Kaplansky  <victork@il.ibm.com>
        PR tree-opt/25918

        * lib/target-supports.exp
        (check_effective_target_vect_char_mult): New.
          (check_effective_target_vect_short_mult): New.
        (check_effective_target_vect_widen_sum_qi_to_si): New.
        (check_effective_target_vect_widen_sum_qi_to_hi): New.
        (check_effective_target_vect_widen_sum_hi_to_si): New.
        * gcc.dg/vect/vect-reduc-dot-s16.c: Remove, split into
        vect-reduc-dot-s16a.c and vect-reduc-dot-s16b.c
        * vect-reduc-dot-s16a.c: New, split from vect-reduc-dot-s16.c.
        * vect-reduc-dot-s16b.c: New, split from vect-reduc-dot-s16.c.
        * gcc.dg/vect/vect-reduc-pattern-2.c: Remove, split into
        vect-reduc-pattern-2a.c, vect-reduc-pattern-2b.c and
        vect-reduc-pattern-2c.c
        * gcc.dg/vect/vect-reduc-pattern-1.c: Remove, split into
        vect-reduc-pattern-1a.c, vect-reduc-pattern-1b.c and
        vect-reduc-pattern-1c.c


-- 

victork at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victork at il dot ibm dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[wilson at tuliptree dot org]

------- Comment #10 from wilson at tuliptree dot org  2006-02-14 23:41 -------
Subject: Re:  gcc.dg/vect/vect-reduc-dot-s16.c
        scan-tree-dump-times vectorized 1 loops 1 and
        gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2
loops
        1 fail

On Tue, 2006-02-14 at 04:20, victork at il dot ibm dot com wrote:
> I have no access to IA64 box. Could someone check this patch on ia64?
> The patch can be found in "mainline.PR25918-2.patch.txt" attachment.

The vect-reduc-dot-s16a.c file has a bug.  It is missing a declaration
for the local variable dot.  I added a "int dot;" line to that test.

I did "make check-gcc RUNTESTFLAGS=vect.exp".  Without the patch, I get
two unexpected failures.  With the patch, I get no unexpected failures.
So the patch works fine for me on an ia64-linux system.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug tree-optimization/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[victork at gcc dot gnu dot org]

------- Comment #11 from victork at gcc dot gnu dot org  2006-02-16 09:59 -------
Subject: Bug 25918

Author: victork
Date: Thu Feb 16 09:59:00 2006
New Revision: 111135

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111135
Log:
testsuite/
2006-02-16  Victor Kaplansky  <victork@il.ibm.com>

        PR tree-opt/25918
        * lib/target-supports.exp
        (check_effective_target_vect_short_mult): New.
        (check_effective_target_vect_char_mult): New.
        (check_effective_target_vect_widen_sum_qi_to_si): New.
        (check_effective_target_vect_widen_sum_qi_to_hi): New.
        (check_effective_target_vect_widen_sum_hi_to_si): New.
        * gcc.dg/vect/vect-reduc-dot-s16.c: Remove, split into
        vect-reduc-dot-s16a.c and vect-reduc-dot-s16b.c
        * vect-reduc-dot-s16a.c: New, split from vect-reduc-dot-s16.c.
        * vect-reduc-dot-s16b.c: New, split from vect-reduc-dot-s16.c.
        * gcc.dg/vect/vect-reduc-pattern-2.c: Remove, split into
        vect-reduc-pattern-2a.c, vect-reduc-pattern-2b.c and
        vect-reduc-pattern-2c.c
        * gcc.dg/vect/vect-reduc-pattern-1.c: Remove, split into
        vect-reduc-pattern-1a.c, vect-reduc-pattern-1b.c and
        vect-reduc-pattern-1c.c

Added:
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s16a.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s16b.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-1a.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-1b.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-1c.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-2a.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-2b.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-2c.c
    trunk/gcc/testsuite/gcc.dg/vect/wrapv-vect-reduc-pattern-2c.c
Removed:
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s16.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-1.c
    trunk/gcc/testsuite/gcc.dg/vect/vect-reduc-pattern-2.c
    trunk/gcc/testsuite/gcc.dg/vect/wrapv-vect-reduc-pattern-2.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/target-supports.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918

[Bug testsuite/25918] gcc.dg/vect/vect-reduc-dot-s16.c scan-tree-dump-times vectorized 1 loops 1 and gcc.dg/vect/vect-reduc-pattern-2.c scan-tree-dump-times vectorized 2 loops 1 fail

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2006-02-16 17:43 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
          Component|tree-optimization           |testsuite
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25918