[Bug c++/25973] [4.3/4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[Bug c++/25973] [4.3/4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:13:05 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[vries at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #11 from vries at gcc dot gnu.org 2011-11-22 14:51:37 UTC ---
I can't reproduce the problem from the description with 4.7, but I can
reproduce the problem from comment 4 with 4.7.

Tentative patch for test-case from comment 4:
...
Index: gcc/gimple-low.c
===================================================================
--- gcc/gimple-low.c (revision 181172)
+++ gcc/gimple-low.c (working copy)
@@ -680,6 +680,12 @@ block_may_fallthru (const_tree block)
     case CLEANUP_POINT_EXPR:
       return block_may_fallthru (TREE_OPERAND (stmt, 0));

+    case DO_STMT:
+      /* DO_STMT is part of cp-tree.def, so this should be moved to a
+     cp-specific file.  */
+      /* If DO_BODY doesn't fall thru, then DO_STMT doesn't either.  */
+      return block_may_fallthru (TREE_OPERAND (stmt, 1));
+      
     default:
       return true;
     }
...

Perhaps we should file a separate bug for the test-case from comment 4.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gcc-bugs at gcc dot gnu.org |paolo.carlini at oracle dot
                   |                            |com

--- Comment #12 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-21 01:16:57 UTC ---
Tom, are you handling this?

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[vries at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

--- Comment #13 from vries at gcc dot gnu.org 2012-01-21 11:34:08 UTC ---
Created attachment 26402
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26402
patch to fix problem in comment 4

(In reply to comment #12)
> Tom, are you handling this?

I submitted a more elaborate version of the patch in comment 11 at
http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00649.html.

Richard Guenther suggested a different way to handle this, and this patch is an
attempt at that.

I tested an earlier version of this patch without any problems, I just need to
retest and submit.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

--- Comment #14 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-21 11:57:42 UTC ---
Great, thanks. I would recommend trying to do that before Stage 3 ends.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

--- Comment #15 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-21 22:50:40 UTC ---
Well, actually Stage 3 ended while I was in vacations. Sorry about the
misleading note.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|paolo.carlini at oracle dot |
                   |com, vries at gcc dot       |
                   |gnu.org                     |
         AssignedTo|unassigned at gcc dot       |vries at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #16 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-23 13:42:44 UTC ---
Assigning then.

[Bug c++/25973] [4.4/4.5/4.6/4.7 Regression] Wrong warning: control reaches end of non-void function

[vries at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

--- Comment #17 from vries at gcc dot gnu.org 2012-01-23 14:04:07 UTC ---
> I tested an earlier version of this patch without any problems, I just need to
> retest and submit.

Submitted patch: http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01071.html

[Bug c++/25973] [4.5/4.6/4.7/4.8 Regression] Wrong warning: control reaches end of non-void function

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.7                       |4.5.4

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 12:45:55 UTC ---
4.4 branch is being closed, moving to 4.5.4 target.

[Bug c++/25973] [4.5/4.6/4.7/4.8 Regression] Wrong warning: control reaches end of non-void function

[vries at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
         AssignedTo|vries at gcc dot gnu.org    |unassigned at gcc dot
                   |                            |gnu.org

--- Comment #19 from vries at gcc dot gnu.org 2012-04-24 08:52:03 UTC ---
Problem in comment 4 fixed in 4.8: r186546.

Un-assigning myself for problem in description field.

[Bug c++/25973] [4.5/4.6/4.7/4.8 Regression] Wrong warning: control reaches end of non-void function

[ssomers at opnet dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

ssomers at opnet dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from ssomers at opnet dot com 2012-04-24 09:57:33 UTC ---
I concur with comment 11 that the original problem doesn't occur anymore in
4.4.4 (it still occurred in 4.1.2). Since the variation in comment 4 was also
patched, and being unaware about the protocol, I'll go out on a limp and try to
close this.

[Bug c++/25973] [4.5/4.6/4.7/4.8 Regression] Wrong warning: control reaches end of non-void function

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25973

--- Comment #21 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-04-24 10:30:45 UTC ---
Noone cares about 4.4 bugs now, that release has reached end-of-life, but the
problem isn't fixed in 4.5, 4.6 or 4.7 so this isn't FIXED