[Bug fortran/26038] New: FORTRAN segfault

[Bug fortran/26038] New: FORTRAN segfault

[hjl at lucon dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

[hjl@gnu-16 cpu2006]$ cat foo.f90
   subroutine foo(self)
    character(*) :: self
      pointer :: self
      allocate(self)
   end subroutine
[hjl@gnu-16 cpu2006]$ /usr/gcc-4.2/bin/gcc -S foo.f90 -m32
foo.f90: In function ‘foo’:
foo.f90:4: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-16 cpu2006]$ /usr/gcc-4.2/bin/gcc --version
gcc (GCC) 4.2.0 20060119 (experimental) [trunk revision 109972 clean]


-- 
           Summary: FORTRAN segfault
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2006-01-30 22:39 -------
It happens on gcc 4.2, 4.1 and 4.0. But gcc-4.1-redhat is fine:

[hjl@gnu-16 cpu2006]$ /usr/gcc-4.1-redhat/bin/gcc -S foo.f90 -O2
[hjl@gnu-16 cpu2006]$ /usr/gcc-4.1-redhat/bin/gcc --version
gcc (GCC) 4.1.0 20060128 (Red Hat 4.1.0-0.17) [redhat/gcc-4_1-branch revision
110368 clean]


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-01-30 23:48 -------
This code is meaning less as far as I can tell but it is accepted by Lahey's
compilers.

Oh don't try redhat's branch please it is not something that is just wrong to
do with a modifed compiler at least in bug reports. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-01-30 23:59 -------
If I change the program to use a constant size string, it works.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |19276
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[hjl at lucon dot org]

------- Comment #4 from hjl at lucon dot org  2006-01-31 00:45 -------
This code is extracted from a much larger program. Intel FORTRAN compiler
has no problem with it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

Re: [Bug fortran/26038] FORTRAN segfault

[Andrew Pinski]

> 
> 
> 
> ------- Comment #4 from hjl at lucon dot org  2006-01-31 00:45 -------
> This code is extracted from a much larger program. Intel FORTRAN compiler
> has no problem with it.

And what should it allocate a zero sized string?

-- Pinski

Re: [Bug fortran/26038] FORTRAN segfault

[Andrew Pinski]

On Jan 30, 2006, at 7:45 PM, hjl at lucon dot org wrote:
> Intel FORTRAN compiler has no problem with it.

Intel's Fortran compiler does not detect a lot of
invalid code, that does not make this code valid.

-- Pinski

[Bug fortran/26038] FORTRAN segfault

[pinskia at physics dot uc dot edu]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-01-31 00:59 -------
Subject: Re:  FORTRAN segfault

> 
> 
> 
> ------- Comment #4 from hjl at lucon dot org  2006-01-31 00:45 -------
> This code is extracted from a much larger program. Intel FORTRAN compiler
> has no problem with it.

And what should it allocate a zero sized string?

-- Pinski


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[pinskia at physics dot uc dot edu]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-01-31 01:15 -------
Subject: Re:  FORTRAN segfault


On Jan 30, 2006, at 7:45 PM, hjl at lucon dot org wrote:
> Intel FORTRAN compiler has no problem with it.

Intel's Fortran compiler does not detect a lot of
invalid code, that does not make this code valid.

-- Pinski


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[hjl at lucon dot org]

------- Comment #7 from hjl at lucon dot org  2006-01-31 01:52 -------
The original code looks like

   subroutine foo(self)
    character(*) :: self
      pointer :: self
      nullify(self)
      allocate(self)
      self = " "
   end subroutine

Is this code valid? How can I make it valid?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] FORTRAN segfault

[eedelman at gcc dot gnu dot org]

------- Comment #8 from eedelman at gcc dot gnu dot org  2006-01-31 11:12 -------
(In reply to comment #7)
> The original code looks like
> 
>    subroutine foo(self)
>     character(*) :: self
>       pointer :: self
>       nullify(self)
>       allocate(self)
>       self = " "
>    end subroutine
> 
> Is this code valid? How can I make it valid?

I think it's valid.  

(The length of 'self', which is needed at allocation, should be passed to foo
by the caller.  For example, the code below should print 
5
10
on execution:

-----------
module moo

contains

    subroutine foo(self)
        character(*) :: self
        pointer :: self

        nullify(self)
        allocate(self)
        print *, len(self)
    end subroutine

end module moo


program hum

    use moo

    character(5), pointer :: p
    character(10), pointer :: q

    call foo(p)
    call foo(q)

end program hum
-----------------
)


-- 

eedelman at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-31 11:12:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[paul dot richard dot thomas at cea dot fr]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]



------- Comment #9 from paul dot richard dot thomas at cea dot fr  2006-01-31 12:58 -------
If you look at the code produced by this final example, the 2nd argument of
_gfc_allocate is null.  This comes about because the TYPE_SIZE_UNIT that Jakub
hated me setting directly is a NULL_TREE.  I suspect that his patch will fix
this.  Otherwise, this works and will be submitted tonight:

Index: gcc/fortran/trans-stmt.c
===================================================================
--- gcc/fortran/trans-stmt.c    (révision 110394)
+++ gcc/fortran/trans-stmt.c    (copie de travail)
@@ -3254,8 +3254,12 @@
          val = gfc_create_var (ppvoid_type_node, "ptr");
          tmp = gfc_build_addr_expr (ppvoid_type_node, se.expr);
          gfc_add_modify_expr (&se.pre, val, tmp);
-
-         tmp = TYPE_SIZE_UNIT (TREE_TYPE (TREE_TYPE (se.expr)));
+
+         tmp = TYPE_SIZE_UNIT (TREE_TYPE (TREE_TYPE (se.expr)));
+
+         if (expr->ts.type == BT_CHARACTER && tmp == NULL_TREE)
+           tmp = se.string_length;
+
          parm = gfc_chainon_list (NULL_TREE, val);
          parm = gfc_chainon_list (parm, tmp);
          parm = gfc_chainon_list (parm, pstat);

This results in the hidden charlen dummy argument being passed to the library
allocate.

Hah! I just undid the above and applied Jakub's patch; as I suspected it fixes
the bug and produces the following code:

foo (self, _self)
{
  bit_size_type D.802;
  <unnamed type> D.803;

  D.802 = (bit_size_type) (<unnamed type>) _self * 8;
  D.803 = (<unnamed type>) _self;
  *self = 0B;
  {
    void * * ptr.0;

    ptr.0 = (void * *) self;
    _gfortran_allocate (ptr.0, (<unnamed type>) _self, 0);
  }
  {
    struct __st_parameter_dt dt_parm.1;

    dt_parm.1.common.filename = "pr26038.f90";
    dt_parm.1.common.line = 10;
    dt_parm.1.common.unit = 6;
    dt_parm.1.common.flags = 128;
    _gfortran_st_write (&dt_parm.1);
    {
      int4 D.801;

      D.801 = _self;
      _gfortran_transfer_integer (&dt_parm.1, &D.801, 4);
    }
    _gfortran_st_write_done (&dt_parm.1);
  }
}


MAIN__ ()
{
  char[1:10] * q;
  char[1:5] * p;

  foo (&p, 5);
  foo (&q, 10);
}

I will email Jakub to let him know.  Perhaps the trick will be to apply his
pre-gomp patch to 4.2 and mine to 4.1?

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[hjl at lucon dot org]

------- Comment #10 from hjl at lucon dot org  2006-01-31 15:21 -------
I can't verify if the whole program compiles correctly due to PR 26041.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2006-02-09 23:23 -------
Subject: Bug 26038

Author: pault
Date: Thu Feb  9 23:23:28 2006
New Revision: 110816

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110816
Log:
2006-02-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26038
        * trans-stmt.c (gfc_trans_allocate): Provide assumed character length
        scalar with missing backend_decl for the hidden dummy charlen.

        PR fortran/25059
        * interface.c (gfc_extend_assign): Remove detection of non-PURE
        subroutine in assignment interface, with gfc_error, and put it in
        * resolve.c (resolve_code).

        PR fortran/25070
        * interface.c (gfc_procedure_use): Flag rank checking for non-
        elemental, contained or interface procedures in call to
        (compare_actual_formal), where ranks are checked for assumed
        shape arrays..

2006-02-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26038
        * gfortran.dg/allocate_char_star_scalar_1.f90: New test.

        PR fortran/25059
        * gfortran.dg/impure_assignment_1.f90: New test.

        PR fortran/25070
        * gfortran.dg/assumed_shape_ranks_1.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/allocate_char_star_scalar_1.f90
    trunk/gcc/testsuite/gfortran.dg/assumed_shape_ranks_1.f90
    trunk/gcc/testsuite/gfortran.dg/impure_assignment_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[pault at gcc dot gnu dot org]

------- Comment #12 from pault at gcc dot gnu dot org  2006-02-13 19:32 -------
Subject: Bug 26038

Author: pault
Date: Mon Feb 13 19:32:02 2006
New Revision: 110921

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110921
Log:
2006-02-13  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26038
        * trans-stmt.c (gfc_trans_allocate): Provide assumed character length
        scalar with missing backend_decl for the hidden dummy charlen.

        PR fortran/25059
        * interface.c (gfc_extend_assign): Remove detection of non-PURE
        subroutine in assignment interface, with gfc_error, and put it in
        * resolve.c (resolve_code).

        PR fortran/25070
        * interface.c (gfc_procedure_use): Flag rank checking for non-
        elemental, contained or interface procedures in call to
        (compare_actual_formal), where ranks are checked for assumed
        shape arrays..

2006-02-13  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/26038
        * gfortran.dg/allocate_char_star_scalar_1.f90: New test.

        PR fortran/25059
        * gfortran.dg/impure_assignment_1.f90: New test.

        PR fortran/25070
        * gfortran.dg/assumed_shape_ranks_1.f90: New test.

Added:
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/allocate_char_star_scalar_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/assumed_shape_ranks_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/impure_assignment_1.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/interface.c
    branches/gcc-4_1-branch/gcc/fortran/resolve.c
    branches/gcc-4_1-branch/gcc/fortran/trans-stmt.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[pault at gcc dot gnu dot org]

------- Comment #13 from pault at gcc dot gnu dot org  2006-02-13 19:35 -------
fixed on trunk and 4.1.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038

[Bug fortran/26038] ICE on allocation of assumed length CHARACTER dummy.

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26038