[Bug other/26184] New: memory leaks in swing modulo scheduling function

[Bug other/26184] New: memory leaks in swing modulo scheduling function

[uttamp at us dot ibm dot com]

Hi,

Found following memory leaks in modulo-sched.c
In function, sms_schedule(), memory allocated and pointed by g_arr is not
freed.
In function  sms_schedule_by_order(), sbitmap memory allocated and pointed by
must_precede, must_follow and tobe_scheduled respectively, not freed.


-- 
           Summary: memory leaks in swing modulo scheduling function
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: uttamp at us dot ibm dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184

[Bug other/26184] memory leaks in swing modulo scheduling function

[uttamp at us dot ibm dot com]

------- Comment #1 from uttamp at us dot ibm dot com  2006-02-08 22:43 -------
I missed another memory leak in the same file, in function 
generate_reg_moves(),
memory pointed by uses_of_defs is not freed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184

[Bug other/26184] memory leaks in swing modulo scheduling function

[uttamp at us dot ibm dot com]

------- Comment #2 from uttamp at us dot ibm dot com  2006-02-08 22:44 -------
I'll submit a patch to fix these leaks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184

[Bug rtl-optimization/26184] memory leaks in swing modulo scheduling function

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-02-09 00:34 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|other                       |rtl-optimization
     Ever Confirmed|0                           |1
           Keywords|                            |memory-hog
   Last reconfirmed|0000-00-00 00:00:00         |2006-02-09 00:34:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184

[Bug rtl-optimization/26184] memory leaks in swing modulo scheduling function

[dje at gcc dot gnu dot org]

------- Comment #4 from dje at gcc dot gnu dot org  2006-02-15 19:33 -------
Subject: Bug 26184

Author: dje
Date: Wed Feb 15 19:33:33 2006
New Revision: 111114

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111114
Log:
2006-02-15  Uttam Pawar  <uttamp@us.ibm.com>

        PR rtl-optimization/26184
        * modulo-sched.c (generate_reg_moves): Free bitmap vector
        uses_of_defs.
        * modulo-sched.c (sms_schedule): Free g_arr pointer.
        * modulo-sched.c (sms_schedule_by_order): Free bitmap pointers
        must_precede, must_follow and tobe_scheduled.

        PR other/26147
        * opts.c (common_handle_option): Free new_option pointer.
        * df-core.c (df_analyze): Free postorder pointer.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/df-core.c
    trunk/gcc/modulo-sched.c
    trunk/gcc/opts.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184

[Bug rtl-optimization/26184] memory leaks in swing modulo scheduling function

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-02-15 23:04 -------
Fixed.
Just for future reference you can do the changelog like:

        * modulo-sched.c (generate_reg_moves): Free bitmap vector
        uses_of_defs.
        (sms_schedule): Free g_arr pointer.
        (sms_schedule_by_order): Free bitmap pointers must_precede,
        must_follow and tobe_scheduled.

In that the file which is referenced is the same you don't need to name it
again.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26184