[Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[laurent at guerby dot net]

Happens on x86 and x86_64-linux, was working 20060314

/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/xgcc -c
-B/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/ -gnatws -O2
-I/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/testsuite/ada/acats/support
c34002a.adb

raised STORAGE_ERROR : stack overflow (or erroneous memory access)

/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/xgcc -c
-B/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/ -gnatws -O2
-I/home/guerby/work/gcc/build/build-head-20060321T234940/gcc/testsuite/ada/acats/support
c52005e.adb

raised STORAGE_ERROR : stack overflow (or erroneous memory access)
gnatmake: "c52005e.adb" compilation error


-- 
           Summary: [4.2 Regression] ACATS ICE c34002a c52005 spurious
                    storage_error
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[ebotcazou at gcc dot gnu dot org]

------- Comment #1 from ebotcazou at gcc dot gnu dot org  2006-03-22 10:32 -------
Not present on 20/03:
http://gcc.gnu.org/ml/gcc-testresults/2006-03/msg01368.html
Present on 21/03: http://gcc.gnu.org/ml/gcc-testresults/2006-03/msg01395.html


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-03-22 10:32:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[ebotcazou at gcc dot gnu dot org]

------- Comment #2 from ebotcazou at gcc dot gnu dot org  2006-03-22 19:27 -------
The 2 failures have been introduced by the following change:

2006-03-20  Jeff Law  <law@redhat.com>

        * tree-pass.h (pass_phi_only_copy_prop): Delete.
        (pass_phi_only_cprop): Declare.
        * passes.c (init_optimization_passes): Replace pass_phi_only_copy_prop
        with phi_only_cprop
        * tree-ssa-dom.c (degenerate_phi_result): New function.
        (remove_stmt_or_phi, get_lhs_or_phi_result): Likewise.
        (get_rhs_or_phi_arg, propagate_rhs_into_lhs): Likewise.
        (eliminate_const_or_copy, eliminate_degenerate_phis_1): Likewise.
        (eliminate_degenerate_phis): Likewise.
        (pass_phi_only_cprop): New pass descriptor.
        * tree-ssa-copy.c (init_copy_prop): Lose PHIS_ONLY argument and
        support code.  Callers updated.
        (execute_copy_prop, do_copy_prop): Likewise and corresponding changes.
        (store_copy_prop): Likewise.
        (do_phi_only_copy_prop, pass_phi_only_copy_prop): Remove.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[law at redhat dot com]

------- Comment #3 from law at redhat dot com  2006-03-27 17:53 -------
Separate issue than 26797.  Not sure how to fix yet, but it's definitely a
bug in the new code.

jeff


-- 

law at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |law at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-03-22 10:32:16         |2006-03-27 17:53:54
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[law at gcc dot gnu dot org]

------- Comment #4 from law at gcc dot gnu dot org  2006-03-28 15:35 -------
Subject: Bug 26796

Author: law
Date: Tue Mar 28 15:35:47 2006
New Revision: 112453

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112453
Log:
        PR tree-optimization/26796
        * tree-ssa-dom.c (propagate_rhs_into_lhs): Queue blocks which
        need EH edge cleanups rather than purging them immediately.
        (eliminate_degenerate_phis): Handle queued EH cleanups.



Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-dom.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[law at redhat dot com]

------- Comment #5 from law at redhat dot com  2006-03-28 15:38 -------
Subject: Re:  [4.2 Regression] ACATS ICE c34002a c52005
        spurious storage_error

On Wed, 2006-03-22 at 19:28 +0000, ebotcazou at gcc dot gnu dot org
wrote:
> 
> ------- Comment #2 from ebotcazou at gcc dot gnu dot org  2006-03-22 19:27 -------
> The 2 failures have been introduced by the following change:
> 
> 2006-03-20  Jeff Law  <law@redhat.com>
> 
>         * tree-pass.h (pass_phi_only_copy_prop): Delete.
>         (pass_phi_only_cprop): Declare.
>         * passes.c (init_optimization_passes): Replace pass_phi_only_copy_prop
>         with phi_only_cprop
>         * tree-ssa-dom.c (degenerate_phi_result): New function.
>         (remove_stmt_or_phi, get_lhs_or_phi_result): Likewise.
>         (get_rhs_or_phi_arg, propagate_rhs_into_lhs): Likewise.
>         (eliminate_const_or_copy, eliminate_degenerate_phis_1): Likewise.
>         (eliminate_degenerate_phis): Likewise.
>         (pass_phi_only_cprop): New pass descriptor.
>         * tree-ssa-copy.c (init_copy_prop): Lose PHIS_ONLY argument and
>         support code.  Callers updated.
>         (execute_copy_prop, do_copy_prop): Likewise and corresponding changes.
>         (store_copy_prop): Likewise.
>         (do_phi_only_copy_prop, pass_phi_only_copy_prop): Remove.

The problem is that phi-cprop managed to perform some propagations
which ultimately led it to proving certain EH edges were not executable.

So we dutifully purged the EH edges, which in turn wiped out the
dominator tree.  Opps.  I wasn't aware of that little tidbit
(forwprop doesn't use the DOM tree, so it doesn't have this
issue).

As it turns out DOM already has a mechanism to deal with queued
blocks needing EH edge cleanups.  So I tweaked the phi-cprop
pass to use that existing mechanism.

Bootstrapped and regression tested on i686-pc-linux-gnu (ada included).
Fixes c340002a and c52005.


------- Comment #6 from law at redhat dot com  2006-03-28 15:38 -------
Created an attachment (id=11137)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11137&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796

[Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error

[ebotcazou at gcc dot gnu dot org]

------- Comment #7 from ebotcazou at gcc dot gnu dot org  2006-03-30 06:39 -------
Jeff, please put PR numbers in your ChangeLog entries, thanks.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|law at gcc dot gnu dot org  |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796