public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/27388] New: omp_is_private issues
@ 2006-05-02 14:19 jakub at gcc dot gnu dot org
2006-05-02 14:38 ` [Bug middle-end/27388] " jakub at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-05-02 14:19 UTC (permalink / raw)
To: gcc-bugs
void
foo (void)
{
int i;
i = 0;
#pragma omp parallel shared (i)
{
#pragma omp master
i++;
#pragma omp parallel for
for (i = 0; i < 10; i++)
;
}
}
results in very weird omplower dump:
1) #pragma omp parallel shared(iD.1922) private(iD.1922)
for the outer parallel
(surely we don't want i being shared and private at the same time,
just shared here)
2) #pragma omp parallel shared(iD.1922)
for the inner parallel - in this case i certainly ought to be private,
not shared
I think 1) is caused by n->value = GOVD_PRIVATE; messing up outer context,
while 2) probably because omp_is_private shouldn't recurse over is_parallel
contexts.
--
Summary: omp_is_private issues
Product: gcc
Version: 4.2.0
Status: UNCONFIRMED
Keywords: openmp
Severity: normal
Priority: P3
Component: middle-end
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jakub at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/27388] omp_is_private issues
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
@ 2006-05-02 14:38 ` jakub at gcc dot gnu dot org
2006-05-02 22:43 ` rth at gcc dot gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-05-02 14:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from jakub at gcc dot gnu dot org 2006-05-02 14:38 -------
Created an attachment (id=11360)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11360&action=view)
pr27388.patch
Something like this cures this but I'm really not sure what exactly is
omp_is_private supposed to do. Richard, can you please look at this?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/27388] omp_is_private issues
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
2006-05-02 14:38 ` [Bug middle-end/27388] " jakub at gcc dot gnu dot org
@ 2006-05-02 22:43 ` rth at gcc dot gnu dot org
2006-05-03 1:45 ` rth at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rth at gcc dot gnu dot org @ 2006-05-02 22:43 UTC (permalink / raw)
To: gcc-bugs
--
rth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |rth at gcc dot gnu dot org
|dot org |
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-05-02 22:43:25
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/27388] omp_is_private issues
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
2006-05-02 14:38 ` [Bug middle-end/27388] " jakub at gcc dot gnu dot org
2006-05-02 22:43 ` rth at gcc dot gnu dot org
@ 2006-05-03 1:45 ` rth at gcc dot gnu dot org
2006-05-04 6:34 ` jakub at gcc dot gnu dot org
2006-05-04 9:34 ` jakub at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: rth at gcc dot gnu dot org @ 2006-05-03 1:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from rth at gcc dot gnu dot org 2006-05-03 01:45 -------
omp_is_private is supposed to prevent extra PRIVATE clauses from being added
when they're not needed -- since each PRIVATE clause results in a new decl
being created.
I believe your patch is correct.
--
rth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rth at gcc dot gnu dot org |jakub at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/27388] omp_is_private issues
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
` (2 preceding siblings ...)
2006-05-03 1:45 ` rth at gcc dot gnu dot org
@ 2006-05-04 6:34 ` jakub at gcc dot gnu dot org
2006-05-04 9:34 ` jakub at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-05-04 6:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from jakub at gcc dot gnu dot org 2006-05-04 06:34 -------
Subject: Bug 27388
Author: jakub
Date: Thu May 4 06:34:06 2006
New Revision: 113514
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113514
Log:
PR middle-end/27388
* gimplify.c (omp_is_private): If var is shared in some outer context,
return false instead of true. Stop searching on parallel context
boundary.
* gcc.dg/gomp/pr27388-1.c: New test.
* gcc.dg/gomp/pr27388-2.c: New test.
* gcc.dg/gomp/pr27388-3.c: New test.
Added:
trunk/gcc/testsuite/gcc.dg/gomp/pr27388-1.c
trunk/gcc/testsuite/gcc.dg/gomp/pr27388-2.c
trunk/gcc/testsuite/gcc.dg/gomp/pr27388-3.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gimplify.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug middle-end/27388] omp_is_private issues
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
` (3 preceding siblings ...)
2006-05-04 6:34 ` jakub at gcc dot gnu dot org
@ 2006-05-04 9:34 ` jakub at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-05-04 9:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from jakub at gcc dot gnu dot org 2006-05-04 09:34 -------
Fixed in SVN.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27388
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-04 9:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-02 14:19 [Bug middle-end/27388] New: omp_is_private issues jakub at gcc dot gnu dot org
2006-05-02 14:38 ` [Bug middle-end/27388] " jakub at gcc dot gnu dot org
2006-05-02 22:43 ` rth at gcc dot gnu dot org
2006-05-03 1:45 ` rth at gcc dot gnu dot org
2006-05-04 6:34 ` jakub at gcc dot gnu dot org
2006-05-04 9:34 ` jakub at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).