public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/27946]  New: double to long long and back to double stores to the stack
@ 2006-06-08  5:00 pinskia at gcc dot gnu dot org
  2006-06-23  1:42 ` [Bug middle-end/27946] " pinskia at gcc dot gnu dot org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-08  5:00 UTC (permalink / raw)
  To: gcc-bugs

Testcase:
void f(double a, double *b)
{
  long long c = a;
  *b = c;
}

-----
We currently get:
_f:
        fctidz f1,f1
        fcfid f0,f1
        stfd f1,-16(r1) ; <--- not needed
        stfd f0,0(r4)
        blr

--------
On the Yara branch we get:
        fctidz f0,f1
        fcfid f0,f0
        stfd f0,0(r4)
        blr

So this is a RA issue, I am recording this to make sure that the next ra that
goes in as default actually fixes it.


-- 
           Summary: double to long long and back to double stores to the
                    stack
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: missed-optimization, ra
          Severity: enhancement
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
GCC target triplet: powerpc64-*-*
OtherBugsDependingO 18427
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
@ 2006-06-23  1:42 ` pinskia at gcc dot gnu dot org
  2006-06-23  2:01 ` pinskia at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-23  1:42 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from pinskia at gcc dot gnu dot org  2006-06-23 01:41 -------
*** Bug 26525 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at bigpond dot net
                   |                            |dot au


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
  2006-06-23  1:42 ` [Bug middle-end/27946] " pinskia at gcc dot gnu dot org
@ 2006-06-23  2:01 ` pinskia at gcc dot gnu dot org
  2007-10-23 17:24 ` [Bug target/27946] " pinskia at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-06-23  2:01 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pinskia at gcc dot gnu dot org  2006-06-23 01:42 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-06-23 01:42:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
  2006-06-23  1:42 ` [Bug middle-end/27946] " pinskia at gcc dot gnu dot org
  2006-06-23  2:01 ` pinskia at gcc dot gnu dot org
@ 2007-10-23 17:24 ` pinskia at gcc dot gnu dot org
  2007-10-23 17:34 ` dje at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-10-23 17:24 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from pinskia at gcc dot gnu dot org  2007-10-23 17:24 -------
Ok, changing the constraint to "!f#r" fixes the problem without a performance
issue so I am going to test it.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
          Component|middle-end                  |target


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2007-10-23 17:24 ` [Bug target/27946] " pinskia at gcc dot gnu dot org
@ 2007-10-23 17:34 ` dje at gcc dot gnu dot org
  2007-10-23 17:36 ` pinskia at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: dje at gcc dot gnu dot org @ 2007-10-23 17:34 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from dje at gcc dot gnu dot org  2007-10-23 17:34 -------
It might be appropriate for both fix_truncdfdi2 and floatdidf2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2007-10-23 17:34 ` dje at gcc dot gnu dot org
@ 2007-10-23 17:36 ` pinskia at gcc dot gnu dot org
  2007-10-23 17:40 ` dje at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-10-23 17:36 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from pinskia at gcc dot gnu dot org  2007-10-23 17:35 -------
(In reply to comment #4)
> It might be appropriate for both fix_truncdfdi2 and floatdidf2.

That is exactly what I am testing.  I ran the benchmarks which I have for the
PS3 toolchain and there was no performance regressions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2007-10-23 17:36 ` pinskia at gcc dot gnu dot org
@ 2007-10-23 17:40 ` dje at gcc dot gnu dot org
  2007-10-23 17:59 ` pinskia at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: dje at gcc dot gnu dot org @ 2007-10-23 17:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from dje at gcc dot gnu dot org  2007-10-23 17:40 -------
What about *f#r ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2007-10-23 17:40 ` dje at gcc dot gnu dot org
@ 2007-10-23 17:59 ` pinskia at gcc dot gnu dot org
  2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
  2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-10-23 17:59 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from pinskia at gcc dot gnu dot org  2007-10-23 17:58 -------
(In reply to comment #6)
> What about *f#r ?

Well that says don't consider f for the register class chosing at all and does
not fix the issue as it still choses the GPR register class.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
@ 2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-03-21 22:19 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from pinskia at gcc dot gnu dot org  2008-03-21 22:19 -------
Subject: Bug 27946

Author: pinskia
Date: Fri Mar 21 22:18:23 2008
New Revision: 133439

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133439
Log:
2008-03-21  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR target/27946
        * config/rs6000/rs6000.md (floatdidf2): Discouraging fprs and
        encouraging but not allowing gprs for input;
        change the input constraint to !f#r.
        (fix_truncdfdi2): Discouraging fprs and encouraging but not allowing
        gprs for output;
        change the output constraint to !f#r.


2008-03-21  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR target/27946
        * gcc.target/powerpc/ppc64-double-1.c: New testcase.



Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug target/27946] double to long long and back to double stores to the stack
  2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2007-10-23 17:59 ` pinskia at gcc dot gnu dot org
@ 2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
  2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-03-21 22:19 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from pinskia at gcc dot gnu dot org  2008-03-21 22:18 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27946


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2008-03-21 22:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-08  5:00 [Bug middle-end/27946] New: double to long long and back to double stores to the stack pinskia at gcc dot gnu dot org
2006-06-23  1:42 ` [Bug middle-end/27946] " pinskia at gcc dot gnu dot org
2006-06-23  2:01 ` pinskia at gcc dot gnu dot org
2007-10-23 17:24 ` [Bug target/27946] " pinskia at gcc dot gnu dot org
2007-10-23 17:34 ` dje at gcc dot gnu dot org
2007-10-23 17:36 ` pinskia at gcc dot gnu dot org
2007-10-23 17:40 ` dje at gcc dot gnu dot org
2007-10-23 17:59 ` pinskia at gcc dot gnu dot org
2008-03-21 22:19 ` pinskia at gcc dot gnu dot org
2008-03-21 22:19 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).