[Bug tree-optimization/28544] New: [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[Bug tree-optimization/28544] New: [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

I get the following gcc 4.2 regression:

11031:tbm@deprecation: ~] /usr/lib/gcc-snapshot/bin/g++ -c -O2
mysql-sp_cache.cc
mysql-sp_cache.cc: In function 'void sp_cache_invalidate()':
mysql-sp_cache.cc:20: internal compiler error: in add_virtual_operand, at
tree-ssa-operands.c:1309
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
11032:tbm@deprecation: ~] /usr/lib/gcc-snapshot/bin/g++ -c -O mysql-sp_cache.cc
11033:tbm@deprecation: ~] g++-4.1 -c -O2 mysql-sp_cache.cc
11034:tbm@deprecation: ~] g++-4.0 -c -O2 mysql-sp_cache.cc
11035:tbm@deprecation: ~] cat mysql-sp_cache.cc
extern "C"
{
  extern "C"
  {
    typedef unsigned long int ulong;
  }
  typedef struct
  {
    volatile int counter;
  }
  atomic_t;
  static __inline__ void atomic_inc (atomic_t * v)
  {
    __asm__ __volatile__ ("lock ; "
                          "incl %0":"=m" (v->counter):"m" (v->counter));
  }
}
static ulong volatile Cversion = 0;
void
sp_cache_invalidate ()
{
  atomic_inc ((atomic_t *) & Cversion);
}


-- 
           Summary: [4.2 regression] ICE in add_virtual_operand, at tree-
                    ssa-operands.c:1309
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-07-30 13:53 -------
First I like to say this is violating C++ aliasing rules but that is a
different story.

Second this is most likely a dup of bug 28479.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |28479
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

------- Comment #2 from tbm at cyrius dot com  2006-07-30 13:55 -------
(In reply to comment #1)
> First I like to say this is violating C++ aliasing rules but that is a
> different story.
> 
> Second this is most likely a dup of bug 28479.

Are you sure you got that bug number right?  I'm seeing this ICE not just with
current 4.2 but also from many months ago (will try to narrow down a date in a
minute).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

------- Comment #3 from tbm at cyrius dot com  2006-07-30 13:59 -------
Reproducible with gcc 4.2.0 way back to 20060325.  I've nothing older around
right now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-07-30 14:26 -------
Oh, yes it is unrelated to that PR.  In fact I think the aliasing violating
causes the problem.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
  BugsThisDependsOn|28479                       |
           Keywords|                            |ice-on-valid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-07-30 14:44 -------
Confirmed (reduced C and C++ testcases:
typedef unsigned long int ulong;
typedef struct
{
  volatile int counter;
}atomic_t;
static ulong volatile Cversion = 0;
void
sp_cache_invalidate ()
{
  atomic_t * v1 = (atomic_t *)& Cversion;
  atomic_t * v = v1;
  __asm__ __volatile__ ("lock ; incl %0":"=m" (v->counter):"m" (v->counter));
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-07-30 14:44:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-07-30 14:45 -------
Even without the volatile, it ICEs:
typedef unsigned long int ulong;
typedef struct
{
  int counter;
}atomic_t;
static ulong Cversion = 0;
void
sp_cache_invalidate ()
{
  atomic_t * v1 = (atomic_t *)& Cversion;
  atomic_t * v = v1;
  __asm__ __volatile__ ("lock ; incl %0":"=m" (v->counter):"m" (v->counter));
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[janis at gcc dot gnu dot org]

------- Comment #7 from janis at gcc dot gnu dot org  2006-08-08 15:54 -------
A regression hunt using an i686-linux cross compiler with the testcase from
comment #6 identified the following patch:

    http://gcc.gnu.org/viewcvs?view=rev&rev=111300

    r111300 | dberlin | 2006-02-20 13:38:01 +0000 (Mon, 20 Feb 2006)


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dberlin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at gcc dot gnu dot org]

------- Comment #8 from dberlin at gcc dot gnu dot org  2006-08-09 14:38 -------
I can trivially fix this, but the code isn't going to do what you want when i'm
done, since it is an aliasing violation :)

The assert in question just happens to be good at catching them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at gcc dot gnu dot org]

-- 

dberlin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dberlin at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-07-30 14:44:23         |2006-08-09 14:40:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

------- Comment #9 from tbm at cyrius dot com  2006-09-02 13:27 -------
Here's another testcase.  It fails at -O3.  Is this code problematic too?


(sid)45:tbm@usurper: ~] /usr/lib/gcc-snapshot/bin/g++ -c -O3 p7zip-SHA256.cc
p7zip-SHA256.cc: In member function 'void
NCrypto::NSHA256::SHA256::WriteByteBlock()':
p7zip-SHA256.cc:16: internal compiler error: in add_virtual_operand, at
tree-ssa-operands.c:1309
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
zsh: exit 1     /usr/lib/gcc-snapshot/bin/g++ -c -O3 p7zip-SHA256.cc
(sid)46:tbm@usurper: ~] /usr/lib/gcc-snapshot/bin/g++ -c -O2 p7zip-SHA256.cc
(sid)47:tbm@usurper: ~]


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

------- Comment #10 from tbm at cyrius dot com  2006-09-02 13:27 -------
Created an attachment (id=12174)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12174&action=view)
test case

Testcase from application "p7zip".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2006-09-02 16:29 -------
(In reply to comment #9)
> Here's another testcase.  It fails at -O3.  Is this code problematic too?
No it is not problematic but it is a different bug.  Can you file it
seperately?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[tbm at cyrius dot com]

------- Comment #12 from tbm at cyrius dot com  2006-09-02 16:34 -------
(In reply to comment #11)
> (In reply to comment #9)
> > Here's another testcase.  It fails at -O3.  Is this code problematic too?
> No it is not problematic but it is a different bug.  Can you file it
> seperately?

Sure, PR28937


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2/4.3 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[bero at arklinux dot org]

------- Comment #14 from bero at arklinux dot org  2006-11-27 12:58 -------
Created an attachment (id=12700)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12700&action=view)
Different code triggering the same error

Different code extracted from dirac, triggering the same error (goes away with
-fno-strict-aliasing)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2/4.3 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at dberlin dot org]

------- Comment #15 from dberlin at gcc dot gnu dot org  2006-11-27 13:54 -------
Subject: Re:  [4.2 regression] ICE in add_virtual_operand, at
tree-ssa-operands.c:1309

I assume the attached fixes this?


On 15 Oct 2006 09:01:42 -0000, tbm at cyrius dot com
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #13 from tbm at cyrius dot com  2006-10-15 09:01 -------
> (In reply to comment #8)
> > I can trivially fix this, but the code isn't going to do what you want when i'm
> > done, since it is an aliasing violation :)
> >
> > The assert in question just happens to be good at catching them.
>
> *ping*
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544
>
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
> You are the assignee for the bug, or are watching the assignee.
>


------- Comment #16 from dberlin at gcc dot gnu dot org  2006-11-27 13:54 -------
Created an attachment (id=12701)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12701&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2007-02-01 16:40 -------
Still fails on the 4.2 branch.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2006-08-09 14:40:27         |2007-02-01 16:40:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[rguenth at gcc dot gnu dot org]

------- Comment #18 from rguenth at gcc dot gnu dot org  2007-02-01 16:41 -------
And yes, the attached fixes it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[howarth at nitro dot med dot uc dot edu]

------- Comment #19 from howarth at nitro dot med dot uc dot edu  2007-02-04 17:23 -------
Did the patch fixing this on gcc 4.2 branch get posted to the gcc-patches
mailing list?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[mmitchel at gcc dot gnu dot org]

------- Comment #20 from mmitchel at gcc dot gnu dot org  2007-02-19 23:33 -------
Is there a backport of the mainline patch that I could review, or ask another
maintainer to review for inclusion in 4.2?

Thanks,

-- Mark


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at gcc dot gnu dot org]

------- Comment #21 from dberlin at gcc dot gnu dot org  2007-02-19 23:41 -------
(In reply to comment #20)
> Is there a backport of the mainline patch that I could review, or ask another
> maintainer to review for inclusion in 4.2?
> 
> Thanks,
> 
> -- Mark
> 

The attached patch named "access_debugging.diff" should apply and work for 4.2.
Let me know if you would like it there.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[mmitchel at gcc dot gnu dot org]

------- Comment #22 from mmitchel at gcc dot gnu dot org  2007-03-12 18:27 -------
Danny, please apply the patch to 4.2.0.

Thanks,

-- Mark


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at gcc dot gnu dot org]

------- Comment #23 from dberlin at gcc dot gnu dot org  2007-03-12 19:09 -------
Subject: Bug 28544

Author: dberlin
Date: Mon Mar 12 19:09:05 2007
New Revision: 122857

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122857
Log:
2007-03-12  Daniel Berlin  <dberlin@dberlin.org>

        Fix PR tree-optimization/28544
        * tree-ssa-operands.c (add_virtual_operand):
        Move assert triggering on aliasing violations into
        debugging define



Modified:
    branches/gcc-4_2-branch/gcc/ChangeLog
    branches/gcc-4_2-branch/gcc/tree-ssa-operands.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544

[Bug tree-optimization/28544] [4.2 regression] ICE in add_virtual_operand, at tree-ssa-operands.c:1309

[dberlin at gcc dot gnu dot org]

------- Comment #24 from dberlin at gcc dot gnu dot org  2007-03-12 19:12 -------
Fixed


-- 

dberlin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28544