public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/28685] Multiple comparisons are not simplified
Date: Sun, 05 Feb 2012 12:42:00 -0000	[thread overview]
Message-ID: <bug-28685-4-tV51IdWd7U@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-28685-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28685

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Target Milestone|---                         |4.8.0

--- Comment #18 from Uros Bizjak <ubizjak at gmail dot com> 2012-02-05 12:40:17 UTC ---
(In reply to comment #17)
> The only one which is not fixed is comment #4

Following patch that enables post-reload compare elimination:

--cut here--
Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c  (revision 183904)
+++ config/i386/i386.c  (working copy)
@@ -38685,6 +38685,9 @@
 #undef TARGET_EXPAND_TO_RTL_HOOK
 #define TARGET_EXPAND_TO_RTL_HOOK ix86_maybe_switch_abi

+#undef TARGET_FLAGS_REGNUM
+#define TARGET_FLAGS_REGNUM FLAGS_REG
+
 #undef TARGET_LEGITIMATE_ADDRESS_P
 #define TARGET_LEGITIMATE_ADDRESS_P ix86_legitimate_address_p

--cut here--

generates (-O2):

test:
        xorl    %edx, %edx
        cmpl    %esi, %edi
        movl    $1, %eax
        sete    %dl
        cmovge  %edx, %eax
        ret

Please note missing comparison.

This shows that the pass is effective for x86_64, but will be enabled for 4.8.


  parent reply	other threads:[~2012-02-05 12:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-28685-4@http.gcc.gnu.org/bugzilla/>
2012-01-12  1:07 ` pinskia at gcc dot gnu.org
2012-02-05 12:42 ` ubizjak at gmail dot com [this message]
2012-02-06 21:37 ` ubizjak at gmail dot com
2012-04-22 12:42 ` ubizjak at gmail dot com
2012-04-22 12:46 ` ubizjak at gmail dot com
2012-04-22 12:48 ` ubizjak at gmail dot com
2014-10-31  4:02 ` pinskia at gcc dot gnu.org
2006-08-10 18:15 [Bug middle-end/28685] New: " uros at kss-loka dot si
2006-08-10 18:18 ` [Bug middle-end/28685] " pinskia at gcc dot gnu dot org
2008-04-30 15:13 ` rguenth at gcc dot gnu dot org
2008-09-06 16:34 ` ubizjak at gmail dot com
2008-10-12 20:46 ` rguenth at gcc dot gnu dot org
2009-04-24  9:24 ` rguenth at gcc dot gnu dot org
2009-04-24  9:25 ` rguenth at gcc dot gnu dot org
2009-06-24  7:49 ` steven at gcc dot gnu dot org
2009-06-24  9:15 ` rguenth at gcc dot gnu dot org
2009-09-17 10:25 ` ubizjak at gmail dot com
2010-05-07  2:32 ` sandra at codesourcery dot com
2010-05-08  3:44 ` sandra at codesourcery dot com
2010-05-08 15:54 ` sandra at gcc dot gnu dot org
2010-05-24 13:22 ` sandra at codesourcery dot com
2010-05-25  8:12 ` rguenther at suse dot de
2010-06-01  2:24 ` sandra at codesourcery dot com
2010-06-08 18:16 ` sandra at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28685-4-tV51IdWd7U@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).