public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns
@ 2006-08-23 21:23 stuart at apple dot com
2006-08-23 21:28 ` [Bug target/28825] " pinskia at gcc dot gnu dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: stuart at apple dot com @ 2006-08-23 21:23 UTC (permalink / raw)
To: gcc-bugs
X-Bugzilla-Reason: CC
+++ This bug was initially created as a clone of Bug #24073 +++
Take the following example:
#define vector __attribute__((vector_size(16)))
float a; float b;
vector float f(void) { return (vector float){ a, b, 0.0, 0.0}; }
---
Currently we get:
subl $12, %esp
movss _b, %xmm0
movss _a, %xmm1
unpcklps %xmm0, %xmm1
movaps %xmm1, %xmm0
xorl %eax, %eax
xorl %edx, %edx
movl %eax, (%esp)
movl %edx, 4(%esp)
xorps %xmm1, %xmm1
movlhps %xmm1, %xmm0
addl $12, %esp
------
We should be able to produce:
movss _b, %xmm0
movss _a, %xmm1
shufps 60, /*[0, 3, 3, 0]*/, %xmm1, %xmm0 // _a, 0, 0, _b
shufps 201, /*[3, 0, 2, 1]*/, %xmm0, %xmm0 // _a, _b, 0, 0
This is from Nathan Begeman.
================================================================
------- Comment #4 From Uros Bizjak 2005-09-27 11:41 -------
I think that following example wins the contest:
vector float f(void) { return (vector float){ a, a, b, b}; }
gcc -O2 -msse -fomit-frame-pointer
subl $28, %esp
movss a, %xmm0
movss %xmm0, 4(%esp)
movss b, %xmm0
movd 4(%esp), %mm0
punpckldq %mm0, %mm0
movss %xmm0, 4(%esp)
movq %mm0, 16(%esp)
movd 4(%esp), %mm0
punpckldq %mm0, %mm0
movq %mm0, 8(%esp)
movlps 16(%esp), %xmm1
movhps 8(%esp), %xmm1
addl $28, %esp
movaps %xmm1, %xmm0
ret
Note the usage of MMX registers.
------- Comment #5 From Andrew Pinski 2005-09-27 14:33 -------
(In reply to comment #4)
> I think that following example wins the contest:
>
> vector float f(void) { return (vector float){ a, a, b, b}; }
For this, it is a different bug. The issue with the above is that
ix86_expand_vector_init_duplicate check
for mmx_okay is bad.
Currently, we have
if (!mmx_ok && !TARGET_SSE)
but I if I change it to:
if (!mmx_ok)
we get:
movss _a, %xmm0
movss _b, %xmm1
unpcklps %xmm0, %xmm0
unpcklps %xmm1, %xmm1
movlhps %xmm1, %xmm0
Which looks ok to me. That testcase should be opened into another bug as it is
obviously wrong.
=====================================================================
Cloned from 24073 to track the MMX insn issue; the original 24073 problem is a
performance issue.
--
Summary: return (vector float) { a, a, b, b } generates unwanted
MMX insns
Product: gcc
Version: 4.2.0
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: stuart at apple dot com
GCC target triplet: i786-*-*
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
2006-08-23 21:28 ` [Bug target/28825] " pinskia at gcc dot gnu dot org
@ 2006-08-23 21:28 ` pinskia at gcc dot gnu dot org
2006-08-23 21:41 ` stuart at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-23 21:28 UTC (permalink / raw)
To: gcc-bugs
X-Bugzilla-Reason: CC
------- Comment #1 from pinskia at gcc dot gnu dot org 2006-08-23 21:28 -------
*** Bug 28826 has been marked as a duplicate of this bug. ***
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
@ 2006-08-23 21:28 ` pinskia at gcc dot gnu dot org
2006-08-23 21:28 ` pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-23 21:28 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2006-08-23 21:28 -------
Confirmed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-08-23 21:28:21
date| |
Summary|return (vector float) { a, |return (vector float) { a,
|a, b, b } generates unwanted|a, b, b } generates unwanted
|MMX insns |MMX insns
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
2006-08-23 21:28 ` [Bug target/28825] " pinskia at gcc dot gnu dot org
2006-08-23 21:28 ` pinskia at gcc dot gnu dot org
@ 2006-08-23 21:41 ` stuart at gcc dot gnu dot org
2006-08-23 21:44 ` stuart at apple dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: stuart at gcc dot gnu dot org @ 2006-08-23 21:41 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from stuart at gcc dot gnu dot org 2006-08-23 21:41 -------
Subject: Bug 28825
Author: stuart
Date: Wed Aug 23 21:41:35 2006
New Revision: 116356
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116356
Log:
PR 28825
* gcc/config/i386/i386.c (ix86_expand_vector_init_duplicate,
ix86_expand_vector_init_one_nonzero): Remove TARGET_SSE test.
* gcc.target/i386/20060821-1.c: New.
Added:
trunk/gcc/testsuite/gcc.target/i386/20060821-1.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/i386.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
` (2 preceding siblings ...)
2006-08-23 21:41 ` stuart at gcc dot gnu dot org
@ 2006-08-23 21:44 ` stuart at apple dot com
2006-08-24 3:41 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: stuart at apple dot com @ 2006-08-23 21:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from stuart at apple dot com 2006-08-23 21:44 -------
Per Ians email of 18aug2006, I've committed Andrew's fix as SVN revision
116356.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
` (3 preceding siblings ...)
2006-08-23 21:44 ` stuart at apple dot com
@ 2006-08-24 3:41 ` pinskia at gcc dot gnu dot org
2006-10-16 11:35 ` rguenth at gcc dot gnu dot org
2006-10-16 15:48 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-24 3:41 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2006-08-24 03:41 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.2.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
` (4 preceding siblings ...)
2006-08-24 3:41 ` pinskia at gcc dot gnu dot org
@ 2006-10-16 11:35 ` rguenth at gcc dot gnu dot org
2006-10-16 15:48 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2006-10-16 11:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from rguenth at gcc dot gnu dot org 2006-10-16 11:35 -------
Subject: Bug 28825
Author: rguenth
Date: Mon Oct 16 11:34:44 2006
New Revision: 117784
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117784
Log:
2006-10-16 Richard Guenther <rguenther@suse.de>
PR target/28960
Backport from mainline:
2006-08-23 Stuart Hastings <stuart@apple.com>
PR target/28825
* gcc/config/i386/i386.c (ix86_expand_vector_init_duplicate,
ix86_expand_vector_init_one_nonzero): Remove TARGET_SSE test.
* gcc.target/i386/20060821-1.c: New.
Added:
branches/gcc-4_1-branch/gcc/testsuite/gcc.target/i386/20060821-1.c
- copied unchanged from r116356,
trunk/gcc/testsuite/gcc.target/i386/20060821-1.c
Modified:
branches/gcc-4_1-branch/gcc/ChangeLog
branches/gcc-4_1-branch/gcc/config/i386/i386.c
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug target/28825] return (vector float) { a, a, b, b } generates unwanted MMX insns
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
` (5 preceding siblings ...)
2006-10-16 11:35 ` rguenth at gcc dot gnu dot org
@ 2006-10-16 15:48 ` pinskia at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-10-16 15:48 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.2.0 |4.1.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28825
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-10-16 15:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-23 21:23 [Bug target/28825] New: return (vector float) { a, a, b, b } generates unwanted MMX insns stuart at apple dot com
2006-08-23 21:28 ` [Bug target/28825] " pinskia at gcc dot gnu dot org
2006-08-23 21:28 ` pinskia at gcc dot gnu dot org
2006-08-23 21:41 ` stuart at gcc dot gnu dot org
2006-08-23 21:44 ` stuart at apple dot com
2006-08-24 3:41 ` pinskia at gcc dot gnu dot org
2006-10-16 11:35 ` rguenth at gcc dot gnu dot org
2006-10-16 15:48 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).