From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id DBB9F3858D20; Wed, 31 May 2023 02:20:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DBB9F3858D20
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1685499658;
	bh=LplVtVxBS63ClVlS2U3SwcfjDC7wkwoBkyTr54nCcCE=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=vv3woSKVBcfAJaRatoFQ0vvyE/ghgzJq5davvgFEO2BtTwBuE3HYFnj8pIadsK7Wy
	 xPjYoya6UR4+LyjxNdEtvBHu63bd2YiJ9nL1wZ/xfsSb+kBNJ4F9PSBYZ7IBZqrm2R
	 xW5jWqzBNJtg1+5kaLcyotB64EcS8ahVYJpxS884=
From: "egallager at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/29970] mixing ({...}) with VLA leads to massive breakage
Date: Wed, 31 May 2023 02:20:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.3.0
X-Bugzilla-Keywords: ice-on-valid-code, patch, stmt-expr, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: egallager at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29970-4-2TLJhQMwzh@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-29970-4@http.gcc.gnu.org/bugzilla/>
References: <bug-29970-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D29970

--- Comment #17 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to CVS Commits from comment #16)
> The master branch has been updated by Martin Uecker <uecker@gcc.gnu.org>:
>=20
> https://gcc.gnu.org/g:4e6bf0b9dd5585df1a1472d6a93b9fff72fe2524
>=20
> commit r12-5338-g4e6bf0b9dd5585df1a1472d6a93b9fff72fe2524
> Author: Martin Uecker <uecker@gcc.gnu.org>
> Date:   Wed Nov 17 14:20:59 2021 +0100
>=20
>     Fix ICE when mixing VLAs and statement expressions [PR91038]
>=20=20=20=20=20
>     When returning VM-types from statement expressions, this can
>     lead to an ICE when declarations from the statement expression
>     are referred to later. Most of these issues can be addressed by
>     gimplifying the base expression earlier in gimplify_compound_lval.
>     Another issue is fixed by wrapping the pointer expression in
>     pointer_int_sum. This fixes PR91038 and some of the test cases
>     from PR29970 (structs with VLA members need further work).
>=20=20=20=20=20
>     gcc/
>             PR c/91038
>             PR c/29970
>             * gimplify.c (gimplify_var_or_parm_decl): Update comment.
>             (gimplify_compound_lval): Gimplify base expression first.
>             (gimplify_target_expr): Add comment.
>=20=20=20=20=20
>     gcc/c-family/
>             PR c/91038
>             PR c/29970
>             * c-common.c (pointer_int_sum): Make sure pointer expressions
>             are evaluated first when the size expression depends on for
>             variably-modified types.
>=20=20=20=20=20
>     gcc/testsuite/
>             PR c/91038
>             PR c/29970
>             * gcc.dg/vla-stexp-3.c: New test.
>             * gcc.dg/vla-stexp-4.c: New test.
>             * gcc.dg/vla-stexp-5.c: New test.
>             * gcc.dg/vla-stexp-6.c: New test.
>             * gcc.dg/vla-stexp-7.c: New test.
>             * gcc.dg/vla-stexp-8.c: New test.
>             * gcc.dg/vla-stexp-9.c: New test.

Is this fixed now, or is it staying open for backports?=