[Bug fortran/30237] New: Alternate return arguments in intrinsic subroutine calls are ignored

[Bug fortran/30237] New: Alternate return arguments in intrinsic subroutine calls are ignored

[brooks at gcc dot gnu dot org]

Alternate-return arguments in argument lists are represented by a null symbol
or expression pointer.  In intrinsic.c, remove_nullargs() simply removes
null-pointer symbols from the argument list handled by an intrinsic function or
subroutine.  Ergo, an alternate-return actual argument in an intrinsic
subroutine call will simply be skipped over and ignored.  The following code
demonstrates this:

-------------------------------------------------------------------

debian-gfortran:~/test> cat ar1.f90
program ar1
    real t1
    call cpu_time(*20, t1)
20  write(*,*) t1
end

debian-gfortran:~/test> ../bin-trunk/bin/gfortran ar1.f90
debian-gfortran:~/test> ./a.out
  1.2997000E-02
debian-gfortran:~/test> ../bin-trunk/bin/gfortran --version
GNU Fortran 95 (GCC) 4.3.0 20061128 (experimental)
Copyright (C) 2006 Free Software Foundation, Inc.


-- 
           Summary: Alternate return arguments in intrinsic subroutine calls
                    are ignored
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: brooks at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] Alternate return arguments in intrinsic subroutine calls are ignored

[tobi at gcc dot gnu dot org]

------- Comment #1 from tobi at gcc dot gnu dot org  2006-12-17 20:22 -------
>From the comment preceding remove_nullargs() I wonder why it's called in the
beginning of sort_actual().


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] Alternate return arguments in intrinsic subroutine calls are ignored

[pault at gcc dot gnu dot org]

------- Comment #2 from pault at gcc dot gnu dot org  2006-12-19 12:48 -------
Created an attachment (id=12827)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12827&action=view)
Fix for the problem

With all the interface patches in place, to allow the overloading of
random_seed, the following gives the right errors in the right places

program ar1
    interface random_seed
      subroutine x (a, *)
        integer a
      end subroutine x
    end interface random_seed

    real t1(2)
    call cpu_time(*20, t1(1)) ! { dg-error "Too many arguments" }
    call random_seed(i, *20)
    call random_seed(i, *20, *30) ! { dg-error "not permitted" }
    stop
20  write(*,*) t1
30 stop
end

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] Alternate return arguments in intrinsic subroutine calls are ignored

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2006-12-19 17:09 -------
(In reply to comment #2)

> 
> With all the interface patches in place, to allow the overloading of
> random_seed, the following gives the right errors in the right places
> 
In fact, I would like to get some of the backlog reviewed and committed before
I submit this one.  The test in #2 is getting close to being interesting.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] Alternate return arguments in intrinsic subroutine calls are ignored

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2006-12-28 18:41 -------
Subject: Bug 30237

Author: pault
Date: Thu Dec 28 18:41:25 2006
New Revision: 120244

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120244
Log:
2006-12-28  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30034
        * resolve.c (resolve_formal_arglist): Exclude the test for
        pointers and procedures for subroutine arguments as well as
        functions.

        PR fortran/30237
        * intrinsic.c (remove_nullargs): Do not pass up arguments with
        a label. If the actual has a label and the formal has a type
        then emit an error.

2006-12-28  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30034
        * gfortran.dg/pure_formal_proc_1.f90: New test.

        PR fortran/30237
        * gfortran.dg/intrinsic_actual_3.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/intrinsic_actual_3.f90
    trunk/gcc/testsuite/gfortran.dg/pure_formal_proc_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] [4.2 and 4.1 only] Alternate return arguments in intrinsic subroutine calls are ignored

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2007-01-06 14:13 -------
Subject: Bug 30237

Author: pault
Date: Sat Jan  6 14:13:20 2007
New Revision: 120525

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120525
Log:
2007-01-06  Paul Thomas  <pault@gcc.gnu.org>

        Bug fixes from trunk

        PR fortran/30034
        * resolve.c (resolve_formal_arglist): Exclude the test for
        pointers and procedures for subroutine arguments as well as
        functions.

        PR fortran/30237
        * intrinsic.c (remove_nullargs): Do not pass up arguments with
        a label. If the actual has a label and the formal has a type
        then emit an error.

        PR fortran/25135
        * module.c (load_generic_interfaces): If the symbol is present
        and is not generic it is ambiguous.

        PR fortran/23060
        * intrinsic.c (compare_actual_formal ): Distinguish argument
        list functions from keywords.
        * intrinsic.c (sort_actual): If formal is NULL, the presence of
        an argument list function actual is an error.
        * trans-expr.c (conv_arglist_function) : New function to
        implement argument list functions %VAL, %REF and %LOC.
        (gfc_conv_function_call): Call it.
        * resolve.c (resolve_actual_arglist): Add arg ptype and check
        argument list functions.
        (resolve_function, resolve_call): Set value of ptype before
        calls to resolve_actual_arglist.
        * primary.c (match_arg_list_function): New function.
        (gfc_match_actual_arglist): Call it before trying for a
        keyword argument.

        PR fortran/27900
        * resolve.c (resolve_actual_arglist): If all else fails and a
        procedure actual argument has no type, see if a specific
        intrinsic matches.

        PR fortran/24325
        * resolve.c (resolve_function): If the function reference is
        FL_VARIABLE this is an error.

2007-01-06  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30034
        * gfortran.dg/pure_formal_proc_1.f90: New test.

        PR fortran/30237
        * gfortran.dg/intrinsic_actual_3.f90: New test.

        PR fortran/25135
        * gfortran.dg/generic_11.f90: New test.
        * gfortran.dg/interface_7.f90: Remove name clash between module
        name and procedure 'x' referenced in the interface.

        PR fortran/23060
        * gfortran.dg/c_by_val.c: Called by c_by_val_1.f.
        * gfortran.dg/c_by_val_1.f: New test.
        * gfortran.dg/c_by_val_2.f: New test.
        * gfortran.dg/c_by_val_3.f: New test.

        PR fortran/27900
        * gfortran.dg/intrinsic_actual_4.f90: New test.

        PR fortran/24325
        * gfortran.dg/func_decl_3.f90: New test.


Added:
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/c_by_val.c
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/c_by_val_1.f
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/c_by_val_2.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/c_by_val_3.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/func_decl_3.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/generic_11.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/intrinsic_actual_3.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/intrinsic_actual_4.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/pure_formal_proc_1.f90
Modified:
    branches/gcc-4_2-branch/gcc/fortran/ChangeLog
    branches/gcc-4_2-branch/gcc/fortran/interface.c
    branches/gcc-4_2-branch/gcc/fortran/intrinsic.c
    branches/gcc-4_2-branch/gcc/fortran/module.c
    branches/gcc-4_2-branch/gcc/fortran/primary.c
    branches/gcc-4_2-branch/gcc/fortran/resolve.c
    branches/gcc-4_2-branch/gcc/fortran/trans-expr.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/dummy_procedure_1.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/interface_7.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] [4.1 only] Alternate return arguments in intrinsic subroutine calls are ignored

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2007-01-06 14:16 -------
Fixed on trunk and 4.2

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.2 and 4.1 only] Alternate|[4.1 only] Alternate return
                   |return arguments in         |arguments in intrinsic
                   |intrinsic subroutine calls  |subroutine calls are ignored
                   |are ignored                 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237

[Bug fortran/30237] [4.1 only] Alternate return arguments in intrinsic subroutine calls are ignored

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30237