public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "guojiufu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/30271] -mstrict-align can an store extra for struct agrument passing
Date: Fri, 08 Dec 2023 11:01:21 +0000	[thread overview]
Message-ID: <bug-30271-4-Qrb55l7mys@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-30271-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271

Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guojiufu at gcc dot gnu.org

--- Comment #13 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #10)
> (In reply to comment #9)
> > Andrew, 
> > 
> > What is your point here?
> 
> My point here is that currently we do:
>       gi->frame_related =
>         (base == frame_pointer_rtx) || (base == hard_frame_pointer_rtx);
> 
> But if we change it to be:
>       gi->frame_related =
>         (base == frame_pointer_rtx) || (base == hard_frame_pointer_rtx)
>         || (base == arg_pointer_rtx && fixed_regs[ARG_POINTER_REGNUM]);
> 
> It would delete the store (at least in a 4.3 based compiler). 
> arg_pointer_rtx is the incoming argument space so if it is a fixed register
> it will be also frame related and we can safely delete the stores to this
> space.

https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639550.html is using
this idea too.  And the 'std' in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c2 disappeared.

  parent reply	other threads:[~2023-12-08 11:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/>
2020-05-21  6:15 ` luoxhu at gcc dot gnu.org
2023-12-08 11:01 ` guojiufu at gcc dot gnu.org [this message]
2023-12-19  5:18 ` cvs-commit at gcc dot gnu.org
2024-01-04  1:06 ` [Bug target/30271] -mstrict-align can add an store extra for struct argument passing guojiufu at gcc dot gnu.org
2024-01-20 17:13 ` pinskia at gcc dot gnu.org
2006-12-21  2:49 [Bug target/30271] New: -mstrict-align can cause bad code generation for struct agrument passing pinskia at gcc dot gnu dot org
2008-12-11  4:44 ` [Bug target/30271] -mstrict-align can an store extra " pinskia at gcc dot gnu dot org
2008-12-15 15:34 ` zadeck at naturalbridge dot com
2008-12-16  2:09 ` pinskia at gcc dot gnu dot org
2008-12-29 23:53 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30271-4-Qrb55l7mys@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).