[Bug c++/30619] New: G++ OpenMP uses TREE_COMPLEXITY

[Bug c++/30619] New: G++ OpenMP uses TREE_COMPLEXITY

[steven at gcc dot gnu dot org]

from cp/cp-tree.h:

/* Used to store the operation code when in a template context.  */
#define OMP_ATOMIC_CODE(NODE) \
  (OMP_ATOMIC_CHECK (NODE)->exp.complexity)

This is blocking the removal of TREE_COMPLEXITY, which is a significant source
of waste of memory in gcc.


-- 
           Summary: G++ OpenMP uses TREE_COMPLEXITY
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: memory-hog
          Severity: enhancement
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: steven at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30619

[Bug c++/30619] G++ OpenMP uses TREE_COMPLEXITY

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2007-01-28 00:38 -------
Created an attachment (id=12973)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12973&action=view)
patch which needs testing and a little cleanup including documentation/comment
fixes

I quickly tested this on:
template <typename t>
int Birkhoff_with_Vol_para(int n)
{
t I;
#pragma omp atomic
I++;
}

int f(int a)
{
  return Birkhoff_with_Vol_para<int>(a);
}

And I got the correct result, there still needs some cleanup of the patch, the
OMP_ATOMIC_TP_* macros need their comments fixed as I just copied from
STATIC_ASSERT_*.  I need to check on line numbering issues but other than those
two, it should work.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30619

[Bug c++/30619] G++ OpenMP uses TREE_COMPLEXITY

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-01-28 00:49 -------
I have a fix for the line number issue I found after creating the above patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30619

[Bug c++/30619] G++ OpenMP uses TREE_COMPLEXITY

[steven at gcc dot gnu dot org]

------- Comment #3 from steven at gcc dot gnu dot org  2007-03-30 21:05 -------
TREE_COMPLEXITY is history


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30619