[Bug tree-optimization/30666] New: warning: canonical types differ for identical types double __complex__ and double __complex__

[Bug tree-optimization/30666] New: warning: canonical types differ for identical types double __complex__ and double __complex__

[ubizjak at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3702 bytes --]

Attached testcase (delta didn't reduce it any further) produces several
warnings, when compiled with -O2:

gcc -O2 -S render_1.ii
render_1.ii: In function âint pov::create_ray(pov::RAY*, double, double, int)â:
render_1.ii:6494: warning: canonical types differ for identical types double
__complex__ and double __complex__
 <complex_type 0xb77a2b60
    type <real_type 0xb7ce06e8 double sizes-gimplified type_6 DF
        size <integer_cst 0xb7cc2420 constant invariant 64>
        unit size <integer_cst 0xb7cc2438 constant invariant 8>
        align 64 symtab 0 alias set 2 canonical type 0xb7ce06e8 precision 64
        pointer_to_this <pointer_type 0xb7ce0820> reference_to_this
<reference_type 0xb793b6e8>>
    DC
    size <integer_cst 0xb7cc24f8 type <integer_type 0xb7cd8068 bit_size_type>
constant invariant 128>
    unit size <integer_cst 0xb7cc2510 type <integer_type 0xb7cd8000 unsigned
int> constant invariant 16>
    align 64 symtab 0 alias set -1 canonical type 0xb77a2b60>
 <complex_type 0xb7ce0d68 complex double
    type <real_type 0xb7ce06e8 double sizes-gimplified type_6 DF
        size <integer_cst 0xb7cc2420 constant invariant 64>
        unit size <integer_cst 0xb7cc2438 constant invariant 8>
        align 64 symtab 0 alias set 2 canonical type 0xb7ce06e8 precision 64
        pointer_to_this <pointer_type 0xb7ce0820> reference_to_this
<reference_type 0xb793b6e8>>
    DC
    size <integer_cst 0xb7cc24f8 type <integer_type 0xb7cd8068 bit_size_type>
constant invariant 128>
    unit size <integer_cst 0xb7cc2510 type <integer_type 0xb7cd8000 unsigned
int> constant invariant 16>
    align 64 symtab 0 alias set -1 canonical type 0xb7ce0d68>
render_1.ii:6494: warning: canonical types differ for identical types double
__complex__ and double __complex__
 <complex_type 0xb77a2b60
    type <real_type 0xb7ce06e8 double sizes-gimplified type_6 DF
        size <integer_cst 0xb7cc2420 constant invariant 64>
        unit size <integer_cst 0xb7cc2438 constant invariant 8>
        align 64 symtab 0 alias set 2 canonical type 0xb7ce06e8 precision 64
        pointer_to_this <pointer_type 0xb7ce0820> reference_to_this
<reference_type 0xb793b6e8>>
    DC
    size <integer_cst 0xb7cc24f8 type <integer_type 0xb7cd8068 bit_size_type>
constant invariant 128>
    unit size <integer_cst 0xb7cc2510 type <integer_type 0xb7cd8000 unsigned
int> constant invariant 16>
    align 64 symtab 0 alias set -1 canonical type 0xb77a2b60>
 <complex_type 0xb7ce0d68 complex double
    type <real_type 0xb7ce06e8 double sizes-gimplified type_6 DF
        size <integer_cst 0xb7cc2420 constant invariant 64>
        unit size <integer_cst 0xb7cc2438 constant invariant 8>
        align 64 symtab 0 alias set 2 canonical type 0xb7ce06e8 precision 64
        pointer_to_this <pointer_type 0xb7ce0820> reference_to_this
<reference_type 0xb793b6e8>>
    DC
    size <integer_cst 0xb7cc24f8 type <integer_type 0xb7cd8068 bit_size_type>
constant invariant 128>
    unit size <integer_cst 0xb7cc2510 type <integer_type 0xb7cd8000 unsigned
int> constant invariant 16>
    align 64 symtab 0 alias set -1 canonical type 0xb7ce0d68>


-- 
           Summary: warning: canonical types differ for identical types
                    double __complex__ and double __complex__
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ubizjak at gmail dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug tree-optimization/30666] warning: canonical types differ for identical types double __complex__ and double __complex__

[ubizjak at gmail dot com]

------- Comment #1 from ubizjak at gmail dot com  2007-02-01 13:59 -------
Created an attachment (id=12993)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12993&action=view)
testcase

Testcase, compile with gcc -O2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug tree-optimization/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-02-01 20:03 -------
And this is the reason why it needs to be an ICE earlier because we don't see
these bugs until late.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|warning: canonical types    |[4.3 Regression] warning:
                   |differ for identical types  |canonical types differ for
                   |double __complex__ and      |identical types double
                   |double __complex__          |__complex__ and double
                   |                            |__complex__
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug tree-optimization/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[ubizjak at gmail dot com]

------- Comment #3 from ubizjak at gmail dot com  2007-02-22 11:04 -------
These warnirngs disappear by commenting out TARGET_HAS_SINCOS in
config/linux.h.

These warnings indeed point to pov::create_ray, where we have quite some tree
sincos transformations:

int pov::create_ray(pov::RAY*, double, double, int) (Ray, x, y, ray_number)
{
  complex double sincostmp.447;
  complex double sincostmp.446;
  complex double sincostmp.445;
  complex double sincostmp.444;
  complex double sincostmp.443;
  complex double sincostmp.442;
  complex double sincostmp.441;
  complex double sincostmp.440;
  complex double sincostmp.439;
  complex double sincostmp.438;
  complex double sincostmp.437;

I'm adding Richard Guenther to the CC as he worken on tree sincos
transformation a while ago.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug tree-optimization/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2007-02-22 12:21 -------
Dough - how is the middle-end supposed to handle this?  The case in question
get's a
  double sin(double)
and wants to build
  _Complex double cexpi(double)

It now uses tree.c:build_complex_type which seems to fix TYPE_CANONICAL in some
way.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doug dot gregor at gmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-02-22 17:21 -------
There is also code in build_common_tree_nodes_2 which needs changed to use
build_complex_type which also could be causing issues too.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
          Component|tree-optimization           |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[doug dot gregor at gmail dot com]

------- Comment #6 from doug dot gregor at gmail dot com  2007-02-26 15:26 -------
This looks like a straightforward fix to build_common_tree_nodes2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2007-03-02 15:37 -------
(In reply to comment #6)
> This looks like a straightforward fix to build_common_tree_nodes2.

Is it possible to provide a patch for this? This warning is generated during
povray compilation, and povray is part of SPEC2006 package.

(I'm self-confirming the bug, as the problem can be shown by compiling attached
testcase.)


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-03-02 15:37:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[doug dot gregor at gmail dot com]

------- Comment #8 from doug dot gregor at gmail dot com  2007-03-03 19:50 -------
Patch is here: http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00191.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[patchapp at dberlin dot org]

------- Comment #9 from patchapp at dberlin dot org  2007-03-03 19:50 -------
Subject: Bug number PR 30666

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00191.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[dgregor at gcc dot gnu dot org]

-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dgregor at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-03-02 15:37:59         |2007-03-28 15:30:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[patchapp at dberlin dot org]

------- Comment #10 from patchapp at dberlin dot org  2007-03-29 14:25 -------
Subject: Bug number PR 30666

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01939.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[dgregor at gcc dot gnu dot org]

------- Comment #11 from dgregor at gcc dot gnu dot org  2007-03-29 15:11 -------
Subject: Bug 30666

Author: dgregor
Date: Thu Mar 29 15:11:28 2007
New Revision: 123330

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123330
Log:
2007-03-29  Douglas Gregor  <doug.gregor@gmail.com>

        PR tree-optimization/30666
        * tree.c (build_complex_type): When creating type names for DWARF2
        debug info, create TYPE_DECLs for TYPE_NAME instead of
        IDENTIFIER_NODEs.
        (build_common_tree_nodes_2): Use build_complex_type when building
        predefined complex types, to preserve canonical types.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666

[Bug middle-end/30666] [4.3 Regression] warning: canonical types differ for identical types double __complex__ and double __complex__

[dgregor at gcc dot gnu dot org]

------- Comment #12 from dgregor at gcc dot gnu dot org  2007-03-29 15:14 -------
Fix committed to mainline


-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30666