[Bug fortran/31129] New: No warning on unused parameters

[Bug fortran/31129] New: No warning on unused parameters

[terry at chem dot gu dot se]

I think this is what #31124 is really about.

Consider the following:

program fred
integer::i
integer,parameter::j=9
end

With -Wunused a warning is generated for i, but not j.  (At least with my 4.2
prerelease.)


-- 
           Summary: No warning on unused parameters
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: terry at chem dot gu dot se


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2007-03-17 11:40:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[dfranke at gcc dot gnu dot org]

------- Comment #1 from dfranke at gcc dot gnu dot org  2007-07-09 10:18 -------
Emit a warning if an unused parameter is found (-Wunused/-Wall), currently
regtesting:

Index: trans-decl.c
===================================================================
--- trans-decl.c        (revision 126478)
+++ trans-decl.c        (working copy)
@@ -3035,6 +3035,12 @@
       if (sym->attr.dummy && sym->backend_decl != NULL_TREE)
          TREE_NO_WARNING(sym->backend_decl) = 1;
     }
+  else if (sym->attr.flavor == FL_PARAMETER)
+    {
+      if (warn_unused_variable && !sym->attr.referenced)
+       gfc_warning ("unused parameter '%s' declared at %L", sym->name,
+                    &sym->declared_at);
+    }

   if (sym->attr.dummy == 1)
     {


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org
         AssignedTo|unassigned at gcc dot gnu   |dfranke at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-03-17 11:40:46         |2007-07-09 10:18:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[patchapp at dberlin dot org]

------- Comment #2 from patchapp at dberlin dot org  2007-07-09 12:10 -------
Subject: Bug number PR31129

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-07/msg00776.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[dfranke at gcc dot gnu dot org]

------- Comment #3 from dfranke at gcc dot gnu dot org  2007-07-09 14:57 -------
Subject: Bug 31129

Author: dfranke
Date: Mon Jul  9 14:56:49 2007
New Revision: 126486

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126486
Log:
gcc/fortran:
2007-07-09  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/31129
        * trans-decl.c (generate_local_decl) Emit a warning if an unused
        parameter is found.

gcc/testsuite:
2007-07-09  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/31129
        * gfortran.dg/parameter_unused.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/parameter_unused.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[dfranke at gcc dot gnu dot org]

------- Comment #4 from dfranke at gcc dot gnu dot org  2007-07-09 14:58 -------
Fixed in trunk. Not a regression, no backport. Closing.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129

[Bug fortran/31129] No warning on unused parameters

[dfranke at gcc dot gnu dot org]

------- Comment #5 from dfranke at gcc dot gnu dot org  2007-07-09 15:00 -------
Closing again. This time, I mean it.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31129