public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tobi at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/31313]  New: consecutive strcmps are not merged
Date: Thu, 22 Mar 2007 15:12:00 -0000	[thread overview]
Message-ID: <bug-31313-8513@http.gcc.gnu.org/bugzilla/> (raw)

I just ran into some code which did something like

int strcmp(const char *, const char *);

int f (const char *c)
{
  return (strcmp (c, "aaa") == 0 || strcmp (c, "aab") == 0);
}

It would be possible to optimize this into something like (hopefully I get it
right)
int f (const char *c)
{
  if (strncmp (c, "aa", 2))
    return 0;
  return ((c[2] == 'a' || c[2] == 'b') && !c[3]);
}

Instead, we scan through the whole string twice, as can be seen in the
assembly.

Likewise, more complicated combinations of comparisons could be reduced into an
optimal matching sequence.  Putting this into component rtl-optimization,
because the strcmp calls survive all of the tree optimizers unchanged.


-- 
           Summary: consecutive strcmps are not merged
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31313


             reply	other threads:[~2007-03-22 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 15:12 tobi at gcc dot gnu dot org [this message]
2007-03-22 15:28 ` [Bug tree-optimization/31313] " pinskia at gcc dot gnu dot org
2007-04-29  6:47 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31313-8513@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).