[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-03-24 11:02:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] New: Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

In libgfortran/intrinsics/stat.c, we unconditionally issue calls to stat(),
fstat() and lstat(). This is wrong, and these calls should be protected by
HAVE_{,F,L}STAT macros, themselves defined by autoconf.

This bug is annoying especially for lstat(), because it's non-POSIX and it's
not present on mingw; this, in turns, prevent us from creating a DLL
libgfortran (when the recent libtool patch by Steve Ellcey will be commited, it
will be the only bug still preventing this!). In the lstat() case, when lstat()
is not available and stat() is available, we should use it instead.

PS: We already have a test HAVE_WORKING_STAT that is used by the I/O system to
see if the system stat implementation fits the needs of the I/O code, but this
is unrelated.


-- 
           Summary: Calls lstat(), stat() and fstat() in libgfortran should
                    be protected by autoconf HAVE_{L,,F}STAT macros
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: fxcoudert at gcc dot gnu dot org
        ReportedBy: fxcoudert at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2007-
                   |                            |03/msg01605.html
           Keywords|                            |patch
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[dannysmith at users dot sourceforge dot net]

------- Comment #1 from dannysmith at users dot sourceforge dot net  2007-03-25 11:12 -------
http://gcc.gnu.org/ml/fortran/2006-10/msg00583.html
Danny


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

------- Comment #2 from fxcoudert at gcc dot gnu dot org  2007-03-25 11:19 -------
(In reply to comment #1)
> http://gcc.gnu.org/ml/fortran/2006-10/msg00583.html

Yes, thanks, I know. I followed in my patch
(http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01605.html) the idea I already
had at that time: if lstat() is not available, instead of not providing the
library function for LTAT, we'll use stat().


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

------- Comment #3 from fxcoudert at gcc dot gnu dot org  2007-03-31 20:41 -------
Subject: Bug 31335

Author: fxcoudert
Date: Sat Mar 31 20:41:11 2007
New Revision: 123388

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123388
Log:
        PR libfortran/31335
        * intrinsics/stat.c: Only provide STAT and FSTAT library routines
        if stat() and fstat() library functions are available. When lstat()
        is not available, use stat() instead.
        * configure.ac: Add checks for stat, fstat and lstat.
        * configure: Regenerate.
        * config.h.in: Regenerate.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/config.h.in
    trunk/libgfortran/configure
    trunk/libgfortran/configure.ac
    trunk/libgfortran/intrinsics/stat.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2007-03-31 20:42 -------
Fixed on 4.3.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335

[Bug libfortran/31335] Calls lstat(), stat() and fstat() in libgfortran should be protected by autoconf HAVE_{L,,F}STAT macros

[fxcoudert at gcc dot gnu dot org]

------- Comment #5 from fxcoudert at gcc dot gnu dot org  2007-04-13 20:56 -------
Subject: Bug 31335

Author: fxcoudert
Date: Fri Apr 13 20:56:19 2007
New Revision: 123796

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123796
Log:
        PR libfortran/31335

        * intrinsics/stat.c: Only provide STAT and FSTAT library routines
        if stat() and fstat() library functions are available. When lstat()
        is not available, use stat() instead.
        * configure.ac: Add checks for stat, fstat and lstat.
        * configure: Regenerate.
        * config.h.in: Regenerate.

Modified:
    branches/gcc-4_2-branch/libgfortran/ChangeLog
    branches/gcc-4_2-branch/libgfortran/config.h.in
    branches/gcc-4_2-branch/libgfortran/configure
    branches/gcc-4_2-branch/libgfortran/configure.ac
    branches/gcc-4_2-branch/libgfortran/intrinsics/stat.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31335