[Bug testsuite/31369] New: 100's of new libgomp fails

[Bug testsuite/31369] New: 100's of new libgomp fails

[danglin at gcc dot gnu dot org]

Here's an example:

Executing on host: /test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/
/te
st/gnu/gcc/gcc/libgomp/testsuite/libgomp.c++/copyin-1.C 
-B/test/gnu/gcc/objdir/
hppa64-hp-hpux11.11/./libgomp/
-I/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libg
omp -I/test/gnu/gcc/gcc/libgomp/testsuite/.. -fmessage-length=0 -fopenmp  -O0
  -L/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgomp/.libs -lgomp
-L/test/gnu/
gcc/objdir/hppa64-hp-hpux11.11/./libgomp/../libstdc++-v3/src/.libs -lstdc++ -lm
  -o ./copyin-1.exe    (timeout = 300)
PASS: libgomp.c++/copyin-1.C  -O0  (test for excess errors)
Setting LD_LIBRARY_PATH to
.:/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgomp/
.libs:/test/gnu/gcc/objdir/gcc
:/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgo
mp/../libstdc++-v3/src/.libs:.:/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./libgom
p/.libs:/test/gnu/gcc/objdir/gcc
:/test/gnu/gcc/objdir/hppa64-hp-hpux11.11/./lib
gomp/../libstdc++-v3/src/.libs
/usr/lib/pa20_64/dld.sl: Unable to find library 'libgcc_s.sl'.
FAIL: libgomp.c++/copyin-1.C  -O0  execution test


-- 
           Summary: 100's of new libgomp fails
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.11
  GCC host triplet: hppa2.0w-hp-hpux11.11
GCC target triplet: hppa2.0w-hp-hpux11.11


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[danglin at gcc dot gnu dot org]

------- Comment #1 from danglin at gcc dot gnu dot org  2007-04-05 00:25 -------
It appears to me that there is extraneous whitespace in LD_LIBRARY_PATH.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[danglin at gcc dot gnu dot org]

------- Comment #2 from danglin at gcc dot gnu dot org  2007-04-05 01:15 -------
I think the fails were introduced by the following change:

2007-03-18  Uros Bizjak  <ubizjak@gmail.com>

        * testsuite/config/default.exp: New file.
        ...


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[ubizjak at gmail dot com]

------- Comment #3 from ubizjak at gmail dot com  2007-04-05 06:38 -------
Perhaps hppa64 needs the same change to libgomp.exp as in
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01497.html ?

These tests all fail because shared libgcc library is not found.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-04-05 06:38:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #4 from dave at hiauly1 dot hia dot nrc dot ca  2007-04-06 22:59 -------
Subject: Re:  100's of new libgomp fails

> Perhaps hppa64 needs the same change to libgomp.exp as in
> http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01497.html ?

I don't think this is necessary.

> These tests all fail because shared libgcc library is not found.

Yes (well almost all).  They fail because of whitespace in LD_LIBRARY_PATH
in the c++ and fortran tests.  You can see it in the test log.

The enclosed change fixes the problem for me.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

Index: testsuite/libgomp.c++/c++.exp
===================================================================
--- testsuite/libgomp.c++/c++.exp       (revision 123536)
+++ testsuite/libgomp.c++/c++.exp       (working copy)
@@ -28,7 +28,7 @@
     # Gather a list of all tests.
     set tests [lsort [glob -nocomplain $srcdir/$subdir/*.C]]

-    set ld_library_path [concat $always_ld_library_path
":${blddir}/${lang_library_path}"]
+    set ld_library_path
"$always_ld_library_path:${blddir}/${lang_library_path}"
     set_ld_library_path_env_vars

     # Main loop.
Index: testsuite/libgomp.fortran/fortran.exp
===================================================================
--- testsuite/libgomp.fortran/fortran.exp       (revision 123536)
+++ testsuite/libgomp.fortran/fortran.exp       (working copy)
@@ -12,7 +12,7 @@
     # Gather a list of all tests.
     set tests [lsort [find $srcdir/$subdir *.\[fF\]{,90,95,03}]]

-    set ld_library_path [concat $always_ld_library_path
":${blddir}/${lang_library_path}"]
+    set ld_library_path
"$always_ld_library_path:${blddir}/${lang_library_path}"
     set_ld_library_path_env_vars

     # Main loop.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[patchapp at dberlin dot org]

------- Comment #5 from patchapp at dberlin dot org  2007-04-06 23:35 -------
Subject: Bug number PR testsuite/31369

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-04/msg00284.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[danglin at gcc dot gnu dot org]

------- Comment #6 from danglin at gcc dot gnu dot org  2007-04-07 16:10 -------
Subject: Bug 31369

Author: danglin
Date: Sat Apr  7 16:10:06 2007
New Revision: 123638

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123638
Log:
        PR testsuite/31369
        * testsuite/libgomp.c++/c++.exp: Don't use concat when setting
        ld_library_path.
        * testsuite/libgomp.fortran/fortran.exp: Likewise.


Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.c++/c++.exp
    trunk/libgomp/testsuite/libgomp.fortran/fortran.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[danglin at gcc dot gnu dot org]

------- Comment #7 from danglin at gcc dot gnu dot org  2007-04-07 16:13 -------
Fixed.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369

[Bug testsuite/31369] 100's of new libgomp fails

[ghazi at gcc dot gnu dot org]

------- Comment #8 from ghazi at gcc dot gnu dot org  2008-03-11 15:36 -------
Subject: Bug 31369

Author: ghazi
Date: Tue Mar 11 15:35:51 2008
New Revision: 133114

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133114
Log:
        PR target/26149

        Backport:

        2007-03-18 Uros Bizjak <ubizjak@gmail.com>

        * testsuite/config/default.exp: New file.
        * testsuite/lib/libgomp.exp: New file.
        * testsuite/lib/libgomp.dg (load_gcc_lib, libgomp_init,
        libgomp_target_compile, libgomp_option_help, libgomp_option_proc,
        load_lib *, load_gcc_lib *): Move to libgomp.exp.
        (libgomp_load): Remove.
        * testsuite/lib/libgomp.exp (libgomp_init): Compute
        always_ld_library_path, not ld_library_path. Set additional_flags
        to -march=i486 for ilp32 x86_64-*-* and i386-*-* targets.
        (target_compile): Do not call libgomp_init. Append
        lang_library_path and lang_link_flags to options.
        * testsuite/libgomp.c/c.exp: Set DEFAULT_FLAGS to -O2. Set
        ld_library_path from always_ld_library_path. Set LD_LIBRARY_PATH here.
        * testsuite/libgomp.c++/c++.exp: Set ld_library_path from
        always_ld_library_path. Set LD_LIBRARY_PATH here.
        * testsuite/libgomp.fortran/fortran.exp: Ditto.
        * testsuite/libgomp.c/atomic-1.c: Set dg-options to
        "-O2 -march=pentium" for ilp32 x86 targets. Simplify check for CX8
flag.
        * testsuite/libgomp.c/pr29947-1.c: Remove default dg-options.
        * testsuite/libgomp.c/pr29947-1.c: Ditto.
        * testsuite/libgomp.c/atomic-10.c: Ditto.

        2007-03-22 Andreas Tobler <a.tobler@schweiz.org>

        * testsuite/lib/libgomp.exp (libgomp_init): Add -shared-libgcc for
        *-*-darwin*.
        * testsuite/libgomp.c++/c++.exp: Look for shared libstdc++ library
        and use it if found.

        2007-04-06  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

        PR testsuite/31369
        * testsuite/libgomp.c++/c++.exp: Don't use concat when setting
        ld_library_path.
        * testsuite/libgomp.fortran/fortran.exp: Likewise.

        2007-03-21  Jakub Jelinek  <jakub@redhat.com>

        * testsuite/libgomp.fortran/appendix-a/a.22.8.f90: Add
        dg-final cleanup-modules line.
        * testsuite/libgomp.fortran/appendix-a/a.40.1.f90: Likewise.
        * testsuite/libgomp.fortran/appendix-a/a.31.5.f90: Likewise.
        * testsuite/libgomp.fortran/appendix-a/a.31.4.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate2.f90: Likewise.
        * testsuite/libgomp.fortran/reduction5.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate3.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate1.f90: Likewise.

        2007-10-25  Jakub Jelinek  <jakub@redhat.com>

        PR libgomp/33275
        * testsuite/libgomp.fortran/omp_parse3.f90 (test_threadprivate):
        Make x and y integers rather than (implicit) reals.  Add private (j)
        clause to the last omp parallel.


Added:
    branches/gcc-4_2-branch/libgomp/testsuite/config/
    branches/gcc-4_2-branch/libgomp/testsuite/config/default.exp
    branches/gcc-4_2-branch/libgomp/testsuite/lib/libgomp.exp
Modified:
    branches/gcc-4_2-branch/libgomp/ChangeLog
    branches/gcc-4_2-branch/libgomp/testsuite/lib/libgomp-dg.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c++/c++.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/atomic-1.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/atomic-10.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/c.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/pr29947-1.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/pr29947-2.c
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.22.8.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.31.4.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.31.5.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.40.1.f90
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/fortran.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/omp_parse3.f90
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/reduction5.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate1.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate2.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate3.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31369