[Bug middle-end/31490] Compile error section type conflict

[Bug middle-end/31490] Compile error section type conflict

[nicolas.veyssiere at thalesgroup dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Nicolas VEYSSIERE <nicolas.veyssiere at thalesgroup dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.veyssiere at
                   |                            |thalesgroup dot com

--- Comment #18 from Nicolas VEYSSIERE <nicolas.veyssiere at thalesgroup dot com> 2010-11-09 10:58:14 UTC ---
Hello, I have the same question as #17, I am using GCC on ia64 too, and this
problem is still in the last version of GCC (4.4.5), and if I apply the patch
of Dinar Temirbulatov (#9) it seems to works, (maybe I have to use the patch
proposed by Segher Boessenkool, #10, i don't know).

[Bug middle-end/31490] Compile error section type conflict

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #19 from Steve Ellcey <sje at gcc dot gnu.org> 2010-11-17 22:54:07 UTC ---
Author: sje
Date: Wed Nov 17 22:54:05 2010
New Revision: 166887

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166887
Log:
2010-11-17  Dinar Temirbulatov <dtemirbulatov@gmail.com>
        Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * varasm.c (categorize_decl_for_section): Ignore reloc_rw_mask
    if section attribute used.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/varasm.c

[Bug middle-end/31490] Compile error section type conflict

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #20 from Steve Ellcey <sje at gcc dot gnu.org> 2010-11-17 22:55:05 UTC ---
Author: sje
Date: Wed Nov 17 22:55:01 2010
New Revision: 166888

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166888
Log:
2010-11-17  Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * gcc.dg/pr31490.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr31490.c
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.6.0
            Summary|Compile error section type  |[4.6 Regression] Compile
                   |conflict                    |error section type conflict
      Known to fail|                            |

--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 14:00:25 UTC ---
This patch is wrong and causes DT_TEXTREL nscd.
The relocation mask should never be ignored, otherwise
static const char *const foo __attribute__((__used__, __section__ ("bar"))) =
"baz";
is incorrectly put into readonly section with -fpie or -fpic, eventhough it
must be writable.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #22 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 14:09:17 UTC ---
Created attachment 23140
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23140
gcc46-pr31490.patch

Incomplete patch.  pr31490-2.c testcase works (and thus the original one too),
but what still doesn't work is pr31490-3.c, as we call get_variable_section
only from assemble_variable at which point we immediately switch_to_section and
thus it is too late for the second variable to change section flags.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23140|0                           |1
        is obsolete|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 15:00:27 UTC ---
Created attachment 23142
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23142
gcc46-pr31490.patch

Updated patch.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #24 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-03 19:12:11 UTC ---
Author: jakub
Date: Thu Feb  3 19:12:07 2011
New Revision: 169804

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169804
Log:
    PR middle-end/31490
    * output.h (SECTION_RELRO): Define.
    (SECTION_MACH_DEP): Adjust.
    (get_variable_section): New prototype.
    * varpool.c (varpool_finalize_named_section_flags): New function.
    (varpool_assemble_pending_decls): Call it.
    * cgraph.h (varpool_finalize_named_section_flags): New prototype.
    * cgraphunit.c (cgraph_output_in_order): Call
    varpool_finalize_named_section_flags.
    * varasm.c (get_section): Allow section flags conflicts between
    relro and read-only sections if the section hasn't been declared yet.
    Set SECTION_OVERRIDE after diagnosing section type conflict.
    (get_variable_section): No longer static.
    (default_section_type_flags): Use SECTION_WRITE | SECTION_RELRO for
    readonly sections that need relocations.
    (decl_readonly_section_1): New function.
    (decl_readonly_section): Use it.

    Revert:
    2010-11-17  Dinar Temirbulatov <dtemirbulatov@gmail.com>
            Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * varasm.c (categorize_decl_for_section): Ignore reloc_rw_mask
    if section attribute used.

    * gcc.dg/pr31490-2.c: New test.
    * gcc.dg/pr31490-3.c: New test.
    * gcc.dg/pr31490-4.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr31490-2.c
    trunk/gcc/testsuite/gcc.dg/pr31490-3.c
    trunk/gcc/testsuite/gcc.dg/pr31490-4.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.h
    trunk/gcc/cgraphunit.c
    trunk/gcc/output.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/varasm.c
    trunk/gcc/varpool.c

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #25 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-03 19:18:19 UTC ---
Fixed.

[Bug middle-end/31490] Compile error section type conflict

[sje at cup dot hp dot com]

------- Comment #17 from sje at cup dot hp dot com  2010-04-16 22:29 -------
Is there any reason none of the patches created for this bug have been checked
in?  I still get a 'section type conflict' on IA64 with the test case from
Comment #2.


-- 

sje at cup dot hp dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at cup dot hp dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[etiennes at cse dot unsw dot edu dot au]

------- Comment #16 from etiennes at cse dot unsw dot edu dot au  2007-11-28 05:11 -------
I just tried compiling 2.6.23.9 ia64 and the compile failed citing
drivers/char/ipmi/ipmi_si_intf.c:1095: error: __param_hotmod causes a section
type conflict

gcc (GCC) 4.2.3 20071123 (prerelease) (Debian 4.2.2-4)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[drow at gcc dot gnu dot org]

------- Comment #15 from drow at gcc dot gnu dot org  2007-08-31 17:42 -------
Has Segher's patch been sent to gcc-patches?  I've just encountered the ppc64
bootstrap failure too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[janis at gcc dot gnu dot org]

------- Comment #14 from janis at gcc dot gnu dot org  2007-08-28 18:15 -------
The patch that I tried is the one attached for comment #10, not the one in
comment #9.  With that patch a bootstrap of all languages but Ada succeeded. 
The test results look reasonable, although I don't have results from the last
few days with which to compare them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[dtemirbulatov at gmail dot com]

------- Comment #13 from dtemirbulatov at gmail dot com  2007-08-28 16:25 -------
reviewed patch posted here
http://gcc.gnu.org/ml/gcc-patches/2007-05/msg01280.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[janis at gcc dot gnu dot org]

------- Comment #12 from janis at gcc dot gnu dot org  2007-08-27 21:54 -------
Trunk currently fails on powerpc64-linux building
libstdc++-v3/src/system_error.cc.  Hacking libtool a bit allows seeing the
message "std::system_category causes a section type conflict".  The file is
compiled with -O2 and -fdata-sections; if either of those is removed then the
bootstrap succeeds.

This PR looked related (and Andrew Pinski confirmed that it is) so I tried the
patch from comment #10; it needs more parens to avoid warnings, but with that
patch the bootstrap succeeds.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[schwab at suse dot de]

------- Comment #11 from schwab at suse dot de  2007-06-20 11:32 -------
Also broken on ia64.


-- 

schwab at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|powerpc64-*-linux-gnu       |powerpc64-*-linux-gnu,ia64-
                   |                            |*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[segher at kernel dot crashing dot org]

------- Comment #10 from segher at kernel dot crashing dot org  2007-05-18 14:57 -------
Created an attachment (id=13578)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13578&action=view)
proposed patch

still need to run the testsuite on it


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[dtemirbulatov at gmail dot com]

------- Comment #9 from dtemirbulatov at gmail dot com  2007-05-16 22:47 -------
This patch fixes both testcases

--- gcc/varasm.c.orig   2007-05-16 21:32:11.000000000 +0400
+++ gcc/varasm.c        2007-05-16 21:36:14.000000000 +0400
@@ -5762,12 +5762,14 @@ categorize_decl_for_section (tree decl, 
             be read-only or not, but whether the dynamic link will have to
             do something.  If so, we wish to segregate the data in order to
             minimize cache misses inside the dynamic linker.  */
-         if (reloc & targetm.asm_out.reloc_rw_mask ())
+         if (reloc & targetm.asm_out.reloc_rw_mask ()
+             && !lookup_attribute ("section", DECL_ATTRIBUTES (decl)))
            ret = reloc == 1 ? SECCAT_DATA_REL_LOCAL : SECCAT_DATA_REL;
          else
            ret = SECCAT_DATA;
        }
-      else if (reloc & targetm.asm_out.reloc_rw_mask ())
+      else if (reloc & targetm.asm_out.reloc_rw_mask ()
+              && !lookup_attribute ("section", DECL_ATTRIBUTES (decl)))
        ret = reloc == 1 ? SECCAT_DATA_REL_RO_LOCAL : SECCAT_DATA_REL_RO;
       else if (reloc || flag_merge_constants < 2)
        /* C and C++ don't allow different variables to share the same

, bootstraped and tested on i686-pc-linux-gnu with no new regressions, tested
4.2 version with gdb-sim on following architectures arm-elf, arm-none-eabi,
mips-elf, mipsisa64-elf, powerpc-eabisim, sh-elf, powerpc-unknown-eabispe with
no new regressions


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[segher at kernel dot crashing dot org]

------- Comment #8 from segher at kernel dot crashing dot org  2007-05-15 13:07 -------
Bisecting shows that the original bug (powerpc64 Linux build
errors out) is caused by r122781.  I didn't actually test on 4.2
but the same patch is applied there (as r122782).

If the reduced testcase in comment #2 fails on older compilers,
it is likely a different bug (or an invalid testcase); if a bug, please
file a separate PR for it.


-- 

segher at kernel dot crashing dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |segher at kernel dot
                   |                            |crashing dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

[Bug middle-end/31490] Compile error section type conflict

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2007-05-02 16:41 -------
> I can reproduce this bug any architecture with -fpic option

Oh and this is why it fails without -fpic on powerpc64-linux-gnu as really it
is always PIC with the toc based ABI.

>workaround for the bug:
Actually that looks like the correct fix from reading output.h's comment about
these section categories.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|target                      |middle-end
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-05-02 16:41:08
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490