[Bug middle-end/31490] Compile error section type conflict

[Bug middle-end/31490] Compile error section type conflict

[nicolas.veyssiere at thalesgroup dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Nicolas VEYSSIERE <nicolas.veyssiere at thalesgroup dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.veyssiere at
                   |                            |thalesgroup dot com

--- Comment #18 from Nicolas VEYSSIERE <nicolas.veyssiere at thalesgroup dot com> 2010-11-09 10:58:14 UTC ---
Hello, I have the same question as #17, I am using GCC on ia64 too, and this
problem is still in the last version of GCC (4.4.5), and if I apply the patch
of Dinar Temirbulatov (#9) it seems to works, (maybe I have to use the patch
proposed by Segher Boessenkool, #10, i don't know).

[Bug middle-end/31490] Compile error section type conflict

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #19 from Steve Ellcey <sje at gcc dot gnu.org> 2010-11-17 22:54:07 UTC ---
Author: sje
Date: Wed Nov 17 22:54:05 2010
New Revision: 166887

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166887
Log:
2010-11-17  Dinar Temirbulatov <dtemirbulatov@gmail.com>
        Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * varasm.c (categorize_decl_for_section): Ignore reloc_rw_mask
    if section attribute used.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/varasm.c

[Bug middle-end/31490] Compile error section type conflict

[sje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #20 from Steve Ellcey <sje at gcc dot gnu.org> 2010-11-17 22:55:05 UTC ---
Author: sje
Date: Wed Nov 17 22:55:01 2010
New Revision: 166888

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166888
Log:
2010-11-17  Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * gcc.dg/pr31490.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr31490.c
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.6.0
            Summary|Compile error section type  |[4.6 Regression] Compile
                   |conflict                    |error section type conflict
      Known to fail|                            |

--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 14:00:25 UTC ---
This patch is wrong and causes DT_TEXTREL nscd.
The relocation mask should never be ignored, otherwise
static const char *const foo __attribute__((__used__, __section__ ("bar"))) =
"baz";
is incorrectly put into readonly section with -fpie or -fpic, eventhough it
must be writable.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #22 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 14:09:17 UTC ---
Created attachment 23140
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23140
gcc46-pr31490.patch

Incomplete patch.  pr31490-2.c testcase works (and thus the original one too),
but what still doesn't work is pr31490-3.c, as we call get_variable_section
only from assemble_variable at which point we immediately switch_to_section and
thus it is too late for the second variable to change section flags.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23140|0                           |1
        is obsolete|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-01-27 15:00:27 UTC ---
Created attachment 23142
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23142
gcc46-pr31490.patch

Updated patch.

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

--- Comment #24 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-03 19:12:11 UTC ---
Author: jakub
Date: Thu Feb  3 19:12:07 2011
New Revision: 169804

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169804
Log:
    PR middle-end/31490
    * output.h (SECTION_RELRO): Define.
    (SECTION_MACH_DEP): Adjust.
    (get_variable_section): New prototype.
    * varpool.c (varpool_finalize_named_section_flags): New function.
    (varpool_assemble_pending_decls): Call it.
    * cgraph.h (varpool_finalize_named_section_flags): New prototype.
    * cgraphunit.c (cgraph_output_in_order): Call
    varpool_finalize_named_section_flags.
    * varasm.c (get_section): Allow section flags conflicts between
    relro and read-only sections if the section hasn't been declared yet.
    Set SECTION_OVERRIDE after diagnosing section type conflict.
    (get_variable_section): No longer static.
    (default_section_type_flags): Use SECTION_WRITE | SECTION_RELRO for
    readonly sections that need relocations.
    (decl_readonly_section_1): New function.
    (decl_readonly_section): Use it.

    Revert:
    2010-11-17  Dinar Temirbulatov <dtemirbulatov@gmail.com>
            Steve Ellcey  <sje@cup.hp.com>

    PR middle-end/31490
    * varasm.c (categorize_decl_for_section): Ignore reloc_rw_mask
    if section attribute used.

    * gcc.dg/pr31490-2.c: New test.
    * gcc.dg/pr31490-3.c: New test.
    * gcc.dg/pr31490-4.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr31490-2.c
    trunk/gcc/testsuite/gcc.dg/pr31490-3.c
    trunk/gcc/testsuite/gcc.dg/pr31490-4.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.h
    trunk/gcc/cgraphunit.c
    trunk/gcc/output.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/varasm.c
    trunk/gcc/varpool.c

[Bug middle-end/31490] [4.6 Regression] Compile error section type conflict

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31490

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #25 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-03 19:18:19 UTC ---
Fixed.