[Bug fortran/32179] New: Ensure that ss->string_length is always set [TODO item]

[Bug fortran/32179] New: Ensure that ss->string_length is always set [TODO item]

[burnus at gcc dot gnu dot org]

Just to now forget ...

To the patch to PR 32156, Paul Thomas wrote in
http://gcc.gnu.org/ml/fortran/2007-05/msg00531.html :

"There is something not right with string concatenation
in the front-end that fails to transmit the string length correctly.
I have made several attempts to get to the bottom of this and have
completely failed. "

Test case, see PR 32156 and revert the "hack" (see urls and patch at the
bottom) .

Commits:
http://gcc.gnu.org/ml/gcc-cvs/2007-05/msg00956.html
http://gcc.gnu.org/ml/gcc-cvs/2007-05/msg00955.html

Comment in the patch:
-      ss->expr->ts.cl->backend_decl = ss->string_length;
+      /* It is surprising but still possible to wind up with expressions that
+        lack a character length.
+        TODO Find the offending part of the front end and cure this properly.
+        Concatenation involving arrays is the main culprit.  */
+      if (!ss->expr->ts.cl)
+       {
+         ss->expr->ts.cl = gfc_get_charlen ();
+         ss->expr->ts.cl->next = gfc_current_ns->cl_list;
+         gfc_current_ns->cl_list = ss->expr->ts.cl->next;
+       }


-- 
           Summary: Ensure that ss->string_length is always set [TODO item]
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32179

[Bug fortran/32179] Ensure that ss->string_length is always set [TODO item]

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-06-01 16:01 -------
> Just to now forget ...

A Freudian slip, I presume. This should of cause be:

"Just to NOT forget [to fix it]..."


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32179

[Bug fortran/32179] Ensure that ss->string_length is always set [TODO item]

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-06-13 20:52:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32179

[Bug fortran/32179] Ensure that ss->string_length is always set [TODO item]

[pault at gcc dot gnu dot org]

------- Comment #2 from pault at gcc dot gnu dot org  2007-07-10 20:57 -------
Since i have taken on this stuff - actually the kludge has now gone in the
latest incarnation of the character patch - one more to go!

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-06-13 20:52:58         |2007-07-10 20:57:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32179

[Bug fortran/32179] Ensure that ss->string_length is always set [TODO item]

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2008-03-25 05:42 -------
Not only did the TODO disappear but the problem SEEMs to have done so too.  The
last attempt at a fix was pretty all embracing and has ensured that the
scalarizer is always getting a string expression to work with.  That said, I
just know that another such bug is going to appear:)

I am going to tempt fate...

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32179